[NoQA] Add missing prop to fix typecheck in test#68406
Conversation
|
@linhvovan29546 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
typecheck in test
1e8e431 to
f0a9473
Compare
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
There was a problem hiding this comment.
This fixes https://github.com/Expensify/App/actions/runs/16919414682/job/47941472731 which was introduced in #67065.
cc @roryabraham I think that's why you got pinged in https://expensify.slack.com/archives/C01GTK53T8Q/p1755023194590859
717172c to
cbb8eac
Compare
|
Ignoring the perf check |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/Julesssss in version: 9.1.94-0 🚀
|
|
🚀 Deployed to production by https://github.com/marcaaron in version: 9.1.94-4 🚀
|
Explanation of Change
This adds a missing required prop that was merged while this PR was in review.
Fixed Issues
$ #68400
$ #68398
Tests
Make sure
typecheckand unit test actions passOffline tests
N/A
QA Steps
N/A
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop