Migrate BusinessTypeSelectorModal to use Reanimated modal by OlGierd03 · Pull Request #67249 · Expensify/App

OlGierd03 · 2025-07-28T13:27:46Z

Explanation of Change

The code migrates BusinessTypeSelectorModal to use the new ReanimatedModal instead of the ReactNativeModal.

This PR is a fixed PR #66811 that was reversed due to #67015. To ensure this issue does not occur, perform the testing steps on android app and check that the field error is not triggered for company type after selecting the company type option.

Fixed Issues

$ #64778

Tests

The modal is rather hard to access and requires logging into bank account or manually providing one's bank info so to skip this process (skip points 8-14) you can modify the code as presented in points 1-2 (note that modifying these lines disables the back button from the panel you skip to).

Comment out (or delete) lines 37-41 in the BusinessInfo.tsx file:

Chenge few lines in the ReimbursementAccountPage.tsx as presented on screenshot:

CONST.BANK_ACCOUNT.STEP.COMPANY

Go to Workspaces tab
Create a workspace (+ New workspace) and change the Default currency to USD > Confirm
Company Cards > Learn more (about Get the Expensify Card - green button in the top right corner of the screen)
While in Expensify Card tab > Issue new card
Click on Log into your bank
While on Plaid, follow the instructions provided (providing informations and logging into bank account)
Choose an account
Provide and then Confirm your personal informations
Consent to process biometric data and sensitive data
Go through verifying identity
Enter the name of your company, alongside with Tax ID number, website, phone number and address
When asked for a company type click the Company type selector
Check if the modal properly slides in and out from the right

Offline tests

N/A

QA Steps

Go to Workspaces tab
Create a workspace (+ New workspace) and change the Default currency to USD > Confirm
Company Cards > Learn more (about Get the Expensify Card - green button in the top right corner of the screen)
While in Expensify Card tab > Issue new card
Click on Log into your bank
While on Plaid, follow the instructions provided (providing informations and logging into bank account)
Choose an account
Provide and then Confirm your personal informations
Consent to process biometric data and sensitive data
Go through verifying identity
Enter the name of your company, alongside with Tax ID number, website, phone number and address
When asked for a company type click the Company type selector
Check if the modal properly slides in and out from the right

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2025-07-29.at.11.34.53.mov

Android: mWeb Chrome

Screen.Recording.2025-07-29.at.13.18.49.mov

iOS: Native

Screen.Recording.2025-07-29.at.13.29.05.mov

iOS: mWeb Safari

Screen.Recording.2025-07-29.at.13.26.21.mov

MacOS: Chrome / Safari

Screen.Recording.2025-07-29.at.13.16.22.mov

MacOS: Desktop

Screen.Recording.2025-07-29.at.13.33.56.mov

…e prop

mhawryluk

Great!! 💪

jmusial

LGTM

melvin-bot · 2025-07-30T13:31:51Z

@ZhenjaHorbach Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ZhenjaHorbach · 2025-07-31T08:14:48Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

2025-07-31.10.34.28.mov

Android: mWeb Chrome

2025-07-23.12.55.15.mov

iOS: HybridApp

ios.mov

iOS: mWeb Safari

ios-web.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

web.mov

ZhenjaHorbach · 2025-07-31T08:58:10Z

-            useNativeDriver
+            onBackdropPress={() => {
+                onClose();
+                Navigation.dismissModal();


Just thinking
Do we really need Navigation.dismissModal(); here ?
Since now when we press to backdrop we close RHP completely
In main we return to the previous screen

2025-07-31.10.54.52.mov

This is coming from a thread here

I remember this 😅
But for me it's a bit of a specific flow
That after every press to backdrop I have to Continue setup
And these are unnecessary actions
But maybe for consistency it's ok !

ZhenjaHorbach · 2025-07-31T09:21:39Z

LGTM !

mountiny

Thanks!

melvin-bot · 2025-08-04T13:00:38Z

Congrats, that's your 5th PR merged! 🎉 Do you know about the ContributorPlus role? It's an opportunity to earn more in the Expensify Open Source community. Keep up the great work - thanks!

OSBotify · 2025-08-04T13:10:34Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-08-04T20:00:27Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.1.89-1 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

github-actions · 2025-08-06T19:31:23Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.1.89-21 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	failure ❌

Change business type selector modal to reanimated & delete onModalHid…

c9ce717

…e prop

OlGierd03 changed the title ~~Properly Migrate BusinessTypeSelectorModal to use Reanimated modal~~ Migrate BusinessTypeSelectorModal to use Reanimated modal Jul 28, 2025

Merge branch 'main' into @OlGierd03/reanimated-business-type-modal

d7c1eee

mhawryluk approved these changes Jul 30, 2025

View reviewed changes

jmusial approved these changes Jul 30, 2025

View reviewed changes

OlGierd03 marked this pull request as ready for review July 30, 2025 13:31

OlGierd03 requested a review from a team as a code owner July 30, 2025 13:31

melvin-bot Bot requested review from ZhenjaHorbach and removed request for a team July 30, 2025 13:31

jmusial mentioned this pull request Jul 30, 2025

[Due for payment 2025-09-02] [Due for payment 2025-08-20] [Due for payment 2025-08-13] Use react-native-reanimated in RIGHT_DOCKED Modals #64778

Closed

ZhenjaHorbach reviewed Jul 31, 2025

View reviewed changes

ZhenjaHorbach approved these changes Jul 31, 2025

View reviewed changes

melvin-bot Bot requested a review from mountiny July 31, 2025 09:21

mountiny assigned OlGierd03 Aug 4, 2025

mountiny approved these changes Aug 4, 2025

View reviewed changes

mountiny merged commit 18d4f1e into Expensify:main Aug 4, 2025
24 of 26 checks passed

github-actions Bot mentioned this pull request Aug 4, 2025

Deploy Checklist: New Expensify 2025-08-04 #67808

Closed

Conversation

OlGierd03 commented Jul 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

mhawryluk left a comment

Choose a reason for hiding this comment

Uh oh!

jmusial left a comment

Choose a reason for hiding this comment

Uh oh!

melvin-bot Bot commented Jul 30, 2025

Uh oh!

ZhenjaHorbach commented Jul 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

ZhenjaHorbach Jul 31, 2025

Choose a reason for hiding this comment

Uh oh!

jmusial Jul 31, 2025

Choose a reason for hiding this comment

Uh oh!

ZhenjaHorbach Jul 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ZhenjaHorbach commented Jul 31, 2025

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

melvin-bot Bot commented Aug 4, 2025

Uh oh!

OSBotify commented Aug 4, 2025

Uh oh!

github-actions Bot commented Aug 4, 2025

Uh oh!

github-actions Bot commented Aug 6, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

OlGierd03 commented Jul 28, 2025 •

edited

Loading

ZhenjaHorbach commented Jul 31, 2025 •

edited

Loading

ZhenjaHorbach Jul 31, 2025 •

edited

Loading