Skip to content

Migrate BusinessTypeSelectorModal to use Reanimated modal #67249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mountiny merged 2 commits into from
Aug 4, 2025
Merged

Migrate BusinessTypeSelectorModal to use Reanimated modal #67249

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c9ce717
Change business type selector modal to reanimated & delete onModalHid…
OlGierd03 Jul 28, 2025
d7c1eee
Merge branch 'main' into @OlGierd03/reanimated-business-type-modal
OlGierd03 Jul 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions ...t/USD/BusinessInfo/subSteps/TypeBusiness/BusinessTypePicker/BusinessTypeSelectorModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import SelectionList from '@components/SelectionList';
import RadioListItem from '@components/SelectionList/RadioListItem';
import useLocalize from '@hooks/useLocalize';
import useThemeStyles from '@hooks/useThemeStyles';
import Navigation from '@libs/Navigation/Navigation';
import CONST from '@src/CONST';
import type {BusinessTypeItemType, IncorporationType} from './types';

Expand Down Expand Up @@ -46,9 +47,11 @@ function BusinessTypeSelectorModal({isVisible, currentBusinessType, onBusinessTy
type={CONST.MODAL.MODAL_TYPE.RIGHT_DOCKED}
isVisible={isVisible}
onClose={onClose}
onModalHide={onClose}
hideModalContentWhileAnimating
useNativeDriver
onBackdropPress={() => {
onClose();
Navigation.dismissModal();
Copy link
Copy Markdown
Contributor

@ZhenjaHorbach ZhenjaHorbach Jul 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just thinking
Do we really need Navigation.dismissModal(); here ?
Since now when we press to backdrop we close RHP completely
In main we return to the previous screen

2025-07-31.10.54.52.mov

Copy link
Copy Markdown
Contributor

@jmusial jmusial Jul 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is coming from a thread here

Copy link
Copy Markdown
Contributor

@ZhenjaHorbach ZhenjaHorbach Jul 31, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remember this 😅
But for me it's a bit of a specific flow
That after every press to backdrop I have to Continue setup
And these are unnecessary actions
But maybe for consistency it's ok !

}}
shouldUseReanimatedModal
>
<ScreenWrapper
style={[styles.pb0]}
Expand Down
Loading