Add new comments to transaction thread for single transaction expense by aldo-expensify · Pull Request #68692 · Expensify/App

aldo-expensify · 2025-08-18T19:18:55Z

Explanation of Change

Re-implementation of this #68415, fixing bugs that it caused.

Changes: When a report has a single transactions and we merge reportActions for this report with the transaction thread, new comments should be added to the transaction thread instead of the main report. (more context: https://expensify.slack.com/archives/C090U774ZH7/p1754067856509739?thread_ts=1752726050.956949&cid=C090U774ZH7)

Parent components of ReportFooter are already obtaining the transaction thread reportID for reports with single transactions, so I'm just passing it down here.

Then, ReportFooter will prefer using the single transaction transactionThreadReportID instead of report.reportID if available.

The previous PR broke whispers because the code resolving whispers was using the reportID which pointed to the expense report when the whisper was in an expense report with a single transaction, even if the whisper reportAction belonged to the transaction thread.

This solves the issue by first trying to use originalReportID. originalReportID holds the correct reportID corresponding to the action being handled by PureReportActionItem.

Another issue handled here is auto-scrolling when a new comment is added: notifyNewAction handles scrolling to the bottom when we add a new comment. In single transaction expense reports we have to scroll to the bottom of the expense report, not the transaction thread.

And, another consideration is that we handle reports created in the "send money" flow differently, for those we don't want to use the transaction thread by default for new comments because we don't combine reportActions there.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/526433
PROPOSAL:

Tests

You need to disable the beta BETAS.NO_OPTIMISTIC_TRANSACTION_THREADS to test this properly

Messages are stored in the correct report:

Create an account in NewDot
Create a workspace
Create an empty report
Create an expense (transaction) in the expense report with any category that is NOT "Travel"
Send some messages in the expense report
Send a message like Set category to "Travel"
Verify that the category changes to "Travel" and an automatic response from Concierge appears:
Send another message
Create another transaction (the expense report doesn't have a single transaction anymore)
Verify that all messages sent before are now in the first transaction thread
Verify that the expense report conversation is empty

Attachments are stored in the correct report:

Create an empty report
Create an expense in the report
Add an image attachment
Verify you can see the attachment correctly
Create a new expense in the report
Verify that now the attachment is under the transaction thread of the first expense

Screen.Recording.2025-08-18.at.12.44.09.PM.mov

Test editing comment while offline:

Create an empty report
Create an expense within the report
Add a comment in the expense report
Go offline
Edit the comment
Verify that the offline edit looks well
Add another comment while offline
Edit the last comment and verify it looks well
Add another comment while offline
Edit the last comment removing all its content and confirm you want to delete it
Verify the last comment disappears
Go back online
Verify that the comments look correct

Screen.Recording.2025-08-21.at.4.41.54.PM.mov

Mention whisper:

Create an empty report
Create an expense in the report
Send a message mentioning another user (any email should work)
Verify you get a whisper from Concierge to invite the user
Dismiss the invitation clicking "Do nothing"
Add another message mentioning the same user
Verify you get a whisper from Concierge to invite the user
Create another expense in the report
Verify that all messages so far are now under the transaction thread of the first expense
Verify that dismissing the whisper from concierge works

Screen.Recording.2025-08-18.at.1.01.41.PM.mov

Mention whisper - deleting second expense:

Create an empty report
Create an expense in the report
Send a message mentioning another user (any email should work)
Create another expense in the report
Open the first expense transaction thread, and verify that all messages are here
Open the second expense transaction thread and delete the expense
Verify the mention-whisper should appear now in the main expense report chat
Click "Do nothing"
Verify that dismissing the whisper from concierge works

Screen.Recording.2025-08-20.at.4.23.31.PM.mov

Suggested category actionable whisper:

Create a clean workspace
Create an empty expense report
Create an expense with a like dsgdgrewerfwefaeg and don't select any category
Wait for Concierge to send a whisper suggesting category options
Click on a suggested category
Verify the actionable whisper disappears and Concierge adds a comment like set the category to "Other"
Create a new expense in the report
Verify that the messages went into the transaction thread and are not visible anymore from the expense report

Screen.Recording.2025-08-18.at.1.05.12.PM.mov

Report mention whisper:

Create an empty expense report
Create an expense within the report
Send a message referencing a room name, for example: #1232534543634522 hello
Verify a whisper appears
Click "No"
Verify the whisper dissappears correctly
Send another message referencing a room name, for example: #asdasda214234 asdsasf
Verify a new whisper appears
Create another expense
Verify your initial messages and the whisper is now under the transaction thread of the first transaction
Click "Yes" in the whisper
Verify the room is created

Screen.Recording.2025-08-18.at.1.06.39.PM.mov

Pay user flow (plus auto-scrolling)

Go to NewDot
Open 1:1 DM.
Click + > Pay user.
Enter amount > Next.
Click Mark as paid.
Open the expense report.
Send a message.
Message will appear as an individual message in the expense report.
Send many messages... enough for the scroll bar to appear.
Scroll to the top of the expense report
Send another message
Verify it automatically scrolled to the bottom

Screen.Recording.2025-08-15.at.12.50.26.PM.mov

Request money flow (plus auto-scrolling)

Go to NewDot
Open 1:1 DM.
Click + > Create expense.
Enter amount > Next.
Open the expense report.
Send many messages... enough for the scroll bar to appear.
Scroll to the top of the expense report
Send another message
Verify it automatically scrolled to the bottom
Create another expense in the same report
Verify that the first message now is under the first expense's transaction thread
Send a new message in the expense report
Verify the message appears in the expense report
Verify you can add messages in each expense's transaction threads individually
Go to the expense report
Send many messages... enough for the scroll bar to appear.
Scroll to the top of the expense report
Send another message
Verify it automatically scrolled to the bottom

Screen.Recording.2025-08-15.at.12.51.35.PM.mov

Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

… reports

melvin-bot · 2025-08-18T19:19:27Z

@cristipaval Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

…tion-thread-3

aldo-expensify · 2025-08-18T20:15:05Z

@jayeshmangwani ready for another round? 😓

jayeshmangwani · 2025-08-19T10:50:44Z

@aldo-expensify thanks for the new PR. I will start reviewing it and will try to cover many cases around report deletion, navigation, and offline behavior, and compare them with the prod version to make sure we can reach prod with this PR this time.

aldo-expensify · 2025-08-19T17:05:01Z

Thank you @jayeshmangwani 🙇

jayeshmangwani · 2025-08-20T12:28:07Z

@aldo-expensify buttons don’t work after deleting the second expense while offline.

Go to WS expenses.
Create an expense.
On that expense, send a message that contains a user’s email.
Create another expense.
Go offline.
Go to the second expense and delete it.
Now try pressing the whisper buttons (“Invite them” and “Do nothing”) on that email message.
Buttons don’t work.

buttons-doent-works.mov

Edit: It also doesn’t work when we delete it while online.

aldo-expensify · 2025-08-20T16:48:11Z

Thanks @jayeshmangwani , I'll investigate

aldo-expensify · 2025-08-20T21:12:48Z

I'm suspecting the bug is coming from the useMemo here not recalculating the originalReportID when it should, and maybe it is happening because we are mutating action somewhere:

App/src/pages/home/report/ReportActionItem.tsx

Line 88 in d6295c5

    
           const originalReportID = useMemo(() => getOriginalReportID(reportID, action), [reportID, action]);

Update: or maybe not a mutation, but a bug caused from reading data loading by Onyx.connect

aldo-expensify · 2025-08-20T23:32:46Z

+function useOriginalReportID(reportID: string | undefined, reportAction: OnyxInputOrEntry<ReportAction>): string | undefined {
+    const [reportActions] = useOnyx(`${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${reportID ?? CONST.DEFAULT_NUMBER_ID}`, {canBeMissing: true});
+    const [report] = useOnyx(`${ONYXKEYS.COLLECTION.REPORT}${reportID ?? CONST.DEFAULT_NUMBER_ID}`, {canBeMissing: true});
+    const [chatReport] = useOnyx(`${ONYXKEYS.COLLECTION.REPORT}${report?.chatReportID}`, {canBeMissing: true});
+
+    if (!reportID) {
+        return undefined;
+    }
+    const currentReportAction = reportAction?.reportActionID ? reportActions?.[reportAction.reportActionID] : undefined;
+
+    if (Object.keys(currentReportAction ?? {}).length === 0) {
+        const isThreadReportParentAction = reportAction?.childReportID?.toString() === reportID;
+        if (isThreadReportParentAction) {
+            return report?.parentReportID;
+        }
+        const transactionThreadReportID = getOneTransactionThreadReportID(report, chatReport, reportActions ?? ([] as ReportAction[]));
+        const retorno = transactionThreadReportID ?? reportID;
+        return retorno;
+    }
+    return reportID;
+}


Added this hook analog to the function ReportUtils::getOriginalReportID which was reading data from Onyx.connect and causing this: #68692 (comment)

aldo-expensify · 2025-08-20T23:35:23Z

Thanks @jayeshmangwani for catching data, it should be fixed now. I added the reproduction step as a testing case in the PR description.

jayeshmangwani · 2025-08-21T06:36:58Z

Testing the PR now.

jayeshmangwani · 2025-08-21T12:31:27Z

Not a big issue, but running into a minor bug in the offline case.

Steps to reproduce:

Go to WS expenses.
Go offline.
Create 1 expense.
Open that expense and send a message.
Right-click on the message , we can see 6 options, including Reply in thread, Edit comment, and Delete comment.
Now create another expense.
Delete the second expense.
Go back to the message we sent earlier, right-click again — now you only see 3 options, and the ones mentioned above (Reply in thread, Edit comment, Delete comment) are missing.

offline-bug.mov

…tion-thread-3

aldo-expensify · 2025-08-21T23:03:59Z

hmm, it is because when you do that offline, we find two IOU reportActions here:

App/src/libs/ReportActionsUtils.ts

Line 1329 in 2948a86

    
           // If we don't have any IOU request actions, or we have more than one IOU request actions, this isn't a oneTransaction report

so we consider it to not be a single-transaction expense report, and then we end up with the wrong originalReportID.

Having said that, there must be some inconsistency because the report is rendered as a single-transaction expense report, so we may have two different logics that don't find the same result.

aldo-expensify · 2025-08-21T23:44:17Z

@jayeshmangwani this should be working now, and while fixing that I also caught another bug I fixed:

Test editing comment while offline:

Create an empty report
Create an expense within the report
Add a comment in the expense report
Go offline
Edit the comment
Verify that the offline edit looks well
Add another comment while offline
Edit the last comment and verify it looks well
Add another comment while offline
Edit the last comment removing all its content and confirm you want to delete it
Verify the last comment disappears
Go back online
Verify that the comments look correct

Screen.Recording.2025-08-21.at.4.41.54.PM.mov

jayeshmangwani · 2025-08-22T11:44:33Z

While testing these steps #68692 (comment), I noticed that the second edited message is missing the edited flag after going online. The same issue is happening on staging, so it’s definitely not coming from our PR. We might want to report this as a new bug.

Offline:

After going online:

aldo-expensify · 2025-08-22T16:59:57Z

While testing these steps #68692 (comment), I noticed that the second edited message is missing the edited flag after going online. The same issue is happening on staging, so it’s definitely not coming from our PR. We might want to report this as a new bug.

Yes, I noticed too, but I was wondering if it could be a feature and not a bug. That message was edited before it was actually sent.

aldo-expensify · 2025-08-22T17:00:20Z

Please continue with the review/testing so we don't run into more conflicts

jayeshmangwani · 2025-08-24T08:34:33Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android.mov

Android: mWeb Chrome

mweb-chrome.mov

iOS: HybridApp

iOS.mov

iOS: mWeb Safari

mweb-safari.mov

MacOS: Chrome / Safari

web-2.mov

MacOS: Desktop

desktop.mov

jayeshmangwani

lgtm 🚀

melvin-bot · 2025-08-25T07:10:58Z

@nkuoch Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot · 2025-08-25T07:11:00Z

🎯 @jayeshmangwani, thanks for reviewing and testing this PR! 🎉

An E/App issue has been created to issue payment here: #69135.

nkuoch · 2025-08-25T07:48:28Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

OSBotify · 2025-08-25T08:00:29Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2025-08-26T11:20:47Z

🚀 Deployed to staging by https://github.com/nkuoch in version: 9.1.99-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-08-28T01:18:32Z

🚀 Deployed to production by https://github.com/thienlnam in version: 9.1.99-11 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Add new comments to transaction thread for single transaction expense…

44313cf

… reports

aldo-expensify self-assigned this Aug 18, 2025

aldo-expensify requested a review from a team as a code owner August 18, 2025 19:18

melvin-bot Bot requested a review from cristipaval August 18, 2025 19:19

melvin-bot Bot removed the request for review from a team August 18, 2025 19:19

aldo-expensify marked this pull request as draft August 18, 2025 19:21

aldo-expensify requested review from jayeshmangwani and removed request for cristipaval August 18, 2025 20:12

Handle attachments in single transaction reports

0be43f0

aldo-expensify marked this pull request as ready for review August 18, 2025 20:14

Merge branch 'main' of github.com:Expensify/App into aldo_use-transac…

5af9dc3

…tion-thread-3

Lint

d6295c5

Add useOriginalReportID hook

a5df0f3

aldo-expensify commented Aug 20, 2025

View reviewed changes

aldo-expensify added 4 commits August 20, 2025 16:36

Remove bad variable name

3c6f22b

Remove deprecated annotation

c9bc19f

Remove unnecessary defaults

2580c37

Remove unused import

02d1887

Merge branch 'main' of github.com:Expensify/App into aldo_use-transac…

2948a86

…tion-thread-3

Handle offline/online and deleted transactions

868e46f

aldo-expensify added 2 commits August 21, 2025 16:46

Prettier

1efc2c2

Remove TODO

8a29cdb

jayeshmangwani approved these changes Aug 25, 2025

View reviewed changes

melvin-bot Bot requested a review from nkuoch August 25, 2025 07:10

melvin-bot Bot mentioned this pull request Aug 25, 2025

Payment issue for E/App PR#68692 #69135

Closed

nkuoch approved these changes Aug 25, 2025

View reviewed changes

nkuoch merged commit afa5bf8 into main Aug 25, 2025
25 checks passed

nkuoch deleted the aldo_use-transaction-thread-3 branch August 25, 2025 07:49

OSBotify mentioned this pull request Aug 26, 2025

Deploy Checklist: New Expensify 2025-08-26 #69233

Closed

aldo-expensify restored the aldo_use-transaction-thread-3 branch August 26, 2025 17:27

aldo-expensify mentioned this pull request Aug 26, 2025

Revert "Add new comments to transaction thread for single transaction expense" #69281

Closed

This was referenced Aug 27, 2025

Attachments - "Its not here page" is shown when opening an attachment #69329

Closed

Whisper for room reference appears but is not clickable #69334

Closed

mkzie2 mentioned this pull request Aug 27, 2025

[$250] Expense- Incomplete message context menu & unresponsive whisper after deleting expense offline #68575

Closed

8 tasks

aldo-expensify mentioned this pull request Aug 27, 2025

[CP Staging] Revert "Add new comments to transaction thread for single transaction expense" #69375

Merged

vincdargento mentioned this pull request Aug 27, 2025

[Due for payment 2025-09-30] [$250] Expense - Last message behind the keypad after auto scrolling #69379

Closed

8 tasks

jponikarchuk mentioned this pull request Aug 27, 2025

Expense - Attachments are not stored in the correct report, empty report is shown #69388

Closed

8 tasks

aldo-expensify mentioned this pull request Aug 28, 2025

Add new comments to transaction thread for single transaction expense #69481

Merged

51 tasks

Conversation

aldo-expensify commented Aug 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Aug 18, 2025

Uh oh!

aldo-expensify commented Aug 18, 2025

Uh oh!

jayeshmangwani commented Aug 19, 2025

Uh oh!

aldo-expensify commented Aug 19, 2025

Uh oh!

jayeshmangwani commented Aug 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aldo-expensify commented Aug 20, 2025

Uh oh!

aldo-expensify commented Aug 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aldo-expensify Aug 20, 2025

Choose a reason for hiding this comment

Uh oh!

aldo-expensify commented Aug 20, 2025

Uh oh!

jayeshmangwani commented Aug 21, 2025

Uh oh!

jayeshmangwani commented Aug 21, 2025

Uh oh!

aldo-expensify commented Aug 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aldo-expensify commented Aug 21, 2025

Uh oh!

jayeshmangwani commented Aug 22, 2025

Uh oh!

aldo-expensify commented Aug 22, 2025

Uh oh!

aldo-expensify commented Aug 22, 2025

Uh oh!

jayeshmangwani commented Aug 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

jayeshmangwani left a comment

Choose a reason for hiding this comment

Uh oh!

melvin-bot Bot commented Aug 25, 2025

Uh oh!

melvin-bot Bot commented Aug 25, 2025

Uh oh!

nkuoch commented Aug 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

Uh oh!

OSBotify commented Aug 25, 2025

Uh oh!

OSBotify commented Aug 26, 2025

Uh oh!

OSBotify commented Aug 28, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

aldo-expensify commented Aug 18, 2025 •

edited

Loading

jayeshmangwani commented Aug 20, 2025 •

edited

Loading

aldo-expensify commented Aug 20, 2025 •

edited

Loading

aldo-expensify commented Aug 21, 2025 •

edited

Loading

jayeshmangwani commented Aug 24, 2025 •

edited

Loading

nkuoch commented Aug 25, 2025 •

edited

Loading