Conversation
|
@aldo-expensify do you know what's up with the failing Jest test, as well as the ESLint check? |
|
@amyevans the eslint failures are because my PR touched some files where eslint forced me to fix the imports. Now that we are reverting, it is reverting to the imports that eslint doesn't want: For example: 
I would just revert and ignore the eslint complaints, but if you prefer, I can commit something to fix the imports so eslint doesn't complain... but this wouldn't be "just a revert" anymore |
aldo-expensify
changed the title
thienlnam
left a comment
thienlnam
left a comment
There was a problem hiding this comment.
Just a straight revert, which is causing some eslint failures - this is known
|
@thienlnam looks like this was merged without a test passing. Please add a note explaining why this was done and remove the |
…ction-thread-3 [CP Staging] Revert "Add new comments to transaction thread for single transaction expense" (cherry picked from commit f373d0b) (cherry-picked to staging by thienlnam)
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Cherry-picked to staging by https://github.com/thienlnam in version: 9.1.99-10 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
|
🚀 Deployed to production by https://github.com/thienlnam in version: 9.1.99-11 🚀
|
|
🚀 Cherry-picked to staging by https://github.com/thienlnam in version: 9.2.0-0 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
|
🚀 Deployed to production by https://github.com/arosiclair in version: 9.2.0-5 🚀
|
|
🚀 Deployed to production by https://github.com/arosiclair in version: 9.2.0-5 🚀
|
4 participants
We will revert this PR, but will hold until regression testing is complete so we have a full picture of bugs
Reverts #68692
Fixes: