fix: Long tap on the app icon shows the participant selector even though my workspace is domain controlled by nkdengineer · Pull Request #76477 · Expensify/App

nkdengineer · 2025-12-02T04:02:56Z

Explanation of Change

fix: Long tap on the app icon shows the participant selector even though my workspace is domain controlled

Fixed Issues

$ #76179
PROPOSAL: #76179 (comment)

MOBILE-EXPENSIFY: https://github.com/Expensify/Mobile-Expensify/pull/13859

Tests

As an Admin, go to Domains > [domain] > Domain Members
Search for the submitter and see what Domain Group they are a member of
Go to Groups and set a Preferred workspace for the group and Save
As the submitter, on mobile, long tap the Expensify app icon and select SmartScan
Tap the green button to take a photo
Verify that the user redirects to the confirmation page and the Preferred workspace is displayed as participant

Verify that no errors appear in the JS console

Offline tests

Same

QA Steps

Same as test

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2025-12-02.at.10.57.22.mov

Android: mWeb Chrome

Screen.Recording.2025-12-02.at.10.57.59.mov

iOS: Native

Screen.Recording.2025-12-02.at.10.59.20.mov

iOS: mWeb Safari

Screen.Recording.2025-12-02.at.10.58.36.mov

MacOS: Chrome / Safari

Screen.Recording.2025-12-02.at.10.56.16.mov

…ugh my workspace is domain controlled

codecov · 2025-12-02T04:11:37Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/hooks/useDefaultExpensePolicy.tsx	`40.00% <100.00%> (+6.66%)`	⬆️
... and 9 files with indirect coverage changes

melvin-bot · 2025-12-02T04:33:16Z

@suneox Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

github-actions · 2025-12-02T04:35:09Z

Code Review Complete

The code-inline-reviewer agent has completed its review. Please check for any inline comments on the PR for specific feedback and suggestions.

JmillsExpensify

Agree that we should plug this loophole, though I'm going to trigger an adhoc so I can test the long-hold testing steps in the PR. I don't see that tested in the associated screen recordings.

github-actions · 2025-12-02T13:36:44Z

🚧 @JmillsExpensify has triggered a test Expensify/App build. You can view the workflow run here.

nkdengineer · 2025-12-02T13:37:45Z

@JmillsExpensify The app short cut is only available on Hybrid App which I can't access so I only record the normal flow.

suneox · 2025-12-02T13:41:01Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

CleanShot.2026-02-03.at.00.16.13_.mp4

Android: mWeb Chrome

CleanShot.2026-02-03.at.00.44.43_.mp4

iOS: HybridApp

CleanShot.2026-02-03.at.00.02.17_.mp4

iOS: mWeb Safari

CleanShot.2026-02-03.at.00.49.48_.mp4

MacOS: Chrome / Safari

CleanShot.2026-02-03.at.00.45.41_.mp4

github-actions · 2025-12-02T14:11:53Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #76477.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/76477/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/76477/index.html

Web 🕸️
https://76477.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

suneox · 2025-12-03T17:12:33Z

@nkdengineer It looks like we have another condition preventing navigation to the confirmation page when using the app shortcut.

screen-20251203-233843.mp4

We may need to update Mobile-Expensify/app/expensify.js to trigger/mock the full flow for quick action in dev mode so we can properly verify this issue.

nkdengineer · 2025-12-08T08:29:36Z

@suneox Can you build hybridapp locally and test the full flow to see if it's reproducible.

nkdengineer · 2025-12-12T07:31:51Z

@suneox Friendly bump.

suneox · 2025-12-12T16:06:06Z

@suneox Can you build hybridapp locally and test the full flow to see if it's reproducible.

@nkdengineer You can use the deeplink new-expensify://create/submit/start/1/123456789/scan to open the standalone app to resolve this issue, and I’ll double-check the hybrid app tomorrow with the fixed code.

nkdengineer · 2025-12-15T08:56:18Z

@suneox create/submit/start/1/123456789/scan if here is the correct link of the deeplink on HybridApp, we need to update this to create/create/start/1/123456789/scan because the default expense logic is only triggered with the iouType is create.

App/src/pages/iou/request/step/IOURequestStepScan/index.native.tsx

Lines 480 to 500 in e0923e0

    
           if ( 
        
               iouType === CONST.IOU.TYPE.CREATE && 
        
               isPaidGroupPolicy(defaultExpensePolicy) && 
        
               defaultExpensePolicy?.isPolicyExpenseChatEnabled && 
        
               !shouldRestrictUserBillableActions(defaultExpensePolicy.id) 
        
           ) { 
        
               const activePolicyExpenseChat = getPolicyExpenseChat(currentUserPersonalDetails.accountID, defaultExpensePolicy?.id); 
        
               const shouldAutoReport = !!defaultExpensePolicy?.autoReporting || !!personalPolicy?.autoReporting; 
        
               const transactionReportID = shouldAutoReport ? activePolicyExpenseChat?.reportID : CONST.REPORT.UNREPORTED_REPORT_ID; 
        
               // If the initial transaction has different participants selected that means that the user has changed the participant in the confirmation step 
        
               if (initialTransaction?.participants && initialTransaction?.participants?.at(0)?.reportID !== activePolicyExpenseChat?.reportID) { 
        
                   const isTrackExpense = initialTransaction?.participants?.at(0)?.reportID === selfDMReportID; 
        
                   const setParticipantsPromises = files.map((receiptFile) => setMoneyRequestParticipants(receiptFile.transactionID, initialTransaction?.participants)); 
        
                   Promise.all(setParticipantsPromises).then(() => { 
        
                       if (isTrackExpense) { 
        
                           Navigation.navigate(ROUTES.MONEY_REQUEST_STEP_CONFIRMATION.getRoute(CONST.IOU.ACTION.CREATE, CONST.IOU.TYPE.TRACK, initialTransactionID, selfDMReportID)); 
        
                       } else { 
        
                           navigateToConfirmationPage(iouType === CONST.IOU.TYPE.CREATE, initialTransaction?.reportID); 
        
                       }

suneox · 2025-12-17T17:35:56Z

@suneox create/submit/start/1/123456789/scan if here is the correct link of the deeplink on HybridApp, we need to update this to create/create/start/1/123456789/scan because the default expense logic is only triggered with the iouType is create.

@nkdengineer I'd like confirmed this change works after updating the deeplink on the HybridApp to create.

CleanShot.2025-12-18.at.00.19.02__2.mp4

nkdengineer · 2025-12-22T12:17:53Z

@suneox Can you please raise the Hybrid App PR?

suneox · 2025-12-23T02:25:32Z

@suneox Can you please raise the Hybrid App PR?

Sure, I'll create PR today

suneox · 2025-12-24T16:26:26Z

@nkdengineer Please update the PR description to support triggering an ad-hoc hybrid app build from a specific Mobile-Expensify PR.

$ https://github.com/Expensify/App/issues/76179
PROPOSAL: https://github.com/Expensify/App/issues/76179#issuecomment-3587988437

+MOBILE-EXPENSIFY: https://github.com/Expensify/Mobile-Expensify/pull/13812

nkdengineer · 2025-12-24T16:28:34Z

@suneox Updated.

suneox · 2025-12-24T17:08:08Z

@luacmartins Currently, there is another condition blocking the use of the default policy in the Smart Scan flow. Currently, the Smart Scan deeplink navigates to submit instead of create, which makes the flow inconsistent with the floating camera action on NewDot. I’ve created this PR for the Hybrid App to make the flow consistent (Scan → Confirm). With the current submit action, users are taken to participant selection instead. Could you please help review this PR when you have a chance? Thanks!

suneox · 2025-12-29T15:43:16Z

@luacmartins I mentioned this incorrectly earlier. Could you please take a look at this comment and help trigger an adHoc build for this one?

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b8d0c2a9aa

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

src/pages/iou/request/step/IOURequestStepAmount.tsx

src/pages/iou/request/step/IOURequestStepDistanceManual.tsx

src/pages/iou/request/step/IOURequestStepDistanceGPS/index.native.tsx

luacmartins · 2026-02-11T19:18:02Z

@nkdengineer bump on the comments above

luacmartins · 2026-02-12T23:33:04Z

@nkdengineer bump

luacmartins · 2026-02-17T18:52:14Z

We still have conflicts

suneox · 2026-02-20T05:14:36Z

@nkdengineer Please update the PR description to support triggering an ad-hoc hybrid app build from a specific Mobile-Expensify PR.
$ https://github.com/Expensify/App/issues/76179
PROPOSAL: https://github.com/Expensify/App/issues/76179#issuecomment-3587988437

+MOBILE-EXPENSIFY: https://github.com/Expensify/Mobile-Expensify/pull/13812

@nkdengineer Here is the new Hybrid PR https://github.com/Expensify/Mobile-Expensify/pull/13859

luacmartins · 2026-02-20T18:20:45Z

@suneox Mobile PR merged

suneox · 2026-02-21T07:52:16Z

@nkdengineer The Hybrid PR is merged. We're now waiting to sync with the latest main and clean up the deep-link condition check

nkdengineer · 2026-02-22T13:25:27Z

@suneox I updated.

src/hooks/useDefaultExpensePolicy.tsx

luacmartins

LGTM

luacmartins · 2026-02-23T15:46:59Z

@nkdengineer conflicts

nkdengineer · 2026-02-23T15:50:21Z

@luacmartins I run prettier locally and the file change isn't related.

luacmartins · 2026-02-23T17:19:43Z

@nkdengineer can you merge main? I think it was fixed on main

nkdengineer · 2026-02-23T17:27:23Z

@luacmartins It's fixed now.

OSBotify · 2026-02-23T18:40:31Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-02-23T18:51:23Z

🚧 @luacmartins has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-02-23T18:55:31Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #76477.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-95aeacd-93b4c87-7a64e4faddd849f2c5b3d368743f422110fe4dbd/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-95aeacd-93b4c87-96f1f7ab64ec3d8294cf7f5550036802d7e19f30/index.html

Web 🕸️
https://76477.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-02-24T01:16:19Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 9.3.25-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	cancelled 🔪

isagoico · 2026-02-24T15:56:57Z

Our tester was logged in as applausetester@applause.expensifail.com in OD to invite a member applausetester+laprill@applause.expensifail.com in a group following the PR steps. Here's the video (it's a bit long because of the long loading times):

ND.PR.76477.-.fail.mp4

fix: Long tap on the app icon shows the participant selector even tho…

19e306e

…ugh my workspace is domain controlled

melvin-bot bot assigned nkdengineer Dec 2, 2025

nkdengineer marked this pull request as ready for review December 2, 2025 04:33

nkdengineer requested review from a team as code owners December 2, 2025 04:33

melvin-bot bot requested review from JmillsExpensify and suneox and removed request for a team December 2, 2025 04:33

melvin-bot bot removed the request for review from a team December 2, 2025 04:33

JmillsExpensify reviewed Dec 2, 2025

View reviewed changes

This comment has been minimized.

Sign in to view

chatgpt-codex-connector bot reviewed Feb 10, 2026

View reviewed changes

src/pages/iou/request/step/IOURequestStepAmount.tsx Outdated Show resolved Hide resolved

src/pages/iou/request/step/IOURequestStepDistanceManual.tsx Outdated Show resolved Hide resolved

src/pages/iou/request/step/IOURequestStepDistanceGPS/index.native.tsx Outdated Show resolved Hide resolved

Merge branch 'main' into fix/76179

c2652a7

nkdengineer force-pushed the fix/76179 branch from b8d0c2a to c2652a7 Compare February 22, 2026 13:24

suneox reviewed Feb 23, 2026

View reviewed changes

src/hooks/useDefaultExpensePolicy.tsx Outdated Show resolved Hide resolved

nkdengineer added 2 commits February 23, 2026 11:25

Merge branch 'main' into fix/76179

e9d0fc7

update AI suggestion

c0f0b9c

suneox approved these changes Feb 23, 2026

View reviewed changes

luacmartins previously approved these changes Feb 23, 2026

View reviewed changes

resolve conflict

94ba140

nkdengineer dismissed luacmartins’s stale review via 94ba140 February 23, 2026 15:48

Merge branch 'main' into fix/76179

3fe8317

luacmartins approved these changes Feb 23, 2026

View reviewed changes

luacmartins merged commit 95aeacd into Expensify:main Feb 23, 2026
29 checks passed

OSBotify mentioned this pull request Feb 23, 2026

Deploy Checklist: New Expensify 2026-02-23 #83247

Open

Comments

Conversation

nkdengineer commented Dec 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov bot commented Dec 2, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot bot commented Dec 2, 2025

Uh oh!

github-actions bot commented Dec 2, 2025

Code Review Complete

Uh oh!

JmillsExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

github-actions bot commented Dec 2, 2025

Uh oh!

nkdengineer commented Dec 2, 2025

Uh oh!

suneox commented Dec 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

github-actions bot commented Dec 2, 2025

Uh oh!

suneox commented Dec 3, 2025

Uh oh!

nkdengineer commented Dec 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nkdengineer commented Dec 12, 2025

Uh oh!

suneox commented Dec 12, 2025

Uh oh!

nkdengineer commented Dec 15, 2025

Uh oh!

suneox commented Dec 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nkdengineer commented Dec 22, 2025

Uh oh!

suneox commented Dec 23, 2025

Uh oh!

suneox commented Dec 24, 2025

Uh oh!

nkdengineer commented Dec 24, 2025

Uh oh!

suneox commented Dec 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

suneox commented Dec 29, 2025

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

luacmartins commented Feb 11, 2026

Uh oh!

luacmartins commented Feb 12, 2026

Uh oh!

luacmartins commented Feb 17, 2026

Uh oh!

suneox commented Feb 20, 2026

Uh oh!

luacmartins commented Feb 20, 2026

Uh oh!

nkdengineer commented Dec 2, 2025 •

edited

Loading

codecov bot commented Dec 2, 2025 •

edited by github-actions bot

Loading

suneox commented Dec 2, 2025 •

edited

Loading

nkdengineer commented Dec 8, 2025 •

edited

Loading

suneox commented Dec 17, 2025 •

edited

Loading

suneox commented Dec 24, 2025 •

edited

Loading

nkdengineer commented Feb 23, 2026 •

edited

Loading