Skip to content

Conversation

@aldo-expensify
Copy link
Contributor

@aldo-expensify aldo-expensify commented Jan 6, 2026

Reverts #76688

Fixes: #78931

@aldo-expensify aldo-expensify requested review from a team as code owners January 6, 2026 19:29
@melvin-bot melvin-bot bot requested review from cristipaval and joekaufmanexpensify and removed request for a team January 6, 2026 19:30
@melvin-bot
Copy link

melvin-bot bot commented Jan 6, 2026

@cristipaval Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@codecov
Copy link

codecov bot commented Jan 6, 2026

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
src/libs/ReportUtils.ts 73.09% <50.00%> (-0.05%) ⬇️
... and 12 files with indirect coverage changes

@aldo-expensify aldo-expensify merged commit f3fef7b into main Jan 6, 2026
31 of 35 checks passed
@aldo-expensify aldo-expensify deleted the revert-76688-fix-Allow-approvers-to-edit-expenses-on-draft-open-reports branch January 6, 2026 20:00
@melvin-bot
Copy link

melvin-bot bot commented Jan 6, 2026

@aldo-expensify looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@melvin-bot melvin-bot bot added the Emergency label Jan 6, 2026
OSBotify pushed a commit that referenced this pull request Jan 6, 2026
…vers-to-edit-expenses-on-draft-open-reports

Revert "feat: Allow approvers to edit expenses on draft open reports"

(cherry picked from commit f3fef7b)

(cherry-picked to staging by arosiclair)
@OSBotify OSBotify added the CP Staging marks PRs that have been CP'd to staging label Jan 6, 2026
@OSBotify
Copy link
Contributor

OSBotify commented Jan 6, 2026

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

OSBotify commented Jan 6, 2026

🚀 Cherry-picked to staging by https://github.com/arosiclair in version: 9.2.94-3 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@aldo-expensify
Copy link
Contributor Author

Emergency label: removed because this is a straight revert

@mountiny mountiny changed the title Revert "feat: Allow approvers to edit expenses on draft open reports" [CP Staging] Revert "feat: Allow approvers to edit expenses on draft open reports" Jan 7, 2026
@OSBotify
Copy link
Contributor

OSBotify commented Jan 7, 2026

🚀 Deployed to production by https://github.com/arosiclair in version: 9.2.94-4 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Jan 7, 2026

🚀 Cherry-picked to staging by https://github.com/arosiclair in version: 9.2.95-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Jan 8, 2026

🚀 Deployed to production by https://github.com/arosiclair in version: 9.2.95-5 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CP Staging marks PRs that have been CP'd to staging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Expense - Error shows up when non-admin approver changes member's report workspace

4 participants