Skip to content

Comments

[Policy Change Logs] Implement policy change log for: Taxes - set/change default tax rates, change custom tax name#79161

Merged
madmax330 merged 16 commits intoExpensify:mainfrom
rayane-d:policy-tax-settings-changelogs-2
Feb 23, 2026
Merged

[Policy Change Logs] Implement policy change log for: Taxes - set/change default tax rates, change custom tax name#79161
madmax330 merged 16 commits intoExpensify:mainfrom
rayane-d:policy-tax-settings-changelogs-2

Conversation

@rayane-d
Copy link
Contributor

@rayane-d rayane-d commented Jan 8, 2026

Explanation of Change

Second attempt after issue #78804
Explanation: https://github.com/Expensify/Expensify/issues/568318#issuecomment-3726325964

PR:

Cleanup issue:

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/568318
PROPOSAL: N/A

Tests

Prerequisites

  • A workspace
  • Admin access to the workspace
  • Go to workspace settings
  • Make any change that generates a changelog (e.g., rename the workspace) twice to ensure the system messages thread exists
  • Go to the workspace #admins room
  • Verify that a system messages thread is created

Test Steps 1

  1. Open the App
  2. Navigate to workspace > More features > Enable Taxes
  3. Go to Taxes > Setting. Don't make any change
  4. Navigate to the #admins room

Expected Result:

  • Only one change log should be created: enabled tax tracking
  • The following change logs with empty previous values should NOT be created:
    - changed the custom tax name to "Tax" (previously "")
    - changed the workspace currency default tax rate to "Tax exempt" (previously "")
    - changed the foreign currency default tax rate to "Tax exempt" (previously "")
Screenshot 2026-02-10 at 8 16 06 PM
Screen.Recording.2026-02-10.at.8.09.08.PM.mov

Test Steps 2

Steps:

  1. Navigate to Settings > Workspaces > [Your Workspace] > More features
  2. Enable Taxes
  3. Navigate to Settings > Workspaces > [Your Workspace] > Taxes
  4. Click on the Settings button in the top right
  5. Click on the Custom tax name field
  6. Change the custom name
  7. Save it
  8. Navigate to the #admins room
  9. Open the system messages thread

Expected Results:

  • A changelog entry appears in the system messages thread in the #admins room
  • Message format: changed the custom tax name to "Taxes" (previously "Tax")
  • The format matches: changed the custom tax name to "<NewValue>" (previously "<OldValue>")
  • The LHN sidebar preview shows the correct changelog message text
  • Right-click on the changelog entry, copy the message, and verify that the copied text matches the displayed message exactly
  • Change app language, and verify that the changelog message is translated as expected
  • Create a thread under the changelog comment, and verify that the thread report title displays the changelog message correctly
Screen.Recording.2026-02-10.at.8.11.19.PM.mov
Screenshot 2026-02-10 at 8 16 27 PM

Test Steps 3

  1. Navigate to Settings > Workspaces > [Your Workspace] > Taxes
  2. Add some tax rates
  3. Click on the Settings button in the top right
  4. Click on the Workspace currency default field
  5. Change the default tax
  6. Navigate to the #admins room
  7. Open the system messages thread

Expected Results:

  • A changelog entry appears in the system messages thread in the #admins room
  • Message format: changed the workspace currency default tax rate to "Tax exempt" (previously "Tax Rate 1")
  • The format matches: changed the workspace currency default tax rate to "<NewValue>" (previously "<OldValue>")
  • The LHN sidebar preview shows the correct changelog message text
  • Right-click on the changelog entry, copy the message, and verify that the copied text matches the displayed message exactly
  • Change app language, and verify that the changelog message is translated as expected
  • Create a thread under the changelog comment, and verify that the thread report title displays the changelog message correctly
Screen.Recording.2026-02-10.at.8.14.01.PM.mov
Screenshot 2026-02-10 at 8 16 53 PM

Test Steps 4

  1. Navigate to Settings > Workspaces > [Your Workspace] > Taxes
  2. Click on the Settings button in the top right
  3. Click on the Foreign currency default field
  4. Change the default tax
  5. Navigate to the #admins room
  6. Open the system messages thread

Expected Results:

  • A changelog entry appears in the system messages thread in the #admins room
  • Message format: changed the foreign currency default tax rate to "Tax Rate 1" (previously "Tax exempt")
  • The format matches: changed the foreign currency default tax rate to "<NewValue>" (previously "<OldValue>")
  • The LHN sidebar preview shows the correct changelog message text
  • Right-click on the changelog entry, copy the message, and verify that the copied text matches the displayed message exactly
  • Change app language, and verify that the changelog message is translated as expected
  • Create a thread under the changelog comment, and verify that the thread report title displays the changelog message correctly
Screen.Recording.2026-02-10.at.8.14.27.PM.mov
Screenshot 2026-02-10 at 8 17 10 PM
  • Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Same as tests

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

@melvin-bot
Copy link

melvin-bot bot commented Jan 8, 2026

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

  1. Look at the code and make sure there are no malicious changes.
  2. Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

@codecov
Copy link

codecov bot commented Jan 8, 2026

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
src/CONST/index.ts 87.39% <ø> (ø)
src/libs/ReportNameUtils.ts 80.56% <100.00%> (+0.62%) ⬆️
src/libs/SidebarUtils.ts 78.23% <100.00%> (+0.23%) ⬆️
src/pages/inbox/report/PureReportActionItem.tsx 53.82% <100.00%> (+0.33%) ⬆️
src/libs/OptionsListUtils/index.ts 81.02% <90.90%> (+0.08%) ⬆️
src/libs/ReportActionsUtils.ts 51.10% <80.00%> (+0.60%) ⬆️
...es/inbox/report/ContextMenu/ContextMenuActions.tsx 0.66% <0.00%> (-0.01%) ⬇️
... and 32 files with indirect coverage changes

@rayane-d rayane-d changed the title [Policy Change Logs] Implement policy change log for: Taxes - set/change default tax rates, change custom tax name [Hold https://github.com/Expensify/Expensify/issues/568318#issuecomment-3726325964] [Policy Change Logs] Implement policy change log for: Taxes - set/change default tax rates, change custom tax name Jan 9, 2026
@rayane-d rayane-d changed the title [Hold https://github.com/Expensify/Expensify/issues/568318#issuecomment-3726325964] [Policy Change Logs] Implement policy change log for: Taxes - set/change default tax rates, change custom tax name [Hold https://github.com/Expensify/Expensify/issues/588218] [Policy Change Logs] Implement policy change log for: Taxes - set/change default tax rates, change custom tax name Jan 14, 2026
@rayane-d
Copy link
Contributor Author

rayane-d commented Feb 5, 2026

@rayane-d rayane-d changed the title [Hold https://github.com/Expensify/Expensify/issues/588218] [Policy Change Logs] Implement policy change log for: Taxes - set/change default tax rates, change custom tax name [Policy Change Logs] Implement policy change log for: Taxes - set/change default tax rates, change custom tax name Feb 10, 2026
@rayane-d rayane-d marked this pull request as ready for review February 10, 2026 19:18
@rayane-d rayane-d requested review from a team as code owners February 10, 2026 19:18
@melvin-bot melvin-bot bot requested review from JmillsExpensify and MariaHCD and removed request for a team February 10, 2026 19:18
@melvin-bot
Copy link

melvin-bot bot commented Feb 10, 2026

@MariaHCD Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot removed the request for review from a team February 10, 2026 19:18
@rayane-d rayane-d requested review from a team and removed request for MariaHCD February 10, 2026 19:19
@melvin-bot melvin-bot bot requested review from Ollyws and removed request for a team February 10, 2026 19:19
Copy link
Contributor

@JmillsExpensify JmillsExpensify left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a product approved change.

@MariaHCD
Copy link
Contributor

MariaHCD commented Feb 16, 2026

Please ping me when this is ready for a review from me :) Or are we expecting a different internal engineer to review this?

@rayane-d
Copy link
Contributor Author

Small nitpick but changed the default tax for foreign currency to "Tax Rate 1" (previously "Tax exempt") in the testing steps doesn't match the actual message, we don't want to confuse the QA team.

Updated 👍

@Ollyws
Copy link
Contributor

Ollyws commented Feb 17, 2026

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp Android_Native
Android: mWeb Chrome Android_Chrome
iOS: HybridApp iOS_Native
iOS: mWeb Safari iOS_Safari
MacOS: Chrome / Safari MacOS_Chrome

Copy link
Contributor

@Ollyws Ollyws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@melvin-bot
Copy link

melvin-bot bot commented Feb 17, 2026

🎯 @Ollyws, thanks for reviewing and testing this PR! 🎉

An E/App issue has been created to issue payment here: #82685.

@rayane-d rayane-d requested a review from a team February 20, 2026 17:00
@melvin-bot melvin-bot bot requested review from truph01 and removed request for a team February 20, 2026 17:00
@melvin-bot
Copy link

melvin-bot bot commented Feb 20, 2026

@truph01 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@rayane-d rayane-d requested review from MariaHCD and madmax330 and removed request for truph01 February 20, 2026 17:00
Copy link
Contributor

Looks like we just lack internal engineering review and then we're good to merge this one.

@madmax330 madmax330 merged commit aa40d89 into Expensify:main Feb 23, 2026
30 checks passed
@github-actions
Copy link
Contributor

🚧 @madmax330 has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by https://github.com/madmax330 in version: 9.3.25-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 failure ❌
🍎 iOS 🍎 cancelled 🔪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants