[Policy Change Logs] Implement policy change log for: Taxes - set/change default tax rates, change custom tax name#79161
Conversation
…, change custom tax name
|
Hey, I noticed you changed If you want to automatically generate translations for other locales, an Expensify employee will have to:
Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running: npx ts-node ./scripts/generateTranslations.ts --helpTypically, you'd want to translate only what you changed by running |
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
JmillsExpensify
left a comment
There was a problem hiding this comment.
This is a product approved change.
|
Please ping me when this is ready for a review from me :) Or are we expecting a different internal engineer to review this? |
Updated 👍 |
Reviewer Checklist
Screenshots/Videos |
|
Looks like we just lack internal engineering review and then we're good to merge this one. |
|
🚧 @madmax330 has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/madmax330 in version: 9.3.25-0 🚀
|





Explanation of Change
Second attempt after issue #78804
Explanation: https://github.com/Expensify/Expensify/issues/568318#issuecomment-3726325964
PR:
Cleanup issue:
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/568318
PROPOSAL: N/A
Tests
Prerequisites
Test Steps 1
Expected Result:
enabled tax tracking-
changed the custom tax name to "Tax" (previously "")-
changed the workspace currency default tax rate to "Tax exempt" (previously "")-
changed the foreign currency default tax rate to "Tax exempt" (previously "")Screen.Recording.2026-02-10.at.8.09.08.PM.mov
Test Steps 2
Steps:
Expected Results:
changed the custom tax name to "Taxes" (previously "Tax")changed the custom tax name to "<NewValue>" (previously "<OldValue>")Screen.Recording.2026-02-10.at.8.11.19.PM.mov
Test Steps 3
Expected Results:
changed the workspace currency default tax rate to "Tax exempt" (previously "Tax Rate 1")changed the workspace currency default tax rate to "<NewValue>" (previously "<OldValue>")Screen.Recording.2026-02-10.at.8.14.01.PM.mov
Test Steps 4
Expected Results:
changed the foreign currency default tax rate to "Tax Rate 1" (previously "Tax exempt")changed the foreign currency default tax rate to "<NewValue>" (previously "<OldValue>")Screen.Recording.2026-02-10.at.8.14.27.PM.mov
Offline tests
N/A
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari