-
Notifications
You must be signed in to change notification settings - Fork 3.5k
[No QA] Update Set-Up-SAML-Single-Sign-On.md #79747
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
A preview of your ExpensifyHelp changes have been deployed to https://761bad41.helpdot.pages.dev ⚡️ Updated articles: |
…t-Up-SAML-Single-Sign-On.md
merge main into my branch
This comment was marked as resolved.
This comment was marked as resolved.
|
The spell check fail is a false positive, checking to see if we can just skip it: https://expensify.slack.com/archives/C01GTK53T8Q/p1768962208078609 |
|
@NicMendonca looks like this was merged without a test passing. Please add a note explaining why this was done and remove the |
|
🚀 Deployed to staging by https://github.com/NicMendonca in version: 9.3.6-0 🚀
|
|
🚀 Deployed to production by https://github.com/Beamanator in version: 9.3.6-4 🚀
|
See: https://github.com/Expensify/Expensify/issues/588714
Splitting out SAML setup vs troubleshooting into separate articles.
--
Article incorrectly referrenced the Expensify Card for non-US users
Explanation of Change
Fixed Issues
$
PROPOSAL:
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari