-
Notifications
You must be signed in to change notification settings - Fork 3.5k
[No QA] HelpDot: add New Expensify domain admins doc (Release 1) #79989
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Concierge reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member? |
|
@stephanieelliott One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] NOTE: It looks like |
docs/articles/new-expensify/domains/Claim-and-Verify-a-Domain.md
Outdated
Show resolved
Hide resolved
docs/articles/new-expensify/domains/Claim-and-Verify-a-Domain.md
Outdated
Show resolved
Hide resolved
docs/articles/new-expensify/domains/Claim-and-Verify-a-Domain.md
Outdated
Show resolved
Hide resolved
HelpDot Documentation ReviewOverall AssessmentThis PR successfully creates a new Domains hub for New Expensify and migrates relevant articles from the Workspaces hub. The documentation includes four new articles (Domain Admins, Domain Groups, Domain Members, and Domain Migration) plus two reorganized articles (Claim and Verify a Domain, Set Up SAML SSO). The overall structure is logical, the writing is clear, and the organization improves discoverability of domain-related features. Scores Summary
Key FindingsStrengths:
Areas for Improvement:
RecommendationsPriority Actions:
Suggestions for Enhancement:
Nice-to-haves:
Files Reviewed
Overall Verdict: This is a high-quality documentation update that significantly improves the organization and discoverability of domain-related features. The new articles are well-written and provide clear, actionable guidance. With minor corrections (especially the closing tag), this will be ready to merge. Note: I have also provided detailed inline comments on specific lines for granular feedback. |
docs/articles/new-expensify/domains/Set-Up-SAML-Single-Sign-On.md
Outdated
Show resolved
Hide resolved
This comment was marked as outdated.
This comment was marked as outdated.
|
HOLD this on deploying the functionality. |
|
Hey @twisterdotcom heads up some of this conflicts with this PR: #79747 The New/Domains hub was already created with that PR and the existing articles moved over. So all we need to do here is just move the new articles in I think! |
Create a New Expensify Domains hub with initial domain-control articles, move SAML and domain verification into the hub, and add redirects to preserve existing links.
Improve heading specificity for AI search, reduce parenthetical interruptions, standardize 'member' terminology, and remove unnecessary HTML wrappers in New Expensify domain articles.
Remove duplicate Domains hub entry in routes, drop legacy SAML Single Sign-On article in favor of the new SAML SSO docs, and keep redirects aligned with the current help site structure.
5a4d704 to
aa7dc50
Compare
Keep New Expensify hub ordering as-is in routes.yml.
Trim this PR to Domain Admins + supporting domain verification updates, moving member and group documentation to separate PRs for later releases.
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/577567
Adds New Expensify help docs for Domain Admins, plus minor updates to Claim and Verify a Domain and a redirect to preserve the legacy Workspaces URL.
Tests
Web QA
N/A
Mobile QA
No mobile QA