Skip to content

Conversation

@twisterdotcom
Copy link
Contributor

@twisterdotcom twisterdotcom commented Jan 20, 2026

Fixed Issues
$ https://github.com/Expensify/Expensify/issues/577567

Adds New Expensify help docs for Domain Admins, plus minor updates to Claim and Verify a Domain and a redirect to preserve the legacy Workspaces URL.

Tests

  • N/A (docs-only)

Web QA
N/A

Mobile QA
No mobile QA

@melvin-bot
Copy link

melvin-bot bot commented Jan 20, 2026

Concierge reviewer checklist:

  • I have verified the accuracy of the article
    • The article is within a hub that makes sense, and the navigation is correct
    • All processes, screenshots, and examples align with current product behavior.
    • All links within the doc have been verified for correct destination and functionality.
  • I have verified the readability of the article
    • The article's language is clear, concise, and free of jargon.
    • The grammar, spelling, and punctuation are correct.
    • The article contains at least one image, or that an image is not necessary
  • I have verified the formatting of the article
    • The article has consistent formatting (headings, bullet points, etc.) with other HelpDot articles and that aligns with the HelpDot formatting standards.
    • The article has proper text spacing and breaks for readability.
  • I have verified the article has the appropriate tone and style
    • The article's tone is professional, friendly, and suitable for the target audience.
    • The article's tone, terminology, and voice are consistent throughout.
  • I have verified the overall quality of the article
    • The article is not missing any information, nor does it contain redundant information.
    • The article fully addresses user needs.
  • I have verified that all requested improvements have been addressed

For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member?

cc @stephanieelliott

@melvin-bot melvin-bot bot requested review from MarioExpensify and jliexpensify and removed request for a team January 20, 2026 14:30
@melvin-bot
Copy link

melvin-bot bot commented Jan 20, 2026

@stephanieelliott One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

NOTE: It looks like docs/redirects.csv was modified in this PR. Please see this SO for special instructions on how to review changes to that file.

@github-actions
Copy link
Contributor

HelpDot Documentation Review

Overall Assessment

This PR successfully creates a new Domains hub for New Expensify and migrates relevant articles from the Workspaces hub. The documentation includes four new articles (Domain Admins, Domain Groups, Domain Members, and Domain Migration) plus two reorganized articles (Claim and Verify a Domain, Set Up SAML SSO). The overall structure is logical, the writing is clear, and the organization improves discoverability of domain-related features.

Scores Summary

  • Readability: 8/10 - Writing is clear and well-organized with good use of headings, lists, and formatting. Minor improvements needed in formatting consistency and a few grammatical details.
  • AI Readiness: 9/10 - Excellent use of descriptive YAML metadata including the new internalScope field. Headings are clear and contextual. Strong breadcrumb structure with the new hub.
  • Style Compliance: 8/10 - Generally follows Expensify voice and formatting standards. Uses correct terminology (workspace, member, domain admin). Minor inconsistencies in list formatting and heading hierarchy.

Key Findings

Strengths:

  • The new internalScope metadata field is excellent for AI context and clearly defines what each article covers and doesn't cover
  • Logical hub organization that separates domain control from workspace management
  • Consistent use of step-by-step instructions with numbered lists
  • Good cross-linking between related articles
  • Proper redirects preserve existing links
  • Clear "What this covers / doesn't cover" scoping in metadata

Areas for Improvement:

  1. Formatting inconsistencies:

    • Mixed use of sub-list indicators (some use a., some use -, some use indented -)
    • In Claim-and-Verify-a-Domain.md: Changed from a. to - for sub-items (good), but should verify this matches HelpDot standards
    • Several articles have extraneous blank lines that were cleaned up in moved files but should be consistent
  2. Minor grammatical/style issues:

    • Domain-Groups.md: "Strictly enforce expense workspace rules" uses passive voice in description
    • Domain-Migration.md: Some instructions could be more action-oriented (e.g., "Message Concierge" instead of "contact Concierge")
    • Claim-and-Verify-a-Domain.md: Errant closing </div> tag at end of file (line appears in diff)
  3. Content completeness:

    • Domain-Admins.md FAQ: "typically add" is vague - should clarify when you can vs. cannot
    • Domain-Migration.md: Card feed migration warnings are helpful but could benefit from more specific guidance
    • Missing screenshots/images in all new articles (though text-only may be intentional)
  4. Heading hierarchy:

    • All articles properly use # and ## only (good for AI readability)
    • FAQ sections use ## correctly

Recommendations

Priority Actions:

  1. Remove the errant </div> closing tag at the end of Claim-and-Verify-a-Domain.md
  2. Review sub-list formatting to ensure consistency with HelpDot standards (the change from a. to - should be verified)
  3. Consider adding at least one screenshot per article showing where to find domain settings

Suggestions for Enhancement:

  1. Add visual markers or callouts for the "Important" notes in Domain-Migration.md to make warnings more prominent
  2. In Domain-Admins.md FAQ, replace "typically" with specific requirements for when admins can be added
  3. Consider adding a "Common use cases" section to Domain-Groups.md since the permissions explanations are at the end
  4. Review Domain-Members.md for opportunities to add screenshots of the member management UI

Nice-to-haves:

  1. Add cross-references between Domain Groups and Domain Members articles
  2. Consider a quick reference table in Domain-Groups.md showing all permissions at a glance
  3. Add troubleshooting sections to Domain-Members.md and Domain-Admins.md

Files Reviewed

  • _routes.yml: Clean addition of Domains hub with appropriate description
  • Claim-and-Verify-a-Domain.md: Good cleanup and metadata addition; remove errant closing tag
  • Domain-Admins.md: Clear structure; clarify "typically" in FAQ
  • Domain-Groups.md: Comprehensive coverage of permissions; well-organized
  • Domain-Members.md: Thorough member management guide; good distinction between members and admins
  • Domain-Migration.md: Helpful migration guidance; appropriate warnings about card feeds
  • Set-Up-SAML-Single-Sign-On.md: Good cleanup removing extra whitespace; proper link updates
  • index.html: Standard hub template (appropriate)
  • redirects.csv: Properly preserves old URLs

Overall Verdict: This is a high-quality documentation update that significantly improves the organization and discoverability of domain-related features. The new articles are well-written and provide clear, actionable guidance. With minor corrections (especially the closing tag), this will be ready to merge.

Note: I have also provided detailed inline comments on specific lines for granular feedback.

@github-actions github-actions bot changed the title HelpDot: add New Expensify Domains hub [No QA] HelpDot: add New Expensify Domains hub Jan 20, 2026
@OSBotify

This comment was marked as outdated.

@twisterdotcom twisterdotcom changed the title [No QA] HelpDot: add New Expensify Domains hub [No QA] [HOLD] HelpDot: add New Expensify Domains hub Jan 20, 2026
@twisterdotcom
Copy link
Contributor Author

HOLD this on deploying the functionality.

@stephanieelliott
Copy link
Contributor

Hey @twisterdotcom heads up some of this conflicts with this PR: #79747

The New/Domains hub was already created with that PR and the existing articles moved over. So all we need to do here is just move the new articles in I think!

Create a New Expensify Domains hub with initial domain-control articles, move SAML and domain verification into the hub, and add redirects to preserve existing links.
Improve heading specificity for AI search, reduce parenthetical interruptions, standardize 'member' terminology, and remove unnecessary HTML wrappers in New Expensify domain articles.
Remove duplicate Domains hub entry in routes, drop legacy SAML Single Sign-On article in favor of the new SAML SSO docs, and keep redirects aligned with the current help site structure.
@twisterdotcom twisterdotcom force-pushed the helpdot/newdot-domains-hub branch from 5a4d704 to aa7dc50 Compare January 22, 2026 21:33
Keep New Expensify hub ordering as-is in routes.yml.
Trim this PR to Domain Admins + supporting domain verification updates, moving member and group documentation to separate PRs for later releases.
@twisterdotcom twisterdotcom changed the title [No QA] [HOLD] HelpDot: add New Expensify Domains hub HelpDot: add New Expensify domain admins doc Jan 22, 2026
@github-actions github-actions bot changed the title HelpDot: add New Expensify domain admins doc [No QA] HelpDot: add New Expensify domain admins doc Jan 22, 2026
@twisterdotcom twisterdotcom changed the title [No QA] HelpDot: add New Expensify domain admins doc [No QA] HelpDot: add New Expensify domain admins doc (Release 1) Jan 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants