Skip to content

Feat: Add 'Move to report' in the 'More' menu of a one-expense report#85038

Merged
aldo-expensify merged 14 commits intoExpensify:mainfrom
nyomanjyotisa:issue-83884-2
Mar 17, 2026
Merged

Feat: Add 'Move to report' in the 'More' menu of a one-expense report#85038
aldo-expensify merged 14 commits intoExpensify:mainfrom
nyomanjyotisa:issue-83884-2

Conversation

@nyomanjyotisa
Copy link
Member

@nyomanjyotisa nyomanjyotisa commented Mar 12, 2026 •
edited
Loading

Explanation of Change

Add "Move to report" in the secondary actions when there's exactly one transaction that can be moved

Fixed Issues

$ #83884
$ #84974
$ #84976
$ #85012
$ #85014
PROPOSAL: #83884 (comment)

Tests

Same as QA Steps

  • Verify that no errors appear in the JS console

Offline tests

Same as QA Steps

QA Steps

  1. Create an expense in a workspace
  2. Open the expense
  3. Click on "More"
  4. Verify that the "Move to report" option is displayed
  5. Click on the "Move to report" option
  6. Move the expense to another report
  7. Verify that the operation was successful
  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android-Native.mp4
Android: mWeb Chrome
Android-mWeb.Chrome.mp4
iOS: Native
iOS-Native.mp4
iOS: mWeb Safari
iOS-mWeb.Safari.mp4
MacOS: Chrome / Safari
MacOS-Chrome.mp4

@codecov
Copy link

codecov bot commented Mar 12, 2026 •
edited by github-actions bot
Loading

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
src/CONST/index.ts 93.54% <ø> (ø)
src/libs/ReportSecondaryActionUtils.ts 92.65% <100.00%> (+0.22%) ⬆️
src/libs/ReportUtils.ts 77.26% <100.00%> (+0.04%) ⬆️
...rc/pages/iou/request/step/IOURequestEditReport.tsx 0.00% <ø> (ø)
...es/iou/request/step/IOURequestEditReportCommon.tsx 88.40% <100.00%> (ø)
src/components/MoneyRequestHeader.tsx 0.00% <0.00%> (ø)
src/components/MoneyReportHeader.tsx 0.00% <0.00%> (ø)
... and 56 files with indirect coverage changes

@ZhenjaHorbach
Copy link
Contributor

ZhenjaHorbach commented Mar 13, 2026

Oh
It's good that you've started fixing the regressions!

@nyomanjyotisa
Copy link
Member Author

nyomanjyotisa commented Mar 13, 2026

Yeah, I've also re-tested this on all platforms

@nyomanjyotisa nyomanjyotisa marked this pull request as ready for review March 13, 2026 16:18
@nyomanjyotisa nyomanjyotisa requested review from a team as code owners March 13, 2026 16:18
@melvin-bot melvin-bot bot requested review from JmillsExpensify and ZhenjaHorbach and removed request for a team March 13, 2026 16:18
@melvin-bot
Copy link

melvin-bot bot commented Mar 13, 2026

@ZhenjaHorbach Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot removed the request for review from a team March 13, 2026 16:18
chatgpt-codex-connector[bot]
chatgpt-codex-connector bot reviewed Mar 13, 2026
View reviewed changes
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 01c49c0de2

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

src/components/MoneyReportHeader.tsx Outdated
if (!transactionToMove?.transactionID) {
return;
}
const iouType = isExpenseReport(moneyRequestReport) ? CONST.IOU.TYPE.SUBMIT : CONST.IOU.TYPE.REQUEST;
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot Mar 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Use a supported IOU type for move-to-report navigation

This handler passes CONST.IOU.TYPE.REQUEST for non-expense reports, but the edit-report screen rejects request routes (src/pages/iou/request/step/withWritableReportOrNotFound.tsx filters out REQUEST iouType), so “Move to report” can send users to Not Found instead of the report picker when invoked from non-expense one-transaction reports (for example invoice reports where this action is still allowed by canEditFieldOfMoneyRequest).

Useful? React with 👍 / 👎.

JmillsExpensify
JmillsExpensify approved these changes Mar 16, 2026
View reviewed changes
Copy link
Contributor

@JmillsExpensify JmillsExpensify left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The wording is a little odd for this case, though discussed in Slack and we decided to move forward with this, so approving.

@ZhenjaHorbach
Copy link
Contributor

ZhenjaHorbach commented Mar 16, 2026 •
edited
Loading

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
2026-03-10.12.45.13.mov
Android: mWeb Chrome
2026-03-10.12.42.52.mov
iOS: HybridApp
2026-03-10.12.45.13.mov
2026-03-16.16.17.47.mov
2026-03-16.16.19.06.mov
2026-03-16.16.20.47.mov
2026-03-16.16.26.35.mov
iOS: mWeb Safari
2026-03-10.12.42.52.mov
2026-03-16.16.17.47.mov
2026-03-16.16.19.06.mov
2026-03-16.16.20.47.mov
2026-03-16.16.26.35.mov
MacOS: Chrome / Safari
2026-03-10.12.37.51.mov
2026-03-16.15.52.55.mov
2026-03-16.15.54.35.mov
2026-03-16.15.58.15.mov
2026-03-16.16.02.40.mov

@ZhenjaHorbach
Copy link
Contributor

ZhenjaHorbach commented Mar 16, 2026

LGTM!

@ZhenjaHorbach
Copy link
Contributor

ZhenjaHorbach commented Mar 16, 2026

Jest issues are not related to this PR

@melvin-bot melvin-bot bot requested a review from aldo-expensify March 16, 2026 15:28
@aldo-expensify aldo-expensify merged commit deb3519 into Expensify:main Mar 17, 2026
39 of 40 checks passed
@github-actions
Copy link
Contributor

github-actions bot commented Mar 17, 2026

🚧 @aldo-expensify has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 17, 2026

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #85038.

Android 🤖 iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-deb3519-03346cd-6e767c9c7e5e45305f3fabe687886df6dead7db1/index.html https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-deb3519-03346cd-17cb72b46ff698009f95e6deec623d99527dd40a/index.html
Android iOS
Web 🕸️
https://85038.pr-testing.expensify.com
Web

👀 View the workflow run that generated this build 👀

@github-actions github-actions bot mentioned this pull request Mar 17, 2026
Closed
@OSBotify OSBotify mentioned this pull request Mar 17, 2026
Closed
75 tasks
@OSBotify
Copy link
Contributor

OSBotify commented Mar 17, 2026

🚀 Deployed to staging by https://github.com/aldo-expensify in version: 9.3.39-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@jponikarchuk jponikarchuk mentioned this pull request Mar 17, 2026
Open
7 tasks
@jponikarchuk
Copy link

jponikarchuk commented Mar 17, 2026

Deploy Blocker #85537 was identified to be related to this PR.

@OSBotify
Copy link
Contributor

OSBotify commented Mar 17, 2026

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@MelvinBot MelvinBot mentioned this pull request Mar 18, 2026
Closed
52 tasks
@OSBotify
Copy link
Contributor

OSBotify commented Mar 18, 2026

🚀 Deployed to production by https://github.com/cristipaval in version: 9.3.39-3 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 failure ❌
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chatgpt-codex-connector chatgpt-codex-connector[bot] chatgpt-codex-connector[bot] left review comments

@JmillsExpensify JmillsExpensify JmillsExpensify approved these changes

@aldo-expensify aldo-expensify Awaiting requested review from aldo-expensify

+1 more reviewer

@ZhenjaHorbach ZhenjaHorbach ZhenjaHorbach approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@nyomanjyotisa nyomanjyotisa

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@nyomanjyotisa @ZhenjaHorbach @OSBotify @jponikarchuk @JmillsExpensify @aldo-expensify