fix: No error modal when sending a specific attachment via the receipt button by nkdengineer · Pull Request #86189 · Expensify/App

nkdengineer · 2026-03-24T10:44:14Z

Explanation of Change

fix: No error modal when sending a specific attachment via the receipt button

Fixed Issues

$ #85951
PROPOSAL: #85951 (comment)

Tests

Open a workspace chat.
Create an expense with a receipt.
Open the created expense.
Hover over the receipt.
Click the Add button.
Upload an attachment larger than 25 MB.
Verify that an error modal appears

Verify that no errors appear in the JS console

Offline tests

QA Steps

Same as test

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2026-03-24.at.17.35.15.mov

Android: mWeb Chrome

Screen.Recording.2026-03-24.at.17.13.36.mov

iOS: Native

Screen.Recording.2026-03-24.at.17.40.06.mov

iOS: mWeb Safari

Screen.Recording.2026-03-24.at.17.43.43.mov

MacOS: Chrome / Safari

Screen.Recording.2026-03-24.at.17.09.20.mov

…t button

nkdengineer · 2026-03-24T10:47:11Z

@dukenv0307 @dangrous I notice that the native behavior is different from web behavior.

On native, the file is auto-resized on the pick step after this PR, then it's showing a dimension error with the image in the OP
While on the web, all validation logic is handled in the hook, which will show the limit error modal for the normal upload attachment.

Let me know if we want to change any behavior.

codecov · 2026-03-24T11:04:34Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
...nents/ReportActionItem/MoneyRequestReceiptView.tsx	`70.07% <ø> (ø)`
src/libs/validateAttachmentFile.ts	`94.59% <100.00%> (-0.15%)`	⬇️
src/hooks/useFilesValidation.tsx	`25.71% <50.00%> (ø)`
src/components/AttachmentPicker/index.native.tsx	`20.95% <0.00%> (-0.60%)`	⬇️
... and 396 files with indirect coverage changes

melvin-bot · 2026-03-24T13:32:57Z

@dukenv0307 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

dukenv0307 · 2026-03-24T15:25:02Z

Oh, I think we should do the same as on the native, we should resize first then do the validation cc @dangrous

dangrous · 2026-03-24T19:40:15Z

that makes sense to me!

nkdengineer · 2026-04-01T03:19:34Z

@dukenv0307 After checking, I think we should remove the resize logic in native and update useFilesValidation to apply the resize logic for the normal attachment by removing validationState.isValidatingReceipts condition here.

It's a better approach because useFilesValidation handles the error modal to display for both web and native platforms. If we handle the resize logic for the web in the picker component, we need to build the error modal again in this component, which is unnecessary.

App/src/hooks/useFilesValidation.tsx

Line 169 in 0a42bcf

    
           if (result.error === CONST.FILE_VALIDATION_ERRORS.FILE_TOO_LARGE && isImageFile(file) && validationState.isValidatingReceipts) {

dukenv0307 · 2026-04-01T11:13:38Z

@nkdengineer how do you handle the resize logic in useFilesValidation? can we preserve the current behavior: resize -> validate? BTW, useFilesValidation is used in many places, is it safe to change it?

nkdengineer · 2026-04-03T04:09:50Z

how do you handle the resize logic in useFilesValidation? can we preserve the current behavior: resize -> validate?

@dukenv0307 We have the logic to handle the resize logic here in the useFilesValidation hook when the file is too large.

App/src/hooks/useFilesValidation.tsx

Lines 169 to 173 in 3900414

    
           if (result.error === CONST.FILE_VALIDATION_ERRORS.FILE_TOO_LARGE && isImageFile(file) && validationState.isValidatingReceipts) { 
        
               filesToResize.push(file); 
        
               return; 
        
           }

And this logic is the same as what we did here

App/src/hooks/useFilesValidation.tsx

Lines 235 to 349 in 3900414

    
               if (filesToResize.length > 0) { 
        
                   setIsLoaderVisible(true); 
        
                   const toResizeResults = await Promise.allSettled(filesToResize.map((file) => resizeImageIfNeeded(file))); 
        
                   for (const [index, result] of toResizeResults.entries()) { 
        
                       if (result.status === 'fulfilled') { 
        
                           const value = result.value; 
        
                           validNonPdfFiles.push(value); 
        
                           updateFileOrderMapping(filesToResize.at(index), value); 
        
                       } else { 
        
                           const errorMessage = result.reason instanceof Error ? result.reason.message : undefined; 
        
                           if (errorMessage === CONST.FILE_VALIDATION_ERRORS.IMAGE_DIMENSIONS_TOO_LARGE) { 
        
                               collectedErrors.current.push({error: CONST.FILE_VALIDATION_ERRORS.IMAGE_DIMENSIONS_TOO_LARGE, isValidatingMultipleFiles}); 
        
                           } else { 
        
                               collectedErrors.current.push({error: CONST.FILE_VALIDATION_ERRORS.FILE_CORRUPTED, isValidatingMultipleFiles}); 
        
                           } 
        
                       } 
        
                   } 
        
               } 
        
               setIsLoaderVisible(false); 
        
               if (pdfsToLoad.length) { 
        
                   validFiles.current = validNonPdfFiles; 
        
                   setPdfFilesToRender(pdfsToLoad); 
        
                   return; 
        
               } 
        
               if (validNonPdfFiles.length > 0) { 
        
                   setValidFilesToUpload(validNonPdfFiles); 
        
               } 
        
               if (collectedErrors.current.length > 0) { 
        
                   const uniqueErrors = Array.from(new Set(collectedErrors.current.map((error) => JSON.stringify(error)))).map((errorStr) => JSON.parse(errorStr) as FileValidationError); 
        
                   setErrorQueue(uniqueErrors); 
        
                   setCurrentErrorIndex(0); 
        
                   const firstError = uniqueErrors.at(0); 
        
                   if (firstError) { 
        
                       setFileError(firstError); 
        
                       setIsErrorModalVisible(true); 
        
                   } 
        
               } else if (validNonPdfFiles.length > 0) { 
        
                   const sortedFiles = sortFilesByOriginalOrder(validNonPdfFiles, originalFileOrder.current); 
        
                   onFilesValidated(sortedFiles, dataTransferItemList.current); 
        
                   reset(); 
        
               } 
        
           } 
        
           const validateFiles = (files: FileObject[], items?: DataTransferItem[], validationOptions?: ValidationOptions) => { 
        
               if (isValidatingFiles) { 
        
                   Log.warn('Files are already being validated. Please wait for the current validation to complete before calling `validateFiles` again.'); 
        
                   return; 
        
               } 
        
               setIsValidatingFiles(true); 
        
               const validationState: ValidationState = { 
        
                   isValidatingReceipts: validationOptions?.isValidatingReceipts ?? DEFAULT_IS_VALIDATING_RECEIPTS, 
        
                   isValidatingMultipleFiles: files.length > 1, 
        
               }; 
        
               setIsValidatingReceipts(validationState.isValidatingReceipts); 
        
               setIsValidatingMultipleFiles(validationState.isValidatingMultipleFiles); 
        
               if (files.length > CONST.API_ATTACHMENT_VALIDATIONS.MAX_FILE_LIMIT) { 
        
                   filesToValidate.current = files.slice(0, CONST.API_ATTACHMENT_VALIDATIONS.MAX_FILE_LIMIT); 
        
                   if (items) { 
        
                       dataTransferItemList.current = items.slice(0, CONST.API_ATTACHMENT_VALIDATIONS.MAX_FILE_LIMIT); 
        
                   } 
        
                   setErrorAndOpenModal(CONST.FILE_VALIDATION_ERRORS.MAX_FILE_LIMIT_EXCEEDED); 
        
               } else { 
        
                   validateAndResizeFiles(files, items ?? [], validationState); 
        
               } 
        
           }; 
        
           const onConfirmError = () => { 
        
               if (fileError?.error === CONST.FILE_VALIDATION_ERRORS.MAX_FILE_LIMIT_EXCEEDED) { 
        
                   setIsErrorModalVisible(false); 
        
                   const validationState: ValidationState = { 
        
                       isValidatingReceipts: isValidatingReceipts ?? false, 
        
                       isValidatingMultipleFiles, 
        
                   }; 
        
                   validateAndResizeFiles(filesToValidate.current, dataTransferItemList.current, validationState); 
        
                   return; 
        
               } 
        
               if (currentErrorIndex < errorQueue.length - 1) { 
        
                   const nextIndex = currentErrorIndex + 1; 
        
                   const nextError = errorQueue.at(nextIndex); 
        
                   if (nextError) { 
        
                       if (isValidatingMultipleFiles && currentErrorIndex === errorQueue.length - 2 && validFilesToUpload.length === 0) { 
        
                           setIsValidatingMultipleFiles(false); 
        
                       } 
        
                       setCurrentErrorIndex(nextIndex); 
        
                       setFileError(nextError); 
        
                       return; 
        
                   } 
        
               } 
        
               const sortedFiles = sortFilesByOriginalOrder(validFilesToUpload, originalFileOrder.current); 
        
               // If we're validating attachments we need to use InteractionManager to ensure 
        
               // the error modal is dismissed before opening the attachment modal 
        
               if (isValidatingReceipts === false && fileError) { 
        
                   setIsErrorModalVisible(false); 
        
                   // eslint-disable-next-line @typescript-eslint/no-deprecated 
        
                   InteractionManager.runAfterInteractions(() => { 
        
                       if (sortedFiles.length !== 0) { 
        
                           onFilesValidated(sortedFiles, dataTransferItemList.current); 
        
                       } 
        
                       reset(); 
        
                   }); 
        
               } else { 
        
                   if (sortedFiles.length !== 0) { 
        
                       onFilesValidated(sortedFiles, dataTransferItemList.current); 
        
                   }

BTW, useFilesValidation is used in many places, is it safe to change it?

It's safe because we always pick attachments first before going to this hook

dukenv0307 · 2026-04-03T08:10:55Z

Sound good, let's do that

dukenv0307 · 2026-04-07T01:51:54Z

@nkdengineer any updates on this PR?

nkdengineer · 2026-04-07T03:28:13Z

@dukenv0307 I updated.

dukenv0307 · 2026-04-09T02:53:35Z

@codex review

chatgpt-codex-connector · 2026-04-09T03:26:36Z

Codex Review: Something went wrong. Try again later by commenting “@codex review”.

We were unable to download your code in a timely manner.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

dukenv0307 · 2026-04-09T04:03:36Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2026-04-09.at.10.52.22.mov

Android: mWeb Chrome

Screen.Recording.2026-04-09.at.11.01.09.mov

iOS: HybridApp

Screen.Recording.2026-04-09.at.10.30.12.mov

iOS: mWeb Safari

Screen.Recording.2026-04-09.at.11.01.21.mov

MacOS: Chrome / Safari

Screen.Recording.2026-04-09.at.10.59.16.mov

github-actions · 2026-04-09T15:14:24Z

🚧 @dangrous has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-04-09T15:19:14Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #86189.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-7c46a54-b0990c7-6d19a789025720ce9b279fd461cca7e90674add1/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-7c46a54-b0990c7-7769e75afc832ceb494d147f4334bb187b08273c/index.html

Web 🕸️
https://86189.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-04-09T15:23:47Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-04-10T08:25:10Z

🚀 Deployed to staging by https://github.com/dangrous in version: 9.3.58-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

MelvinBot · 2026-04-10T08:27:24Z

No help site changes required.

This PR is a bug fix for attachment file validation logic — it corrects an issue where the error modal didn't appear when uploading an oversized attachment via the receipt button. The changes are internal (validation logic, image file type detection, test updates) and don't affect any user-facing feature names, workflows, settings, or terminology that would be documented in the help site.

fix: No error modal when sending a specific attachment via the receip…

e8c749f

…t button

melvin-bot bot assigned nkdengineer Mar 24, 2026

nkdengineer added 2 commits March 24, 2026 17:47

run prettier

a14556e

update test case

5cc4627

nkdengineer marked this pull request as ready for review March 24, 2026 13:32

nkdengineer requested review from a team as code owners March 24, 2026 13:32

melvin-bot bot requested review from dukenv0307 and trjExpensify and removed request for a team and trjExpensify March 24, 2026 13:32

nkdengineer added 2 commits March 25, 2026 16:24

Merge branch 'main' into fix/85951

524c92b

Merge branch 'main' into fix/85951

ab0758c

remove resize logic at picker step

42b5de0

dukenv0307 approved these changes Apr 9, 2026

View reviewed changes

melvin-bot bot requested a review from dangrous April 9, 2026 04:04

dangrous approved these changes Apr 9, 2026

View reviewed changes

dangrous merged commit 7c46a54 into Expensify:main Apr 9, 2026
32 checks passed

OSBotify mentioned this pull request Apr 10, 2026

Deploy Checklist: New Expensify 2026-04-10 #87562

Open

87 tasks

OSBotify mentioned this pull request Apr 10, 2026

Chat - App blinks when "Attachment error" modal shows up #87605

Open

7 tasks

Conversation

nkdengineer commented Mar 24, 2026

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

nkdengineer commented Mar 24, 2026

Uh oh!

codecov bot commented Mar 24, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot bot commented Mar 24, 2026

Uh oh!

dukenv0307 commented Mar 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dangrous commented Mar 24, 2026

Uh oh!

nkdengineer commented Apr 1, 2026

Uh oh!

dukenv0307 commented Apr 1, 2026

Uh oh!

nkdengineer commented Apr 3, 2026

Uh oh!

dukenv0307 commented Apr 3, 2026

Uh oh!

dukenv0307 commented Apr 7, 2026

Uh oh!

nkdengineer commented Apr 7, 2026

Uh oh!

dukenv0307 commented Apr 9, 2026

Uh oh!

chatgpt-codex-connector bot commented Apr 9, 2026

Uh oh!

dukenv0307 commented Apr 9, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

Uh oh!

github-actions bot commented Apr 9, 2026

Uh oh!

github-actions bot commented Apr 9, 2026

Uh oh!

OSBotify commented Apr 9, 2026

Uh oh!

OSBotify commented Apr 10, 2026

Uh oh!

MelvinBot commented Apr 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

codecov bot commented Mar 24, 2026 •

edited by github-actions bot

Loading

dukenv0307 commented Mar 24, 2026 •

edited

Loading