[CP Staging] Revert "Enhance icons UI consistency" by grgia · Pull Request #86555 · Expensify/App

grgia · 2026-03-27T15:23:40Z

Reverts #83799

Fixes

$ #86535

$ #86536

$ #86537

$ #86538

$ #86544

$ #86546

$ #86548

$ #86551

$ #86552

$ #86556

melvin-bot · 2026-03-27T15:23:45Z

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

melvin-bot · 2026-03-27T15:24:18Z

@srikarparsi Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

grgia · 2026-03-27T15:29:08Z

straight revert, ignore lint

codecov · 2026-03-27T15:32:02Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
...s/AddPaymentCard/PaymentCardChangeCurrencyForm.tsx	`0.00% <ø> (ø)`
...onents/AddPaymentCard/PaymentCardCurrencyModal.tsx	`0.00% <ø> (ø)`
src/components/ApproverSelectionList.tsx	`91.17% <ø> (ø)`
...ponents/BaseVacationDelegateSelectionComponent.tsx	`0.00% <ø> (ø)`
src/components/CategoryPicker.tsx	`0.00% <ø> (ø)`
.../components/CountryPicker/CountrySelectorModal.tsx	`0.00% <ø> (ø)`
src/components/CurrencySelectionList/index.tsx	`0.00% <ø> (ø)`
...ents/DatePicker/CalendarPicker/YearPickerModal.tsx	`71.42% <ø> (ø)`
src/components/DestinationPicker.tsx	`0.00% <ø> (ø)`
src/components/MoneyRequestConfirmationList.tsx	`61.69% <ø> (-0.61%)`	⬇️
... and 171 more
... and 10 files with indirect coverage changes

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f5d23c4cd6

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-03-27T15:40:30Z

+                            <PressableWithFeedback
+                                accessibilityLabel={item.text ?? ''}
+                                role={CONST.ROLE.BUTTON}
+                                sentryLabel={CONST.SENTRY_LABEL.USER_LIST_ITEM.CHECKBOX}


Expose multiselect toggles as checkboxes

Replacing SelectionCheckbox with PressableWithFeedback here changes the control semantics to role=button and removes explicit checked-state metadata, so in UserListItem flows that use canSelectMultiple (participant/member pickers) assistive technologies can no longer reliably announce whether an option is selected. This regresses accessibility compared with the previous checkbox implementation; this control should expose checkbox semantics (role/accessibilityState.checked) or reuse the shared Checkbox component.

Useful? React with 👍 / 👎.

Beamanator · 2026-03-27T16:04:37Z

all you @grgia - feel free to merge if you wanna skip the checks since this looks like a straight revert :D

melvin-bot · 2026-03-27T16:38:21Z

@grgia looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

github-actions · 2026-03-27T16:38:54Z

🚧 @grgia has triggered a test Expensify/App build. You can view the workflow run here.

grgia · 2026-03-27T16:39:37Z

This was a straight revert

…-select-icons [CP Staging] Revert "Enhance icons UI consistency" (cherry picked from commit a0adf62) (cherry-picked to staging by grgia)

github-actions · 2026-03-27T16:43:43Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #86555.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-a0adf62-1b6347b-8d47675d696b4f9e854f482dbb5e91fc2dea3aed/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-a0adf62-1b6347b-304fa77bc4593b66bee01c7ee9e8a47f6a2f1275/index.html

Web 🕸️
https://86555.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-03-27T16:47:18Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-03-27T17:14:16Z

🚀 Cherry-picked to staging by https://github.com/grgia in version: 9.3.50-2 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

MelvinBot · 2026-03-27T17:17:18Z

👋 Hi grgia, I reviewed PR #86555 against the help site articles under docs/articles/.

Conclusion: No help site changes required

Reasoning:

This is a revert PR — it reverts Enhance icons UI consistency #83799 ("Enhance icons UI consistency"), restoring the previous UI behavior. The original PR had zero documentation file changes, so there's nothing to "un-document."
All changes are internal component-level — the diff swaps selection list item components (e.g., SingleSelectListItem → RadioListItem), removes the SelectionCheckbox component, and adjusts icon rendering props. These are purely visual/implementation details that don't affect feature names, navigation paths, button labels, or user-facing workflows.
Help site articles use generic terms — articles that mention "checkmark" or "checkbox" (e.g., Adding-Attendees.md, Create-a-New-Chat.md, Search-and-Download-Expenses.md) describe the general concept of selection indicators, not the specific underlying component. Since the revert restores the previously-documented behavior, these descriptions remain accurate.
No terminology or workflow changes — no features were added, removed, or renamed. No navigation paths changed. No button labels changed.

No action needed on the docs side for this PR.

OSBotify · 2026-03-31T20:04:38Z

🚀 Cherry-picked to staging by https://github.com/grgia in version: 9.3.51-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

MelvinBot · 2026-03-31T20:07:21Z

👋 Hi grgia, I've re-reviewed PR #86555 against the help site guidelines as requested.

Review Against Help Site Standards

I reviewed:

docs/HELPSITE_NAMING_CONVENTIONS.md — requires exact UI text, bold formatting, matching capitalization
docs/HELP_AUTHORING_GUIDELINES.md — task-based headings, exact UI terminology, one workflow per article
docs/TEMPLATE.md — structural template for articles

Articles Checked

I found 15+ articles under docs/articles/ that reference selection-related UI concepts (checkboxes, checkmarks, selected buttons). Key articles include:

Article	References
`Managing-Expenses-in-a-Report.md`	"Click the checkbox next to the expense(s)", green selected button
`Search-and-Download-Expenses.md`	"Check the box next to the expenses or reports"
`Adding-Attendees.md`	Checkmark confirmation indicator
`Create-expense-categories.md`	Bulk actions using checkboxes
`Account-Settings.md`	Checkmark for language selection
`Merge-Accounts.md`	"Check the box that says..."
`Configure-Per-Diem-in-a-workspace.md`	"X selected dropdown"

Conclusion: No help site changes required

Reasoning:

This is a revert — it restores the UI to its pre-Enhance icons UI consistency #83799 state, which is the behavior the existing documentation was written against.
All changes are internal components — the diff swaps selection list item component types (SingleSelectListItem ↔ RadioListItem), removes SelectionCheckbox, and adjusts icon rendering props. These are implementation details, not user-facing changes.
Help articles describe user actions, not components — the articles use terms like "check the box," "click the checkbox," and "checkmark" to describe what users see and do. These terms describe the visual behavior, which is restored (not altered) by this revert.
No feature, label, or navigation changes — no features were added/removed, no button labels changed, and no navigation paths were modified.

Since the revert restores the previously-documented behavior, all existing help site articles remain accurate. No documentation PR is needed.

OSBotify · 2026-03-31T21:52:54Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.3.50-8 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

zfurtak · 2026-04-01T12:19:41Z

I can't continue working on bringing it back to life but I'm passing it to @mhawryluk, so it'll be in good hands 😊

OSBotify · 2026-04-02T19:56:00Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.3.51-10 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

Revert "Enhance icons UI consistency"

f5d23c4

grgia requested review from dukenv0307 and zfurtak March 27, 2026 15:23

grgia self-assigned this Mar 27, 2026

grgia requested review from a team as code owners March 27, 2026 15:23

melvin-bot Bot requested review from srikarparsi and trjExpensify and removed request for a team March 27, 2026 15:23

melvin-bot Bot removed the request for review from a team March 27, 2026 15:24

grgia changed the title ~~Revert "Enhance icons UI consistency"~~ [CP Staging] Revert "Enhance icons UI consistency" Mar 27, 2026

grgia requested review from Beamanator March 27, 2026 15:33

chatgpt-codex-connector Bot reviewed Mar 27, 2026

View reviewed changes

Beamanator approved these changes Mar 27, 2026

View reviewed changes

grgia merged commit a0adf62 into main Mar 27, 2026
38 of 44 checks passed

grgia deleted the revert-83799-@zfurtak/change-select-icons branch March 27, 2026 16:38

melvin-bot Bot added the Emergency label Mar 27, 2026

grgia removed the Emergency label Mar 27, 2026

OSBotify added the CP Staging marks PRs that have been CP'd to staging label Mar 27, 2026

OSBotify mentioned this pull request Mar 27, 2026

Deploy Checklist: New Expensify 2026-03-27 #86530

Closed

86 tasks

MelvinBot mentioned this pull request Mar 30, 2026

Wallet - No left and right spacing on Next button on Choose your bank account page #86559

Closed

7 tasks

Conversation

grgia commented Mar 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

melvin-bot Bot commented Mar 27, 2026

Uh oh!

melvin-bot Bot commented Mar 27, 2026

Uh oh!

grgia commented Mar 27, 2026

Uh oh!

codecov Bot commented Mar 27, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Mar 27, 2026

Choose a reason for hiding this comment

Uh oh!

Beamanator commented Mar 27, 2026

Uh oh!

Uh oh!

melvin-bot Bot commented Mar 27, 2026

Uh oh!

github-actions Bot commented Mar 27, 2026

Uh oh!

grgia commented Mar 27, 2026

Uh oh!

github-actions Bot commented Mar 27, 2026

Uh oh!

OSBotify commented Mar 27, 2026

Uh oh!

OSBotify commented Mar 27, 2026

Uh oh!

MelvinBot commented Mar 27, 2026

Conclusion: No help site changes required

Uh oh!

OSBotify commented Mar 31, 2026

Uh oh!

MelvinBot commented Mar 31, 2026

Review Against Help Site Standards

Articles Checked

Conclusion: No help site changes required

Uh oh!

OSBotify commented Mar 31, 2026

Uh oh!

zfurtak commented Apr 1, 2026

Uh oh!

OSBotify commented Apr 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

grgia commented Mar 27, 2026 •

edited

Loading

codecov Bot commented Mar 27, 2026 •

edited by github-actions Bot

Loading