[HOLD] Decompose ReportActionComposer#86899
Draft
adhorodyski wants to merge 48 commits intoExpensify:mainfrom
Draft
[HOLD] Decompose ReportActionComposer#86899adhorodyski wants to merge 48 commits intoExpensify:mainfrom
adhorodyski wants to merge 48 commits intoExpensify:mainfrom
Conversation
…tate Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…ents Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…tion Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…ds without minHeight hack Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
… onAttachmentPreviewClose
…ubmit from provider Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…r + useReceiptDrop
… debouncedValidate
Contributor
|
FYI: I've just added #87097 to the Fixed issues section in the PR description |
This was referenced Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@rlinoz
Explanation of Change
Decomposes the 808-LOC
ReportActionComposemonolith into a compound component architecture with optimized render performance.Compound components:
The orchestrator is now 55 LOC — pure composition with
Composer.Box,Composer.DropZone,Composer.LocalTime,Composer.Footer,Composer.ActionMenu,Composer.Input,Composer.EmojiPicker, andComposer.SendButton. Each component owns its behavior and self-subscribes to Onyx data per CLEAN-REACT-PATTERNS-2.6 contexts organized by change frequency:
isFocused,isMenuVisible,isFullComposerAvailableisSendDisabled,exceededMaxLength,isBlockedFromConcierge— all primitives, no function refshandleSendMessage,onValueChangeHook split for render isolation:
useAttachmentUploadValidationintouseAttachmentPicker(lightweight, no Onyx subs) anduseReceiptDrop(heavy, ~10 Onyx subs). Each consumer calls its hook directly instead of reading from context.useComposerSubmitfrom provider toComposerInputWrapper(its sole consumer), removing ~12 Onyx subscriptions from the provider render path.useComposerFocus— owns focus state internally.Activity API for hidden subtrees:
PopoverMenuinAttachmentPickerWithMenuItemswith<Activity mode>— React skips reconciliation of the entire menu subtree when closed.EmojiPickerpopover with<Activity mode>— same optimization for the global emoji picker.Performance (React Profiler, averaged across 3-4 runs):
Fixed Issues
$ #87097
PROPOSAL:
Tests