ReportActionCompose 3/6: ComposerProvider with subcomponents by adhorodyski · Pull Request #87639 · Expensify/App

adhorodyski · 2026-04-10T14:34:21Z

Explanation of Change

PR 3/6 in the ReportActionCompose decomposition series (issue #87097).

Wraps the 834-line ReportActionCompose monolith in ComposerProvider (from PR 1) and extracts 10 child components, each subscribing only to the contexts it needs. The orchestrator shrinks from 834 → 355 LOC with only 2 context subscriptions remaining (for shared attachment/DropZone state).

Extracted components (all new files):

Component	LOC	What it does	Context subscriptions
`ComposerBox`	49	OfflineWithFeedback container + border styling	State, SendState, Meta
`ComposerLocalTime`	39	Guard-wrapped participant time zone display	None (Onyx only)
`ComposerFooter`	26	Pure layout container, accepts children	None
`ComposerSendButton`	17	Thin context bridge → SendButton	SendState, SendActions
`ComposerExceededLength`	18	Guard-wrapped character count warning	SendState
`AgentZeroAwareTypingIndicator`	13	Suppresses typing indicator for Agent Zero	None
`ComposerActionMenu`	68	Context→props bridge for AttachmentPickerWithMenuItems	State, SendState, Actions, Meta
`ComposerInputWrapper`	134	Context→props bridge for ComposerWithSuggestions, owns inputPlaceholder + lastReportAction derivation	State, SendState, Actions, SendActions, Meta
`ComposerEmojiPicker`	70	Self-contained emoji picker button + cleanup	Actions, Meta

Other changes:

ComposerProvider: onValueChange now also calls setValue(v) to keep text context in sync
SendButton: removed memo() wrapper (React Compiler handles memoization)
ReportActionCompose: removed memo(), onSubmitAction (dead code), SuggestionsRef type (re-exported from ComposerContext), all useCallback/useMemo wrappers
Test: removed dead onSubmitAction import, uses keyPress instead

What stays inline in the orchestrator (355 LOC):

submitForm (message submission logic) — moves to useComposerSubmit hook in PR 4
useAttachmentUploadValidation + DropZone render — moves to split hooks + ComposerDropZone in PR 5
These share attachment state (validateAttachments, attachmentFileRef) which prevents clean separation without the hook extractions from PRs 4+5

Context subscription design:

No subscribe-to-everything middleman — each wrapper subscribes selectively
Orchestrator subscribes to only 2 of 6 contexts (SendState for exceededMaxLength, Meta for attachment refs)
ComposerFooter is context-free (pure layout), its children self-subscribe independently

💡 I recommend reviewing this with Hide whitespace.

Fixed Issues

$ #87097
PROPOSAL:

Tests

Open a DM chat → verify composer renders correctly with input field, + button, emoji picker, send button
Type a message and press Enter → verify it sends and appears in the chat
Open a DM with a user in a different timezone → verify the local time display shows above the composer
Open a workspace chat → verify local time does NOT show
Type a very long message (4000+ characters) → verify the character count warning appears below the composer
Start typing in any chat → verify the typing indicator appears in the footer area
Open the + menu → verify it opens with all options, close it → verify composer refocuses
Open emoji picker → select an emoji → verify it inserts into the composer
Drag and drop a file onto the composer → verify the drop zone appears
Go offline → type and send a message → verify it queues, go back online → verify it sends
Navigate between different chats → verify composer state resets per room
Verify no JS console errors throughout all steps

Offline tests

Go offline → type a message → press Enter → verify it appears optimistically
Go back online → verify the message syncs

QA Steps

Same as tests above.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

…orchestrator-leaves

… as thin wrappers Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

…r-leaves

melvin-bot · 2026-04-14T10:49:56Z

@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d5bbacc3ca

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-04-14T11:02:54Z

+            disabled={isBlockedFromConcierge || isEmojiPickerVisible()}
+            setIsCommentEmpty={() => {}}
+            onEnterKeyPress={handleSendMessage}
+            shouldShowComposeInput={shouldShowComposeInput}


Restore one-way composer autofocus latch

This wrapper no longer passes any didHideComposerInput state into ComposerWithSuggestions, even though that component’s autofocus condition explicitly depends on !didHideComposerInput. The previous one-way latch prevented refocusing after the compose input had been hidden once; without it, flows where SHOULD_SHOW_COMPOSE_INPUT toggles off and back on can unexpectedly autofocus and reopen the keyboard.

Useful? React with 👍 / 👎.

The one-way latch (didHideComposerInput) was dead code in the original orchestrator. Our PR doesn't pass it (undefined), which produces identical behavior:

Default case: shouldShowComposeInput starts true → original latch would be false → !false = true. Our !undefined = true. Same.

Small screens (native/mWeb): ReportFooter unmounts the entire composer when shouldShowComposeInput goes false. On re-show, the component remounts fresh — the latch never had a chance to fire.

Large screens (web): The refocus effect checks willBlurTextInputOnTapOutside || shouldAutoFocus. On wide layouts willBlurTextInputOnTapOutside() returns true, short-circuiting the check — shouldAutoFocus (and therefore the latch) is never evaluated.

The blueprint PR (#86899) removes the prop and latch entirely from ComposerWithSuggestions. Our split-plan does the same cleanup in PR 4.

@MelvinBot Could you recheck if this is safe to remove didHideComposerInput

@MelvinBot, You need to check the code to verify that we are not missing anything. Should not rely on above comments

Verified directly from code on main — yes, safe to remove. The prop is already dead code today.

didHideComposerInput exists in only one file: ComposerWithSuggestions.tsx (type at line 152, destructured at line 249, used at line 296). No caller passes it. ComposerInput.tsx:104-131 is the sole place ComposerWithSuggestions is rendered, and it does not include didHideComposerInput in its JSX props. ReportActionCompose.tsx has zero references to it — the state hook and one-way latch effect that used to produce this value have already been removed.

Since the prop is optional (didHideComposerInput?: boolean), it defaults to undefined. The only usage is:

// ComposerWithSuggestions.tsx:296 const shouldAutoFocus = ... && !didHideComposerInput;

!undefined === true, so the term is already a no-op. Removing it changes zero runtime behavior.

Edge cases checked:

Large screens (web desktop): Composer stays mounted when shouldShowComposeInput flips false (ReportFooter.tsx:90), but didHideComposerInput is already undefined there too — no behavioral difference.

Tablets: Same as large screens — isSmallScreenWidth is false, composer stays mounted, prop already undefined.

Small screens: Composer unmounts entirely when shouldShowComposeInput is false, so the latch was never needed.

@MelvinBot You need to check deeper to understand why don't pass didHideComposerInput into ComposerWithSuggestions in ComposerInput is fine

Dug deeper. Here's the full trace of every code path where didHideComposerInput could matter.

The only logic reference is at ComposerWithSuggestions.tsx:296:

const shouldAutoFocus = (shouldFocusInputOnScreenFocus || !!draftComment) && shouldShowComposeInput && areAllModalsHidden() && isFocused && !didHideComposerInput;

!undefined === !false === true — so omitting the prop only differs from passing true. The question is: can the old latch ever fire (didHideComposerInput=true) while the composer stays mounted?

The latch fires when shouldShowComposeInput goes false. The only writer that sets it to false is ReportActionItemMessageEdit.tsx:557 (user focuses the edit composer for an existing message).

shouldAutoFocus has 4 consumers — here's what happens in each when didHideComposerInput is undefined instead of true:

# Usage Location Impact of undefined vs true

1 autoFocus prop line 967 None. React ignores autoFocus after mount. At mount time, shouldShowComposeInput defaults to true, so the old latch initialized to false — same as undefined.

2 updateMultilineInputRange line 840 None. Empty [] deps — only runs once at mount, same initial value as above.

3 Modal-close refocus line 827 None. Condition is willBlurTextInputOnTapOutside || shouldAutoFocus. The latch only differs on large screens (where the composer stays mounted per ReportFooter.tsx:90), and on large screens willBlurTextInputOnTapOutside returns true — short-circuiting the OR.

4 Delayed RHP focus lines 662-686 Theoretically different but near-impossible: only fires when shouldDelayAutoFocus=true (stacked SearchReport RHP) AND the user edited a message AND finished editing. In this case the old code blocked refocus, the new code allows it — arguably better behavior.

Platform-by-platform breakdown

Small screens (native + mWeb): ReportFooter.tsx:90 renders the composer only when shouldShowComposeInput \|\| !isSmallScreenWidth. On small screens, !isSmallScreenWidth is false, so when shouldShowComposeInput=false, the entire composer tree unmounts. On re-show it remounts fresh — the latch never persists across mount boundaries. didHideComposerInput is irrelevant.

Large screens, web wide layout: Composer stays mounted (!isSmallScreenWidth=true keeps the condition true). willBlurTextInputOnTapOutside() returns true (it's !getIsNarrowLayout() on web). This short-circuits all the relevant OR conditions, making shouldAutoFocus redundant for the modal-close refocus path (usage #3).

Large screens, web narrow layout: willBlurTextInputOnTapOutside() returns false, but isSmallScreenWidth would be true → composer unmounts → same as small screen case.

Bottom line: Safe to remove. In every reachable scenario, undefined produces identical behavior to what the old latch produced. The only theoretical gap (stacked SearchReport RHP + mid-edit toggle) is both unreachable in practice and results in better behavior if it ever fired.

@adhorodyski At this point

Large screens (web): The refocus effect checks willBlurTextInputOnTapOutside || shouldAutoFocus. On wide layouts willBlurTextInputOnTapOutside() returns true, short-circuiting the check — shouldAutoFocus (and therefore the latch) is never evaluated.

shouldAutoFocus is used in other places. Could you also prove that it's safe in all places? Your above point only prove the safe in one place

@DylanDylann verified directly in code — walking through each shouldAutoFocus consumer in ComposerWithSuggestions.tsx:

Mount-only (unaffected by latch removal):

autoFocus prop on <Composer> (line 967) — React reads autoFocus only at mount. Latch init is useState(!shouldShowComposeInput); Onyx default is true → latch starts false → !false === !undefined === true. Same.

updateMultilineInputRange effect (line 840) — [] deps, mount-only. Same as above.

Post-mount (where the latch could matter):
3. Modal-close / screen-refocus effect (line 827) — guard is (willBlurTextInputOnTapOutside || shouldAutoFocus) && .... Per platform:

Web wide: willBlurTextInputOnTapOutside = !getIsNarrowLayout() → true → short-circuits OR, shouldAutoFocus never evaluated.

Web narrow / native phone: isSmallScreenWidth=true. ReportFooter.tsx:90 unmounts the whole composer when shouldShowComposeInput=false (!shouldHideComposer && (shouldShowComposeInput || !isSmallScreenWidth)). Remount resets state — latch never persists.

Native tablet (iPad): willBlurTextInputOnTapOutside=false and !isSmallScreenWidth=true keeps the composer mounted — the one platform where the latch could theoretically differ. But the effect has a second guard at line 831: if (editFocused) { inputFocusChange(false); return; } — if the user is actively in edit mode, refocus is blocked anyway. editFocused is the real safety net; the latch was a redundant second layer.

Delayed RHP focus effect (lines 662-686) — requires shouldDelayAutoFocus=true (stacked SearchReport RHP). Incompatible with the edit-mode flow that triggers the latch. Unreachable combo.

Only writer of shouldShowComposeInput=false is ReportActionItemMessageEdit.tsx:557 (via setShouldShowComposeInputKeyboardAware), so the latch was only ever tied to message-edit flows.

Safe to remove in every reachable path.

codecov · 2026-04-14T17:04:55Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
...ortActionCompose/AgentZeroAwareTypingIndicator.tsx	`100.00% <100.00%> (ø)`
...s/inbox/report/ReportActionCompose/ComposerBox.tsx	`100.00% <100.00%> (ø)`
...nbox/report/ReportActionCompose/ComposerContext.ts	`92.30% <ø> (+92.30%)`	⬆️
...ort/ReportActionCompose/ComposerExceededLength.tsx	`100.00% <100.00%> (ø)`
...nbox/report/ReportActionCompose/ComposerFooter.tsx	`100.00% <100.00%> (ø)`
...ox/report/ReportActionCompose/ComposerProvider.tsx	`80.95% <100.00%> (+80.95%)`	⬆️
.../report/ReportActionCompose/ComposerSendButton.tsx	`100.00% <100.00%> (ø)`
...omposerWithSuggestions/ComposerWithSuggestions.tsx	`58.73% <100.00%> (-0.58%)`	⬇️
...es/inbox/report/ReportActionCompose/SendButton.tsx	`100.00% <ø> (ø)`
.../report/ReportActionCompose/ComposerActionMenu.tsx	`87.50% <87.50%> (ø)`
... and 5 more
... and 218 files with indirect coverage changes

…d architecture Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

joekaufmanexpensify · 2026-04-14T20:49:12Z

No product review needed

DylanDylann · 2026-04-15T05:05:02Z

Let's move this section into a new component

                    {shouldDisplayDualDropZone && (
                        <DualDropZone
                            isEditing={shouldAddOrReplaceReceipt && hasReceipt}
                            onAttachmentDrop={(dragEvent) => validateAttachments({dragEvent})}
                            onReceiptDrop={onReceiptDropped}
                            shouldAcceptSingleReceipt={shouldAddOrReplaceReceipt}
                        />
                    )}
                    {!shouldDisplayDualDropZone && (
                        <DragAndDropConsumer onDrop={(dragEvent) => validateAttachments({dragEvent})}>
                            <DropZoneUI
                                icon={icons.MessageInABottle}
                                dropTitle={translate('dropzone.addAttachments')}
                                dropStyles={styles.attachmentDropOverlay(true)}
                                dropTextStyles={styles.attachmentDropText}
                                dashedBorderStyles={[styles.dropzoneArea, styles.easeInOpacityTransition, styles.activeDropzoneDashedBorder(theme.attachmentDropBorderColorActive, true)]}
                            />
                        </DragAndDropConsumer>
                    )}

DylanDylann · 2026-04-15T05:06:22Z

It's clean to have a new component for this

@adhorodyski How about this?

DylanDylann · 2026-04-15T05:10:51Z

This would result in a really nice structure

DylanDylann · 2026-04-15T05:13:49Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1bb139c8f3

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

adhorodyski · 2026-04-15T09:21:08Z

Let's move this section into a new component (Dropzone)

This is planned for PR 5 where we introduce useAttachmentUploadValidation hook. Extracting now would require prop-drilling validateAttachments which the hook eliminates. I'd leave it as-is for now.

…context for isBlockedFromConcierge Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

adhorodyski · 2026-04-15T15:23:25Z

@DylanDylann responded to all comments, pushed updates with the latest commit. back to you

…r-leaves

DylanDylann · 2026-04-16T07:43:12Z

Checking again

DylanDylann · 2026-04-16T08:50:11Z

+            onPasteFile={onPasteFile}
+            onClear={submitForm}
+            disabled={isBlockedFromConcierge || isEmojiPickerVisible()}
+            setIsCommentEmpty={() => {}}


setIsCommentEmpty prop is redundant now, please remove this prop

DylanDylann · 2026-04-16T08:59:12Z

+            disabled={isBlockedFromConcierge || isEmojiPickerVisible()}
+            setIsCommentEmpty={() => {}}
+            onEnterKeyPress={handleSendMessage}
+            shouldShowComposeInput={shouldShowComposeInput}


@MelvinBot Could you recheck if this is safe to remove didHideComposerInput

DylanDylann · 2026-04-16T09:01:43Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2026-04-16.at.16.16.34.mov

Android: mWeb Chrome

Screen.Recording.2026-04-16.at.16.13.54.mov

iOS: HybridApp

Screen.Recording.2026-04-16.at.16.23.45.mov

iOS: mWeb Safari

Screen.Recording.2026-04-16.at.16.15.13.mov

MacOS: Chrome / Safari

Screen.Recording.2026-04-16.at.16.09.51.mov

MelvinBot · 2026-04-16T09:02:36Z

Yes, removing didHideComposerInput is safe. Here's why:

The prop is effectively dead code in all scenarios:

Default case: shouldShowComposeInput starts true → latch initializes to false → !false = true. Without the prop, !undefined = true. Identical behavior.
Small screens (native/mWeb): ReportFooter (ReportFooter.tsx:90) unmounts the entire composer tree when shouldShowComposeInput goes false. On re-show, the component remounts fresh — the latch never has a chance to fire.
Large screens (web): willBlurTextInputOnTapOutside() returns true (index.ts:4), which short-circuits the only condition where shouldAutoFocus (and thus didHideComposerInput) matters — the modal-close refocus at ComposerWithSuggestions.tsx:827.

The blueprint PR (#86899) also removes this prop entirely from ComposerWithSuggestions, confirming the team's intent to treat it as dead code.

DylanDylann · 2026-04-16T10:14:03Z

@adhorodyski Three questions. The rest looks fine

#87639 (comment)
#87639 (comment)
#87639 (comment)

…tor-leaves' into decompose/composer-pr3-orchestrator-leaves

adhorodyski · 2026-04-17T12:57:46Z

Applied requested changes and responded here #87639 (comment) to the latch removal aspect, all ready.

DylanDylann

LGTM

DylanDylann · 2026-04-19T07:11:15Z


        /** Function to set whether the comment is empty */
-        setIsCommentEmpty: (isCommentEmpty: boolean) => void;
+        setIsCommentEmpty?: (isCommentEmpty: boolean) => void;


I mean we should remove this prop totally. Do you plan to do it in PR 4?

Yess let's leave this for PR4 as I have other props that will be dropped there as per #87097 (comment)

github-actions · 2026-04-20T08:57:24Z

🚧 @cristipaval has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-04-20T09:02:25Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #87639.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-df08b0d-f81070b-c987c6d8e7fb23dbb3722fd169fbefb4274c18c9/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-df08b0d-f81070b-c02656508e2c181dd12c2832109c557a9e790d7c/index.html

Web 🕸️
https://87639.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-04-20T09:05:00Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-04-21T11:37:55Z

🚀 Deployed to staging by https://github.com/cristipaval in version: 9.3.61-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

MelvinBot · 2026-04-21T11:38:59Z

I reviewed the changes in this PR. This is a purely internal refactoring that decomposes the ReportActionCompose monolith into smaller sub-components (ComposerBox, ComposerLocalTime, ComposerFooter, ComposerSendButton, etc.).

No user-facing behavior, UI labels, features, or settings are changed — the composer renders and functions identically before and after this PR.

No help site documentation updates are required.

adhorodyski and others added 2 commits April 10, 2026 16:31

Wrap in ComposerProvider, extract Box/Footer/LocalTime/SendButton

68bbda3

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Merge remote-tracking branch 'exfy/main' into decompose/composer-pr3-…

a17851f

…orchestrator-leaves

melvin-bot Bot assigned adhorodyski Apr 10, 2026

adhorodyski changed the title ~~[No QA] Decompose ReportActionCompose 3/6: wrap in ComposerProvider, extract Box/Footer/LocalTime/SendButton~~ ReportActionCompose 3/6: ComposerProvider with subcomponents Apr 10, 2026

adhorodyski and others added 7 commits April 10, 2026 17:58

Extract ComposerActionMenu, ComposerInputWrapper, ComposerEmojiPicker…

5726dd3

… as thin wrappers Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Extract ComposerExceededLength: guard-wrapped, context-free footer

c9eb9f7

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Inline shouldDisplayDualDropZone derivation, remove IIFE

2bb2704

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Inline inputPlaceholder derivation, remove IIFE

ac0c4be

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Move lastReportAction derivation into ComposerInputWrapper

ce0c495

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

ComposerFooter: accept children, move child components to orchestrator

24cc6db

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Merge branch 'Expensify:main' into decompose/composer-pr3-orchestrato…

d5bbacc

…r-leaves

adhorodyski marked this pull request as ready for review April 14, 2026 10:49

adhorodyski requested review from a team as code owners April 14, 2026 10:49

melvin-bot Bot requested review from DylanDylann and joekaufmanexpensify and removed request for a team April 14, 2026 10:49

melvin-bot Bot removed the request for review from a team April 14, 2026 10:49

chatgpt-codex-connector Bot reviewed Apr 14, 2026

View reviewed changes

rlinoz self-requested a review April 14, 2026 14:23

Fix ReportActionComposeTest message validation tests for context-base…

1bb139c

…d architecture Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

adhorodyski force-pushed the decompose/composer-pr3-orchestrator-leaves branch from 8e718f3 to 1bb139c Compare April 14, 2026 18:02

joekaufmanexpensify removed their request for review April 14, 2026 20:49

DylanDylann reviewed Apr 15, 2026

View reviewed changes

chatgpt-codex-connector Bot reviewed Apr 15, 2026

View reviewed changes

Comment thread src/pages/inbox/report/ReportActionCompose/ComposerInput.tsx Outdated

Comment thread src/pages/inbox/report/ReportActionCompose/ComposerInput.tsx

DylanDylann reviewed Apr 15, 2026

View reviewed changes

Comment thread src/pages/inbox/report/ReportActionCompose/ComposerEmojiPicker.tsx Outdated

Address PR review feedback: renames, remove redundant isOffline, use …

777d360

…context for isBlockedFromConcierge Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

rlinoz requested a review from DylanDylann April 15, 2026 17:04

Merge branch 'Expensify:main' into decompose/composer-pr3-orchestrato…

96a3ca7

…r-leaves

DylanDylann reviewed Apr 16, 2026

View reviewed changes

adhorodyski added 3 commits April 17, 2026 14:54

Make setIsCommentEmpty optional, remove no-op caller

da5bdd1

Extract ComposerImportedState from orchestrator

0c4bfb3

Merge remote-tracking branch 'origin/decompose/composer-pr3-orchestra…

b5f8a21

…tor-leaves' into decompose/composer-pr3-orchestrator-leaves

adhorodyski requested a review from DylanDylann April 17, 2026 16:06

DylanDylann approved these changes Apr 19, 2026

View reviewed changes

melvin-bot Bot requested a review from cristipaval April 19, 2026 07:12

cristipaval approved these changes Apr 20, 2026

View reviewed changes

cristipaval merged commit df08b0d into Expensify:main Apr 20, 2026
35 of 38 checks passed

adhorodyski deleted the decompose/composer-pr3-orchestrator-leaves branch April 20, 2026 09:08

OSBotify mentioned this pull request Apr 21, 2026

Deploy Checklist: New Expensify 2026-04-21 #88394

Open

OSBotify mentioned this pull request Apr 21, 2026

Chat - Maximum character limit error message cuts off if composer expanded #88489

Open

7 tasks

#	Usage	Location	Impact of `undefined` vs `true`
1	`autoFocus` prop	line 967	None. React ignores `autoFocus` after mount. At mount time, `shouldShowComposeInput` defaults to `true`, so the old latch initialized to `false` — same as `undefined`.
2	`updateMultilineInputRange`	line 840	None. Empty `[]` deps — only runs once at mount, same initial value as above.
3	Modal-close refocus	line 827	None. Condition is `willBlurTextInputOnTapOutside \|\| shouldAutoFocus`. The latch only differs on large screens (where the composer stays mounted per `ReportFooter.tsx:90`), and on large screens `willBlurTextInputOnTapOutside` returns `true` — short-circuiting the OR.
4	Delayed RHP focus	lines 662-686	Theoretically different but near-impossible: only fires when `shouldDelayAutoFocus=true` (stacked SearchReport RHP) AND the user edited a message AND finished editing. In this case the old code blocked refocus, the new code allows it — arguably better behavior.

Conversation

adhorodyski commented Apr 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Apr 14, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chatgpt-codex-connector Bot Apr 14, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

MelvinBot Apr 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

MelvinBot Apr 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

codecov Bot commented Apr 14, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

joekaufmanexpensify commented Apr 14, 2026

Uh oh!

DylanDylann commented Apr 15, 2026

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

DylanDylann commented Apr 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

DylanDylann commented Apr 15, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

adhorodyski commented Apr 15, 2026

Uh oh!

adhorodyski commented Apr 15, 2026

Uh oh!

DylanDylann commented Apr 16, 2026

Uh oh!

DylanDylann Apr 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

adhorodyski commented Apr 10, 2026 •

edited

Loading

MelvinBot Apr 16, 2026 •

edited

Loading

MelvinBot Apr 16, 2026 •

edited

Loading

codecov Bot commented Apr 14, 2026 •

edited by github-actions Bot

Loading

DylanDylann commented Apr 15, 2026 •

edited

Loading

DylanDylann Apr 16, 2026 •

edited

Loading

DylanDylann commented Apr 16, 2026 •

edited

Loading

adhorodyski Apr 20, 2026 •

edited

Loading