83860 migrate categories settings tags by huult · Pull Request #86947 · Expensify/App

huult · 2026-04-02T08:38:40Z

Explanation of Change

Fixed Issues

$ #83860
PROPOSAL:

Tests

Same QA step

Verify that no errors appear in the JS console

Offline tests

QA Steps

CASE: SETTINGS_CATEGORY_EDIT

Open the Expensify app
Go to Workspace → Categories(https://staging.new.expensify.com/workspaces/DBADDE63516996C1/categories)
Manually update the URL to:https://staging.new.expensify.com/settings/DBADDE63516996C1/categories
Open any category
Tap on the category name
Verify that the Edit Category screen opens correctly
Navigating back returns to the previous screen correctly

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2026-04-02.at.15.44.23.mov

melvin-bot · 2026-04-02T08:38:48Z

@mananjadhav Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: fe1a46c114

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

codecov · 2026-04-02T08:59:22Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/ROUTES.ts	`16.93% <ø> (+0.01%)`	⬆️
src/SCREENS.ts	`100.00% <ø> (ø)`
src/libs/Navigation/linkingConfig/OldRoutes.ts	`100.00% <ø> (ø)`
src/libs/Navigation/linkingConfig/config.ts	`76.92% <ø> (ø)`
...gation/AppNavigator/ModalStackNavigators/index.tsx	`6.96% <0.00%> (ø)`
...ages/workspace/categories/CategorySettingsPage.tsx	`0.00% <0.00%> (ø)`
...rc/pages/workspace/categories/EditCategoryPage.tsx	`0.00% <0.00%> (ø)`
... and 5 files with indirect coverage changes

mananjadhav · 2026-04-05T19:49:25Z

@huult Can you check the Codex comments?

…ories-settings-tags

huult · 2026-04-06T02:53:51Z

@huult Can you check the Codex comments?

Resolved. TAG_CREATE doesn’t use backTo, so when we migrate SETTINGS_TAG_CREATE, we will remove backTo.

…ories-settings-tags

huult · 2026-04-20T04:03:50Z

@mananjadhav This PR is ready for review

mananjadhav · 2026-04-20T20:28:48Z

Started to review this.

mananjadhav · 2026-04-21T08:10:16Z

        queryParams: ['country'],
    },
+    SETTINGS_CATEGORY_EDIT: {
+        path: 'category-edit',


question: Did we need to rename the path to category-edit? Was it conflicting ?

Yes, we needed to rename the path to category-edit because it was conflicting.

mananjadhav · 2026-04-21T08:28:21Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

android-bt-category-edit.mov

Android: mWeb Chrome

mweb-chrome-bt-category-edit.mov

iOS: HybridApp

ios-bt-category-edit.mov

iOS: mWeb Safari

mweb-safari-bt-category-edit.mov

MacOS: Chrome / Safari

web-bt-category-edit.mov

mananjadhav · 2026-04-21T08:32:05Z

@huult I tested this one at my end, but for the subsequent PRs can you please ensure to upload videos for all platforms. Videos for all platforms except web are missing.

github-actions · 2026-04-21T09:17:57Z

🚧 @mjasikowski has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-04-21T09:22:52Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #86947.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-9a3bf0d-c079286-ae3585755f701bdb83c37bf9e35da0649551e6bc/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-9a3bf0d-c079286-0b6a58f71b26f4e9a4d10301ff0c2bafd15dc080/index.html

Web 🕸️
https://86947.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-04-21T09:25:32Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-04-21T11:36:15Z

🚀 Deployed to staging by https://github.com/mjasikowski in version: 9.3.61-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

MelvinBot · 2026-04-21T11:37:42Z

No help site changes are required for this PR.

This is a purely internal navigation/routing refactor (migrating SETTINGS_CATEGORY_EDIT to a dynamic route pattern). No user-facing features, labels, buttons, or workflows changed. The existing Create expense categories help article describes category management using UI-level steps and does not reference internal route paths.

huult added 2 commits April 2, 2026 15:37

migrate SETTINGS_CATEGORY_EDIT

6a2007f

migrate WORKSPACE_TAG_CREATE

fe1a46c

huult requested review from a team as code owners April 2, 2026 08:38

melvin-bot Bot assigned huult Apr 2, 2026

melvin-bot Bot requested review from mananjadhav and removed request for a team April 2, 2026 08:38

melvin-bot Bot requested review from heyjennahay and removed request for a team April 2, 2026 08:38

huult added 2 commits April 2, 2026 15:43

update lints

b9bcef6

update type error

ade816e

chatgpt-codex-connector Bot reviewed Apr 2, 2026

View reviewed changes

Comment thread src/ROUTES.ts Outdated

Comment thread src/ROUTES.ts Outdated

huult added 4 commits April 6, 2026 09:21

Merge remote-tracking branch 'upstream/main' into 83860-migrate-categ…

a891b55

…ories-settings-tags

remove migrate WORKSPACE_TAG_CREATE

b494b12

update position

f4d8ca9

update type errors

e259f02

huult added 6 commits April 7, 2026 14:57

Merge remote-tracking branch 'upstream/main' into 83860-migrate-categ…

ee15390

…ories-settings-tags

Merge remote-tracking branch 'upstream/main' into 83860-migrate-categ…

e3bb09a

…ories-settings-tags

Merge remote-tracking branch 'upstream/main' into 83860-migrate-categ…

4c7e40e

…ories-settings-tags

Merge remote-tracking branch 'upstream/main' into 83860-migrate-categ…

c6a5bfa

…ories-settings-tags

Merge remote-tracking branch 'upstream/main' into 83860-migrate-categ…

c261353

…ories-settings-tags

Merge remote-tracking branch 'upstream/main' into 83860-migrate-categ…

99391ca

…ories-settings-tags

update old route

efaf5f3

mananjadhav reviewed Apr 21, 2026

View reviewed changes

mananjadhav approved these changes Apr 21, 2026

View reviewed changes

melvin-bot Bot requested a review from mjasikowski April 21, 2026 08:38

mjasikowski approved these changes Apr 21, 2026

View reviewed changes

mjasikowski merged commit 9a3bf0d into Expensify:main Apr 21, 2026
35 of 37 checks passed

OSBotify mentioned this pull request Apr 21, 2026

Deploy Checklist: New Expensify 2026-04-21 #88394

Open

Conversation

huult commented Apr 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Apr 2, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

codecov Bot commented Apr 2, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

mananjadhav commented Apr 5, 2026

Uh oh!

huult commented Apr 6, 2026

Uh oh!

huult commented Apr 20, 2026

Uh oh!

mananjadhav commented Apr 20, 2026

Uh oh!

mananjadhav Apr 21, 2026

Choose a reason for hiding this comment

Uh oh!

huult Apr 21, 2026

Choose a reason for hiding this comment

Uh oh!

mananjadhav commented Apr 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

mananjadhav commented Apr 21, 2026

Uh oh!

Uh oh!

github-actions Bot commented Apr 21, 2026

Uh oh!

github-actions Bot commented Apr 21, 2026

Uh oh!

OSBotify commented Apr 21, 2026

Uh oh!

OSBotify commented Apr 21, 2026

Uh oh!

MelvinBot commented Apr 21, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

huult commented Apr 2, 2026 •

edited

Loading

codecov Bot commented Apr 2, 2026 •

edited by github-actions Bot

Loading

mananjadhav commented Apr 21, 2026 •

edited

Loading