[CP Staging] fix: link problem#87053
Conversation
|
@bernhardoj Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
|
Hey, I noticed you changed If you want to automatically generate translations for other locales, an Expensify employee will have to:
Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running: npx ts-node ./scripts/generateTranslations.ts --helpTypically, you'd want to translate only what you changed by running |
@joekaufmanexpensify @dominictb after the latest changes. I'll update the test steps |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
🚧 @srikarparsi has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
…pi-error-link [CP Staging] fix: link problem (cherry picked from commit 532f785) (cherry-picked to staging by jasperhuangg)
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Cherry-picked to staging by https://github.com/jasperhuangg in version: 9.3.52-4 🚀
Bundle Size Analysis (Sentry): |
|
I reviewed the changes in this PR against the existing help site articles under No help site changes are required. Here's why:
|
|
🚀 Deployed to production by https://github.com/roryabraham in version: 9.3.52-9 🚀
|
|
🚀 Cherry-picked to staging by https://github.com/jasperhuangg in version: 9.3.53-0 🚀
Bundle Size Analysis (Sentry): |
|
No help site changes are required for this PR. This PR moves an error message ("Please connect this bank account to a workspace…") from the Signer Info step to the earlier Country/Currency step for AUD accounts, and fixes the workspace link URL. These are UI error-handling improvements, not workflow changes. The existing help article (Connect a Business Bank Account) already directs users to start the setup from a Workspace — a flow that naturally avoids this error entirely. Since:
There's nothing to update in |
|
🚀 Cherry-picked to staging by https://github.com/jasperhuangg in version: 9.3.53-0 🚀
Bundle Size Analysis (Sentry): |
|
🚀 Deployed to production by https://github.com/roryabraham in version: 9.3.53-7 🚀
|

Explanation of Change
Fixed Issues
$ #87022
PROPOSAL: -
Tests
Australia (AUD) case
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2026-04-03.at.09.18.28.mp4
Android: mWeb Chrome
Screen.Recording.2026-04-03.at.09.17.00.mp4
iOS: Native
Screen.Recording.2026-04-03.at.09.13.12.mp4
iOS: mWeb Safari
Screen.Recording.2026-04-03.at.09.13.43.mp4
MacOS: Chrome / Safari
Screen.Recording.2026-04-03.at.09.19.45.mp4