Consistent checkboxes and radio buttons UI by mhawryluk · Pull Request #87087 · Expensify/App

mhawryluk · 2026-04-03T13:36:06Z

Explanation of Change

This is a second attempt at bringing consistency to selection lists checkboxes and radio buttons after the the first PR was reverted: #83799

Now all multiple selection lists get square checkboxes, while single selection lists show the radio buttons with new styles. Initially focused items should not be highlighted like they are when they're hovered/ focused with the keyboard.

Apart from the visual consistency, this PR also aims to refactor the related code. It introduces a unified SelectionButton component that renders as either a checkbox or radio button based on a role prop, replacing several different selection indicators. Checkbox and RadioButton are now thin wrappers around it. For SelectionLists selection button rendering has been moved in new into SelectableListItem wrapper accepting a selectionButtonPosition prop, so most individual list item components (and BaseListItem) no longer implement their own selection UI.

Key changes:

RadioListItem renamed to BaseSelectListItem - serves as the shared base for SingleSelectListItem and MultiSelectListItem, which no longer manually create checkbox components.
Simplified SelectionScreen - always uses SingleSelectListItem now, the listItem prop was removed
Removed SelectCircle, SingleOptionSelector and the Search-specific CardListItem. All usages replaced with RadioButton or the standard selection list patterns.
The shouldUseNewStyle prop on RadioButton has been removed, the new style is now the only style.
Introduced SelectableListItem - a new intermediary layer between BaseListItem and all individual list items that show a selection button. This is where selection button rendering now lives, keeping BaseListItem completely free of selection concerns.
Added BareUserListItem - a display variant of UserListItem that uses BaseListItem directly (no selection button ever rendered).

Before	After

Fixed Issues

$ #74938
PROPOSAL: N/A

Tests

Simplified testing cases to test one example of each kind:

SingleSelectListItem: Profile > Preferences > Language
MultiSelectListItem: Reports (Spend) > Filters > Has
TableListItem: Workspace > Members (long-press to enter multi-select)
UserListItem: Chat "+" > Assign task > Next > Assignee
BareUserListItem: Global "+" > Start Chat
UserSelectionListItem: Search > Filters > From
CardListItem: Search > Filters > Card
InviteMemberListItem: Workspace > Members > Invite member
TravelDomainListItem: Settings > Travel > domain selector (requires travel enabled)
RadioButtons: Settings > Subscription > Cancel > survey
ReportCardLostPage: Settings > Wallet > Expensify Card > Report card lost/damaged
SubscriptionPlanCard: Settings > Subscription > compare plans
Onboarding Accounting page: Onboarding flow > Accounting integration selection
MenuItem with RadioButton: Workspace > Categories > Import spreadsheet > the column header dropdowns

Bugs that caused the recent revert

Account > Wallet > Enable Wallet > Add bank account > Go through Plaid flow > Next button on Choose your bank account page will have left and right spacing.
Workspace settings > Workflows > Payer under Payments section > The selected payer will show radio button on the right side.
(at least two workspaces with per diem rates required) FAB > Create expense > Per diem > Select any workspace > Click RHP back button > The selected workspace will show radio button on the right side.
Navigate to reports page > Tap on dates filter > There is a correct margin between the date filters
Workspace chat. > Create a manual expense. > Open the just created expense. > Click on "More" > "Change Workspace" > radio button is present next to workspaces and that actual workspace has it selected > Select another workspace to move the expense to.
FAB > Create expense > Manual. > Enter amount > Next. > Select a participant. > On confirm page, click To field. > The list will show the participant as selected.
Click search button. > Type anything > Highlight on the selection is not cut off.
Reports (Spend) > Reports > Click Type quick filter. > Click Status quick filter. > Type options will have the same paddings as Status options.

Full testing cases:

Single selection list

For each of the following pages verify:

every item has a radio style button on the right hand side
radio button has dimensions of 20x20px
initially selected item has radio checkmark selected
initially selected item does not have any background highlight
each item which is not disabled is highlighted on mouse hover and the mouse cursor is of pointer style.

Reports

Filter dropdown buttons with popups:
- Filters > type
- Filters > action
- Filters > approved
- Filters > billable
- Filters > date
- Filters > exported
- Filters > paid
- Filters > posted
- Filters > reimbursable
- Filters > submitted
- Filters > withdrawal type
- Filters > withdrawn

Workspace

Overview
- default currency
- company address > country
- company address > state (select country = US to see this option)
- more > transfer owner > currency
Members
- member > role
Reports
- add field > type
- add field > initial value (only for type = list)
Accounting - QBO
- import > classes > displayed as
- import > customers/projects > displayed as
- import > locations > displayed as
- export > preferred exporter
- export > export out-of-pocket expenses as > export as
- export > export out-of-pocket expenses as > account
- export > export company card expenses as > export as
- export > export company card expenses as > account
- export > export company card expenses as > default vendor
- card reconciliation > reconciliation account
Accounting - QBD
- import > classes > displayed as
- import > customers/projects > displayed as
- export > preferred exporter
- export > export date
- export > export out-of-pocket expenses as > export as
- export > export out-of-pocket expense as > account
- export > export invoices to
- export > export company card expenses as > export as
- export > export company card expenses as > credit card account
Accounting - Xero
- xero organization
- import > tracking categories > all map xero [...] to options
- export > preferred exporter
- export > purchase bill date
- export > purchase bill status
- export > xero bank account
- card reconciliation > reconciliation account
- advanced > auto sync > when to export
- advanced > xero bill payment account
- advanced > xero invoice collection account
Accounting - NetSuite
- subsidiary
- import > departments
- import > classes
- import > locations
- import > customers/projects > toggle either of the options > display as
- import > custom segment/records > add custom segment record > do you want to add a custom segment or a custom record - page
- import > custom segment/records > add custom segment record > ... > How should this custom record be displayed in Expensify - page
- import > custom segment/records > item > displayed as
- import > custom lists > add custom list > name
- import > custom lists > add custom list > ... > How should this custom list be displayed in Expensify - page
- import > custom lists > item > displayed as
- export > preferred exporter
- export > export date
- export > export out-of pocket expenses as > export as
- export > export company card expense as > export as
- export > export company card expense as > default vendor
- export > export invoices to
- export > invoice item
- export > invoice item = select existing > invoice item
- export > journal entries tax posting account
- card reconciliation > reconciliation account
- advanced > auto-sync > when to export
- advanced > reimbursement account
- advanced > collection account
- advanced > expense report approval level
- advanced > vendor bill approval level
- advanced > A/P approval level
Accounting - Sage Intacct
- entity
- import > departments > displayed as
- import > classes > displayed as
- import > locations > displayed as
- import > customers > displayed as
- import > projects (jobs) > displayed as
- import > user-defined dimensions > add user-defined dimension
- import > item
- export > preferred exporter
- export > export date
- export > export out-of pocket expenses as > export as
- export > export out-of pocket expenses as > default vendor
- export > export company card expense as > export as
- export > export company card expense as > credit card account
- export > export company card expense as > default vendor
- card reconciliation > reconciliation account
- advanced > auto-sync > when to export
- advanced > sage intacct payment account
Categories
- more > settings > all default category options
- category > approver
- category > default tax rate
- category > flag amount over > type
- category > require receipts over
- more > Import spreadsheet > Choose file > Dropdown buttons with popups
Tags
- tag > approver
Taxes
- more > settings > workspace currency default
- more > settings > foreign currency default
Workflows
- submission frequency (enable delay submissions toggle to see this option)
- workflow > approver (enable add approvals toggle to see this option)
- workflow > additional approver
- payer (enable make or track payments toggle and add a bank account to see this option)
Rules
- cash expense default
- billable default
Distance rates
- settings > unit
- settings > default category
Expensify cards
- issue card > who needs a card
- issue card > choose a limit
- more > settlement account
- more > settlement frequency
- card > limit type
Company cards
- add cards > country
- add cards > select feed type step
- add cards > select feed type step (select direct feed) > who's your bank
- add cards > select feed type step (select commercial feed) > who's your card provider
- card > [accounting software name] credit card export
- select cards feed
- settings > settlement close date
- settings > settlement close date = custom day of month > custom close date
- assign card > who needs a card
- assign card > choose a card
- assign card > choose a transaction start date
Per diem
- more > settings > default category
- rate > currency

Account

Profile
- status > clear after
- status > vacation delegate
- pronounce
- timezone
- date of birth > year
- address > country
- address > state (select country = US to see this option)
Subscription
- add payment card > currency
- request early cancellation
- subscription settings > disable auto renew
- Your plan > Explore all plans
Wallet
- add bank account > country
- add bank account > country (select any other than US) > currency
- Enable Payments > add bank account > Plaid step > choose an account (RadioButtons after Plaid link completes)
- Enable Payments > Idology questions (identity verification multiple-choice;
- click on an Expensify Card > Report card lost or damaged > Why do you need a new card?
Expense rules
- new rule > category
- new rules > tag
- new rule > tax
- new tule > reimbursable
- new rule > billable
Preferences
- priority mode
- language
- payment currency
- theme
Security
- add copilot > select copilot
- add copilot > access level
- copilot > three dot menu > change access level

FAB

Create expense
- manual > currency
- manual > enter amount > choose recipient
- manual > confirmation page > category
- manual > confirmation page > date > year
- manual > confirmation page > tag
- manual > confirmation page > tax
- manual > confirmation page > report
- distance > confirmation page > rate
- per diem > country
- per diem > select country > add time > sub-rate
Create report > choose workspace
Start chat
- room > workspace
- room > who can post
- room > visibility

Chat

Tracked expense
- submit to someone > choose recipient
Workspace expense
- expense item > report field (workspace should have at least one list type report field)
- expense item > category
- expense item > tag
- expense item > tax
- expense item > report
- expense item > rate (for distance expense item only)
- expense report > more > change workspace
- expense report > more > change approver (only workspace admins and owner could see this option)
create task > assignee
task > assignee
room chat
- Room chat > details > settings > notify me about new messages
- details > settings > who can post
- details > settings > visibility
Expense report > details > export (workspace must have an accounting connection; I only managed to access it via url: r/<reportID>/details/export/intacct)
Transaction Merge
- Choose transaction to merge with (radio button on transaction item rows)
- Receipt selection (choose which receipt to keep)
- Field-by-field duplicate resolution (choose value from transaction A vs B for each conflicting field)
Add unreported expense to report

Onboarding

track and budget expenses > name > create workspace > default currency
manage my team > how many employees do you have?
manage my team > 1-10 > do you use any accounting software

Search router (the top right magnifying glass icon)

No selection buttons.
Initially selected item is highlighted.
The highlight is not cut off at any point.

Multi selection

For each of the following pages verify:

Item has a checkbox style button on the right hand side
The checkmark has dimensions of 20x20px
Initially selected items have checkmarks selected
Initially selected items do not have any background highlight
Each item which is not disabled is highlighted on mouse hover and the mouse cursor is of pointer style.

Reports

Filter dropdown buttons
- Filters > from
- Filters > has
- Filters > status
- Filters > to
- Filters > workspace
- Filters > card
- Filters > category
- Filters > currency
- Filters > expense type
- Filters > purchase currency
- Filters > tag
- Filters > tax rate
- Filters > type = chat
- Filters > in
- filters > is
- Filters > type = task
- Filters > assignee
Display dropdown buttons and RHP
- Display > Sort by
- Display > Group by
- Display > Edit columns

Workspace

Overview
- more > invite
Members
- the table of members (for admins, on narrow view after long press > select, no button otherwise)
- invite member
Workflows
- workflow > expense from

FAB

Create expense
manual > confirmation page > Attendees

Onboarding

track and budget expenses > name > create workspace > continue > invite members
manage my team > 1-10 > do you use any accounting software > interested features

No selection button

Workspace > Categories > More > Settings > the list under Default spend categories
Open an expense > More > Split > the split items
IOU > Confirmation Page > To section
Workspace > Receipt partners > Manage invites
Settings > Wallet > Bank account three dot menu
Onboarding > Suggested workspaces to join

Offline tests

N/A

QA Steps

Same as tests.

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Nagranie.z.ekranu.2026-04-21.o.15.56.43.mov

This reverts commit f5d23c4.

…kspaces with per diem rates

… expense

… bank account page

…e row

melvin-bot · 2026-04-03T13:36:12Z

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

codecov · 2026-04-07T08:59:13Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/CONST/index.ts	`92.30% <ø> (ø)`
src/components/AccountSwitcher.tsx	`0.00% <ø> (ø)`
...s/AddPaymentCard/PaymentCardChangeCurrencyForm.tsx	`0.00% <ø> (ø)`
...onents/AddPaymentCard/PaymentCardCurrencyModal.tsx	`0.00% <ø> (ø)`
src/components/ButtonWithDropdownMenu/index.tsx	`89.05% <100.00%> (ø)`
src/components/CategoryPicker/index.tsx	`6.25% <ø> (ø)`
src/components/Checkbox.tsx	`100.00% <100.00%> (+10.34%)`	⬆️
.../components/CountryPicker/CountrySelectorModal.tsx	`0.00% <ø> (ø)`
src/components/CurrencySelectionList/index.tsx	`0.00% <ø> (ø)`
...nts/DatePicker/CalendarPicker/MonthPickerModal.tsx	`76.19% <ø> (ø)`
... and 239 more
... and 188 files with indirect coverage changes

…yle in RadioButton

…nents - Removed the `NEW_CHAT` constant from `src/CONST/index.ts`. - Cleaned up `radioButtonStyle` references in various components, replacing them with consistent styles. - Added `accessible` prop to `Checkbox` and `RadioButton` components for better screen reader support. - Updated several list item components to use `shouldShowRadioButton` instead of `shouldUseDefaultRightHandSideCheckmark` for clarity. - Removed unnecessary props and improved overall code readability across multiple files.

dukenv0307 · 2026-04-22T15:23:58Z

on it now

dukenv0307 · 2026-04-22T15:48:53Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2026-04-22.at.22.46.50.mov

Android: mWeb Chrome

Screen.Recording.2026-04-22.at.22.34.49.mov

iOS: HybridApp

Screen.Recording.2026-04-22.at.22.39.30.mov

iOS: mWeb Safari

Screen.Recording.2026-04-22.at.22.33.09.mov

MacOS: Chrome / Safari

Screen.Recording.2026-04-22.at.22.30.20.mov

…places the removed RadioListItem

github-actions · 2026-04-23T07:57:35Z

🚧 @grgia has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-04-23T08:12:51Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #87087.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-75111f6-0acb232-0b046cedef25ab08a3c142684850c316bb40500f/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-75111f6-0acb232-149158f840c20d8d324df69e7c398cd4eea5213b/index.html

Web 🕸️
https://87087.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

grgia · 2026-04-23T08:58:14Z

QA regression suite requested @mhawryluk https://expensify.slack.com/archives/C09V78U42D8/p1776934666001219

jponikarchuk · 2026-04-23T12:53:08Z

Invoice - Hidden appears on participant list after selecting non-existing email

Version Number: v9.3.61-3 PR:87087
Reproducible in staging?: No
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: Exploratory
Email or phone of affected tester (no customers): sdjinisjoijodsjoidsjnio@gmail.com
Issue reported by: Applause Internal Team
Device used: Mac 26.2 / Chrome

Action Performed:

Precondition:

Enable Invoices in workspace settings.

Go to https://87087.pr-testing.expensify.com/
Open FAB > Send invoice.
Enter amount > Next.
Enter non-existing Gmail account.
Select the user.
On confirm page, click To field.

Expected Result:

Hidden will not appear on participant list.

Actual Result:

Hidden appears on participant list after selecting non-existing email.

Workaround:

Unknown

Platforms:

Screenshots/Videos

Video.mp4

jponikarchuk · 2026-04-23T13:05:29Z

Expense - Non-functional radio button on details selection step when reviewing duplicates

Version Number: v9.3.61-3 PR:87087
Reproducible in staging?: No
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: Exploratory
Email or phone of affected tester (no customers): sdjinisjoijodsjoidsjnio@gmail.com
Issue reported by: Applause Internal Team
Device used: Mac 26.2 / Chrome

Action Performed:

Go to staging.new.expensify.com
Go to workspace chat.
Create two expenses with same amount and merchant., but different category.
Open the report.
Click Review duplicates.
Select any category and proceed to confirm page.
Click RHP back button.

Expected Result:

Radio button should not appear on expense details selection step since it never shows the selection.

Actual Result:

Radio button appears on expense details selection step when it never shows the selection.

Workaround:

Unknown

Platforms:

Screenshots/Videos

Video.mp4

jponikarchuk · 2026-04-23T13:15:20Z

Expense - Hidden and self DM are both selected after selecting self DM

Version Number: v9.3.61-3 PR:87087
Reproducible in staging?: No
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: Exploratory
Email or phone of affected tester (no customers): sdjinisjoijodsjoidsjnio@gmail.com
Issue reported by: Applause Internal Team
Device used: Mac 26.2 / Chrome

Action Performed:

Go to https://87087.pr-testing.expensify.com/
Open FAB > Create expense > Manual.
Enter amount > Next.
On confirm page, click To field.
Select self DM.
Click To field.

Expected Result:

Hidden will not appear after selecting self DM.

Actual Result:

Hidden and self DM are both selected after selecting self DM.

Workaround:

Unknown

Platforms:

Screenshots/Videos

Video.mp4

mitarachim · 2026-04-23T13:32:49Z

Copilot - Radio button never marks copilot as selected

Version Number: v9.3.61-3 PR:87087
Reproducible in staging?: No
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: Exploratory
Email or phone of affected tester (no customers): sdjinisjoijodsjoidsjnio@gmail.com
Issue reported by: Applause Internal Team
Device used: Mac 26.2 / Chrome

Action Performed:

Go to https://87087.pr-testing.expensify.com/
Go to Profile > Security.
Click Add copilot.
Select any user > Next.
Click RHP back button.

Expected Result:

Radio button should mark the user as selected.

Actual Result:

Radio button never marks copilot as selected.

Workaround:

Unknown

Platforms:

Screenshots/Videos

Bug7136619_1776949696502.4.mp4

jponikarchuk · 2026-04-23T13:38:02Z

Copilot - New radio button is not applied in account switcher

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: v9.3.61-3 PR:87087
Reproducible in staging?: No
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: Exploratory
Email or phone of affected tester (no customers): sdjinisjoijodsjoidsjnio@gmail.com
Issue reported by: Applause Internal Team
Device used: Mac 26.2 / Chrome

Action Performed:

Precondition:

User is a copilot of another account.

Go to https://87087.pr-testing.expensify.com/
Go to Account.
Click account switcher.

Expected Result:

The new radio button will be applied in account switcher.

Actual Result:

The new radio button is not applied in account switcher.

Workaround:

Unknown

Platforms:

Screenshots/Videos

mitarachim · 2026-04-23T13:41:31Z

Bank - "Please select an option to proceed" does not have left margin

Version Number: v9.3.61-3 PR:87087
Reproducible in staging?: No
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: Exploratory
Email or phone of affected tester (no customers): applausetester+sdoinsdjoisjd1@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 26.2 / Chrome

Action Performed:

Go to https://87087.pr-testing.expensify.com/
Go to workspace settings > Workflows.
Click Add bank account > Log into your bank.
Complete Plaid flow.
On Choose an account page, click Next button without selecting account.

Expected Result:

"Please select an option to proceed" will have left margin.

Actual Result:

"Please select an option to proceed" does not have left margin.

Workaround:

Unknown

Platforms:

Screenshots/Videos

Bug7136632_1776950409801!Screenshot_2026-04-23_at_21 18 11

Bug7136632_1776950409799.6.mp4

jponikarchuk · 2026-04-23T13:53:58Z

Bank - Radio button in Industry classification code list is never marked

Version Number: v9.3.61-3 PR:87087
Reproducible in staging?: No
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: Exploratory
Email or phone of affected tester (no customers): applausetester+sdoinsdjoisjd@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 26.2 / Chrome

Action Performed:

Go to https://87087.pr-testing.expensify.com/
Go to workspace settings > Workflows.
Click Add bank account > Log into your bank.
Complete Plaid flow.
Proceed to Step 5 - Which industry is the business classified under?
Select any option.

Expected Result:

The radio button in Industry classification code list should be functional, or it should stay hidden because it never appears marked.

Actual Result:

The radio button in Industry classification code list is never marked.

Workaround:

Unknown

Platforms:

Screenshots/Videos

Video.mp4

jponikarchuk · 2026-04-23T14:36:56Z

Workspace Plan - Workspace is created with a default control plan type

Version Number: v9.3.61-3 PR:87087
Reproducible in staging?: No
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: Exploratory
Email or phone of affected tester (no customers): expensify416+da2@gmail.com
Issue reported by: Applause Internal Team
Device used: macOS chrome

Action Performed:

Sign in with a new account
Create a workspace > Change the plan type to Control
Create a second workspace
Open the workspace overview page

Expected Result:

The default plan type should be Collect

Actual Result:

The default plan type for the second workspace is Control

Workaround:

Unknown

Platforms:

Screenshots/Videos

Video.mp4

mitarachim · 2026-04-23T14:52:21Z

Expensify Card - Edit spend rules button is not responsive

Version Number: v9.3.61-3 PR:87087
Reproducible in staging?: No
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: Exploratory
Email or phone of affected tester (no customers): applausetester+sdoinsdjoisjd@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 26.2 / Chrome

Action Performed:

Precondition:

Workspace is set up with Expensify Card feature.
Assign a virtual card to yourself.

Go to https://87087.pr-testing.expensify.com/
Go to workspace settings > Expensify Card.
Click on the card.
Click Edit spend rules.

Expected Result:

Edit spend rules button should be responsive.

Actual Result:

Edit spend rules button is not responsive.

Workaround:

Unknown

Platforms:

Screenshots/Videos

Bug7136674_1776954885320.8.mp4

unzig21 · 2026-04-23T15:07:40Z

Workspace - Selected member is highlighted when focused with keyboard

Version Number: 9.3.61-3 PR:87087
Reproducible in staging?: No
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: Exploratory
Email or phone of affected tester (no customers): negasofonias@gmail.com
Issue reported by: Applause Internal Team
Device used: WIndows 10/Chrome

Action Performed:

Go to a workspace and add few members
Select one of the new memebers
Using keyboard arrow focus on selected member and observe the member is highlighted

Expected Result:

Focused selections should not be highlighted again

Actual Result:

Using keyboard arrow focus on selected member and observe the member is highlighted

Workaround:

Unknown

Platforms:

Screenshots/Videos

Bug7136643_1776951719343.bandicam_2026-04-23_16-30-55-266.mp4

lanitochka17 · 2026-04-23T15:36:09Z

Track Expense - Hidden user is displayed after choosing Submit it to someone

Version Number: v9.3.61-3 PR:87087
Reproducible in staging?: No
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/test-runs/TR-21836/folder/13176877/41237352/1362524681
Email or phone of affected tester (no customers):
Issue reported by: Applause Internal Team
Device used: Mac 26.2 / Chrome

Action Performed:

Create a new account without workspace
Go to self DM
Click on the "+" button next to composer
Create a track expense
Click on the "Submit it to someone" button

Expected Result:

Info message to submit an expense should be displayed in RHP after selecting "Submit it to someone" option.

Actual Result:

A selected hidden user is displayed in RHP when selecting the "Submit it to someone" option.

Workaround:

Unknown

Platforms:

Screenshots/Videos

Bug7136699_1776956996332.ExpensifyHiddenOnRHP.mp4

jponikarchuk · 2026-04-23T16:46:19Z

Radio button displayed but not selected when sharing images

Version Number: v9.3.61-3 PR:87087
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: Exploratory
Email or phone of affected tester (no customers): applausetester+abr883@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Android, IOS

Action Performed:

Open the device Gallery.
Select an image.
Tap Share.
Choose the Expensify app.
Select any user.

Expected Result:

The radio button should either be properly selected or not displayed at all on the share-to-Expensify screen after selecting user

Actual Result:

A radio button is displayed but not selected.

Workaround:

Unknown

Platforms:

Screenshots/Videos

Video.mp4

jponikarchuk · 2026-04-23T16:50:35Z

Company cards - All cards dropdown list is scrollable

Version Number: v9.3.61-3 PR:87087
Reproducible in staging?: No
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: Exploratory
Email or phone of affected tester (no customers): applausetester+sdoinsdjoisjd@applause.expensifail.com
Issue reported by: Applause Internal Team
Bug source: undefined
Device used: Mac 26.2 / Chrome
App Component: undefined

Action Performed:

Precondition:

Add a direct feed on workspace settings > Company cards.

Go to https://87087.pr-testing.expensify.com/
Go to workspace settings > Company cards.
Click All cards dropdown.

Expected Result:

All cards dropdown list should not be scrollable, similar to staging and production.

Actual Result:

All cards dropdown list is scrollable.

Workaround:

Unknown

Platforms:

Screenshots/Videos

Video.mp4

jponikarchuk · 2026-04-23T17:07:03Z

Company cards - "American Express Corporate Cards" is truncated

Version Number: v9.3.61-3 PR:87087
Reproducible in staging?: No
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: Exploratory
Email or phone of affected tester (no customers): sdjinisjoijodsjoidsjnio@gmail.com
Issue reported by: Applause Internal Team
Device used: Mac 26.2 / Chrome

Action Performed:

Go to https://87087.pr-testing.expensify.com/
Go to workspace settings > Company cards.
Click Add cards > Add cards.
Select any country > Next.
Select Commercial feed > Next.

Expected Result:

"American Express Corporate Cards" will not be truncated (or display long name in two lines).

Actual Result:

"American Express Corporate Cards" is truncated.

Workaround:

Unknown

Platforms:

Screenshots/Videos

bandicam.2026-04-23.20-02-11-034.mp4

grgia

@mhawryluk could you check the regression case for Disabled rows with checkboxes. I think the old behavior showed a (disabled) checkbox on disabled invite-list rows when multi-select was on.

jponikarchuk · 2026-04-23T17:26:59Z

Report field - Radio button is not marked, checkmark is shown next to radio button

Version Number: v9.3.61-3 PR:87087
Reproducible in staging?: No
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: Exploratory
Email or phone of affected tester (no customers): applausetester+sdoinsdjoisjd@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 26.2 / Chrome

Action Performed:

Precondition:

Add a list type report field with at least one initial value in workspace settings > Reports.

Go to https://87087.pr-testing.expensify.com/
Go to workspace chat.
Create a report.
Open the report.
Click on the list report field.

Expected Result:

Radio button will be marked as selected.

Actual Result:

Radio button is not marked as selected. Checkmark is shown next to the radio button.

Workaround:

Unknown

Platforms:

Screenshots/Videos

https://github.com/user-attachments/assets/a9f1e658-c684-44d4-add9-4f067e5600c7

jponikarchuk · 2026-04-23T18:42:49Z

Login - #admins room tasks are not displayed after sign in

Version Number: v9.3.61-3 PR:87087
Reproducible in staging?: No
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/folder/13176924/test-cases/41237572
Email or phone of affected tester (no customers): useronboarding@onboarding32321211.com
Issue reported by: Applause Internal Team
Device used: Windows 10 / Chrome, iOS 13 / iPhone 26.3

Action Performed:

Create a new account on NewDot with the following format - useronboarding@onboarding[unique numer].com
Select "Manage my team's expenses"
Select the option of "5-10 employees" and click continue
Select any accounting option (other than none) and continue
Navigate to #admins room if not redirected automatically

Expected Result:

Tasks should be visible in #admins room

Actual Result:

Tasks don't appear in #admins room

Workaround:

Unknown

Platforms:

Screenshots/Videos

Video.mp4

…xt to radio button

zfurtak and others added 16 commits April 1, 2026 11:23

Revert "Revert "Enhance icons UI consistency""

e3a085a

This reverts commit f5d23c4.

Fix padding in reports filter

44c26a3

fix: Search - Highlight is cut off

dc9a307

Remove initial focused highlight in CurrencySelectionList

39b8d2f

fix: Workflows - Missing checkmark on the selected payer

cabfff5

fix: Per diem - No checkmark on selected workspace when there are wor…

1361d6e

…kspaces with per diem rates

fix: Reports - No margin for dates filters

a6ab1ca

fix: Expense - No radio button present while changing workspace of an…

3f4f048

… expense

fix: Expense - Radio button is present but is never checkmarked

f63a4e2

fix: Wallet - No left and right spacing on Next button on Choose your…

563b52f

… bank account page

Remove some style prop array nesting

9fddfcc

Add radio buttons to missing selection lists

3b6cd98

Make shouldShowRadioButton default to true in UserListItem

f4d4497

Keep initiallyFocusedItemKeys functionalities without highlighting th…

0dfe1f0

…e row

Migrate remaining RadioListItem lists to SingleSelectListItem

b4bd74b

Rename RadioListItem to BaseSelectListItem and disallow its direct usage

5b1ab70

melvin-bot Bot assigned mhawryluk Apr 3, 2026

Merge branch 'main' into @zfurtak/reapply-ui-consistency

2e49c1d

mhawryluk added 10 commits April 7, 2026 12:07

Fixes after merge

c1d23b7

Merge branch 'main' into @zfurtak/reapply-ui-consistency

8375cae

Replace SelectionCheckbox with SelectionButton, remove shouldUseNewSt…

90c1964

…yle in RadioButton

Use RadioButton in OptionItem instead of SelectionButton

3214c5b

Remove SelectCircle usage in SubscriptionPlanCard

5dea842

Remove SelectCircle and SingleOptionSelector components

b6bc682

FIx no sentry label issues

aa72cd3

Migrate ImportColumn (MenuItem) to use the new radio buttons

ccf9d32

Merge branch 'main' into @zfurtak/reapply-ui-consistency

83f1195

dukenv0307 approved these changes Apr 22, 2026

View reviewed changes

mhawryluk added 2 commits April 23, 2026 09:41

Merge branch 'main' into @zfurtak/reapply-ui-consistency

b266b1b

Update SingleSelectListItem component documentation to indicate it re…

75111f6

…places the removed RadioListItem

Fix showing icons in ReportDetailsExportPage list items

4cedad1

Migrate AccountSwitcher to use the new radio buttons

8e0134d

grgia reviewed Apr 23, 2026

View reviewed changes

mhawryluk added 3 commits April 24, 2026 13:05

fix: Report field - Radio button is not marked, checkmark is shown ne…

77b7237

…xt to radio button

fix: ReportDetailsExportPage left debug code

737773c

fix: Copilot - Radio button never marks copilot as selected

98c7673

Conversation

mhawryluk commented Apr 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Simplified testing cases to test one example of each kind:

Bugs that caused the recent revert

Single selection list

Reports

Workspace

Account

FAB

Chat

Onboarding

Search router (the top right magnifying glass icon)

Multi selection

Reports

Workspace

FAB

Onboarding

No selection button

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Apr 3, 2026

Uh oh!

codecov Bot commented Apr 7, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

dukenv0307 commented Apr 22, 2026

Uh oh!

dukenv0307 commented Apr 22, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

github-actions Bot commented Apr 23, 2026

Uh oh!

github-actions Bot commented Apr 23, 2026

Uh oh!

grgia commented Apr 23, 2026

Uh oh!

jponikarchuk commented Apr 23, 2026

Invoice - Hidden appears on participant list after selecting non-existing email

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Uh oh!

jponikarchuk commented Apr 23, 2026

Expense - Non-functional radio button on details selection step when reviewing duplicates

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Uh oh!

jponikarchuk commented Apr 23, 2026

Expense - Hidden and self DM are both selected after selecting self DM

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Uh oh!

mitarachim commented Apr 23, 2026

Copilot - Radio button never marks copilot as selected

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

mhawryluk commented Apr 3, 2026 •

edited

Loading

codecov Bot commented Apr 7, 2026 •

edited by github-actions Bot

Loading

lanitochka17 commented Apr 23, 2026 •

edited

Loading