Use dekstop layout for header buttons in landscape mode#87256
Use dekstop layout for header buttons in landscape mode#87256GCyganek wants to merge 11 commits intoExpensify:mainfrom
Conversation
|
@codex review |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: db7ee6a20b
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@codex review |
|
Codex Review: Didn't find any major issues. Chef's kiss. ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
|
@Expensify/design please take a look at this 🙏 |
|
Love it! |
Explanation of Change
Landscape uses the wide header buttons (as on desktop web) pattern via
shouldDisplayNarrowHeaderButton = isInLandscapeMode || !shouldUseNarrowLayouton mobileAlso making sure that EarlyDiscountBanner button is displayed on the right in landscape mode
Fixed Issues
$ #77280
PROPOSAL: N/A
Tests
Open any expense report in landscape mode
Verify that the header buttons are displayed in the top-right corner as on desktop, not below the header
Open any expense
Verify that the header buttons are displayed in the top-right corner as on desktop, not below the header
Open any domain in landsacpe mode
Go to Domain members
Verify that the header buttons are displayed in the top-right corner as on desktop, not below the header
Long tap any of the members to go into selection mode
Verify that the selection button is displayed in the top-right corner as on desktop, not below the header
Go back and to Domain admins
Verify that the header buttons are displayed in the top-right corner as on desktop, not below the header
Go to Account > Expense rules in landscape mode
Verify that the header buttons are displayed in the top-right corner as on desktop, not below the header
Add a few rules
Long tap one of the rules and tap Select to go into selection mode
Verify that the Selection button is displayed in the top-right corner as on desktop, not below the header
Prerequisites: Distance rates with at least one distance rate, Tags, Taxes, Per diem enabled with rates imported, workspace with multi-level Tags imported
Prerequisites: Workspace with issued Expensify Cards
Open Workspaces > your workspace > Expensify Cards in landscape mode
Verify that the header buttons are displayed in the top-right corner as on desktop, not below the header
In landscape mode - Workspaces > your workspace > Tags
Add a simple tag
Verify that the header buttons are displayed in the top-right corner as on desktop, not below the header
Long tap the tag and tap Select to go into selection mode
Verify that the selection button is displayed in the top-right corner as on desktop, not below the header
Open Workspaces in landscape mode
Verify that the "New" header button is displayed in the top-right corner as on desktop, not below the header
Workspaces > your workspace > Reports in landscape mode
Tap Add field
Add a field with "List" type, add List values and pick Initial value
Tap on the added field
Tap on List values row
Verify that the header buttons are displayed in the top-right corner as on desktop, not below the header
Long tap the tag and tap Select to go into selection mode
Verify that the selection button is displayed in the top-right corner as on desktop, not below the header
Offline tests
N/A
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2026-04-17.at.17.19.45.mov
Screen.Recording.2026-04-17.at.15.18.35.mov
Screen.Recording.2026-04-17.at.17.13.41.mov
Screen.Recording.2026-04-17.at.17.15.24.mov
Screen.Recording.2026-04-17.at.17.16.05.mov
Screen.Recording.2026-04-17.at.17.16.43.mov
Screen.Recording.2026-04-17.at.17.17.55.mov
iOS: Native
Screen.Recording.2026-04-17.at.17.22.56.mov
Screen.Recording.2026-04-17.at.17.23.40.mov
Uploading Screen Recording 2026-04-17 at 17.26.06.mov…
Screen.Recording.2026-04-17.at.17.24.14.mov
Screen.Recording.2026-04-17.at.17.24.54.mov