Fix Zoom green dot slider is not fully visible and functioning in landscape#87613
Conversation
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
No new product considerations - removing my assignment and unsubscribing. |
|
@GCyganek Could you merge main? |
done |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2026-04-20.at.15.59.50.movAndroid: mWeb ChromeiOS: HybridAppScreen.Recording.2026-04-20.at.16.02.17.moviOS: mWeb SafariMacOS: Chrome / Safari |
|
@GCyganek It looks like the image and the slider track are not properly center-aligned.
|
|
@truph01 hmmm I don't see it, can you tell me where exactly? I drew some line and it looks centered:
|
|
@GCyganek Coud you check it? The left space is greater than the right one:
|
Yeah I see, but from what I understand, looking at the code, the photo was not meant to be centered relative to the slider itself, but relative to the container with the slider and rotate button. If it was centered relative to the slider it would 've been moved a bit off the center of the screen to the left and I don't think we want that. Additionally as you can see in the changes - I only added min width to the container with the slider and rotate button, nothing else, so it was already like that. But in case you want to make sure this is correct feel free to ping the design team 😄 |
Ah, that sounds good. So I think we don't need to make more changes. |
|
🚧 @mjasikowski has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/mjasikowski in version: 9.3.61-0 🚀
Bundle Size Analysis (Sentry): |
|
No help site changes are required for this PR. This PR is a purely visual bug fix that sets a minimum width on the zoom slider container in |




Explanation of Change
Fixing zoom green dot slider by setting min width of the slider container to 300px in landscape mode
Fixed Issues
$ #87370
PROPOSAL: N/A
Tests
Offline tests
N/A
QA Steps
Same as Tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2026-04-10.at.14.07.05.mov
iOS: Native
Screen.Recording.2026-04-10.at.14.12.29.mov