Skip to content

Fix Zoom green dot slider is not fully visible and functioning in landscape #87613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mjasikowski merged 2 commits into from
Apr 20, 2026
+13 −1
Merged

Fix Zoom green dot slider is not fully visible and functioning in landscape #87613

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
74b8596
Fix Zoom green dot slider is not fully visible and functioning in lan…
GCyganek Apr 10, 2026
94fcff1
Merge branch 'main' into @GCyganek/landscape-mode/avatar-edit-slider
GCyganek Apr 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion src/components/AvatarCropModal/AvatarCropModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ import PressableWithoutFeedback from '@components/Pressable/PressableWithoutFeed
import ScreenWrapper from '@components/ScreenWrapper';
import Text from '@components/Text';
import Tooltip from '@components/Tooltip';
import useIsInLandscapeMode from '@hooks/useIsInLandscapeMode';
import {useMemoizedLazyExpensifyIcons} from '@hooks/useLazyAsset';
import useLocalize from '@hooks/useLocalize';
import useStyleUtils from '@hooks/useStyleUtils';
Expand Down Expand Up @@ -54,12 +55,15 @@ type AvatarCropModalProps = {
buttonLabel?: string;
};

const LANDSCAPE_MODE_SLIDER_CONTAINER_MIN_WIDTH = 300;

// This component can't be written using class since reanimated API uses hooks.
function AvatarCropModal({imageUri = '', imageName = '', imageType = '', onClose, onSave, isVisible, maskImage, buttonLabel}: AvatarCropModalProps) {
const theme = useTheme();
const styles = useThemeStyles();
const StyleUtils = useStyleUtils();
const expensifyIcons = useMemoizedLazyExpensifyIcons(['Rotate', 'Zoom']);
const isInLandscapeMode = useIsInLandscapeMode();

const originalImageWidth = useSharedValue<number>(CONST.AVATAR_CROP_MODAL.INITIAL_SIZE);
const originalImageHeight = useSharedValue<number>(CONST.AVATAR_CROP_MODAL.INITIAL_SIZE);
Expand Down Expand Up @@ -407,7 +411,15 @@ function AvatarCropModal({imageUri = '', imageName = '', imageType = '', onClose
rotation={rotation}
maskImage={maskImage}
/>
<View style={[styles.mt5, styles.justifyContentBetween, styles.alignItemsCenter, styles.flexRow, StyleUtils.getWidthStyle(imageContainerSize)]}>
<View
style={[
styles.mt5,
styles.justifyContentBetween,
styles.alignItemsCenter,
styles.flexRow,
StyleUtils.getWidthStyle(isInLandscapeMode ? Math.max(imageContainerSize, LANDSCAPE_MODE_SLIDER_CONTAINER_MIN_WIDTH) : imageContainerSize),
]}
>
<Icon
src={expensifyIcons.Zoom}
fill={theme.icon}
Expand Down
Loading