Fix blank VerticalCreditCards icon on native Wallet page#87723
Fix blank VerticalCreditCards icon on native Wallet page#87723chuckdries merged 6 commits intomainfrom
Conversation
The VerticalCreditCards illustration on the Wallet page renders blank on native apps because MenuItem applies a theme tint color by default, which overrides the SVG's multi-color CSS fills. Adding displayInDefaultIconColor prevents the tint from being applied, allowing the illustration to render with its original colors on native platforms. Co-authored-by: parasharrajat <parasharrajat@users.noreply.github.com>
Screenshots🔲 iOS / native
🔲 iOS / Safari
🔲 MacOS / Chrome
🔲 Android / Chrome🔲 Android / native
|
|
@MelvinBot Mark it ready for review. |
|
Done — PR has been marked as ready for review. ✅ |
melvin-bot
Bot
requested review from
JmillsExpensify and
parasharrajat
and removed request for
a team
|
@parasharrajat Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
parasharrajat
left a comment
parasharrajat
left a comment
There was a problem hiding this comment.
Reviewer Checklist
- I have verified the author checklist is complete (all boxes are checked off).
- I verified the correct issue is linked in the
### Fixed Issuessection above - I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the
Testssection - I verified the steps for Staging and/or Production testing are in the
QA stepssection - I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I verified the steps for local testing are in the
- I checked that screenshots or videos are included for tests on all platforms
- I included screenshots or videos for tests on all platforms
- I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
- I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
- I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e.
toggleReportand notonIconClick). - I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to
src/languages/*files and using the translation method - I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in
STYLE.md) were followed
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e.
- If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
- I verified that this PR follows the guidelines as stated in the Review Guidelines
- I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like
Avatar, I verified the components usingAvatarhave been tested & I retested again) - I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
- I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
- If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a
/** comment above it */ - The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to
thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor) - Any internal methods bound to
thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick) - All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
- If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
- If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e.
StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
- If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
- If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like
Avataris modified, I verified thatAvataris working as expected in all cases) - If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
- If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
- If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added
Designlabel and/or tagged@Expensify/designso the design team can review the changes.
- If a new page is added, I verified it's using the
ScrollViewcomponent to make it scrollable when more elements are added to the page. - For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
- If the
mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps. - I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.
🎀 👀 🎀 C+ reviewed
|
We did not find an internal engineer to review this PR, trying to assign a random engineer to #87665 as well as to this PR... Please reach out for help on Slack if no one gets assigned! |
|
@shawnborton should we just change this design now? Aren't we going to a non-highlight row? cc @Expensify/design |
JmillsExpensify
left a comment
JmillsExpensify
left a comment
There was a problem hiding this comment.
Aside from that, this PR looks good to me.
|
Agree the PR looks good, but we should probably just take this opportunity to update this row if we can. I think the idea is to make it use the regular background color and contain it inside the card the same way a normal row is. cc @shawnborton to provide the exact guidance, but I believe that's what I remember him mentioning in Slack. |
|
Yes! It feels a bit odd to me that we have a gap between the first two menuItem rows there, and then the last item using the full background color just feels a bit off. My thinking was to basically just treat all rows the same, with 0px gap between them, and use standard card padding below. Basically this: Would love to implement that here if we can. cc @parasharrajat |
|
@MelvinBot Move the MenuItem for the verticalCreditCards with the other menu items in that section. Remove the special background color and Match the same style as other. Keep the padding below on the section for this as well. |
Remove the special background color and custom icon sizing from the company cards MenuItem. Wrap it in a View with the same negative margin and padding styles as the other MenuItems in the section. Remove centralPaneContainerStyle that zeroed out bottom padding when no cards were assigned. Co-authored-by: parasharrajat <parasharrajat@users.noreply.github.com>
|
@parasharrajat Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
Done — pushed 6b6f06a. Changes:
|
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
The failing Failure: Render count regression in Why it's unrelated: This PR only modifies This is a pre-existing or flaky perf regression on |
|
Done — pushed 143436c:
|
|
MelvinBot has made 5 consecutive commits trying to fix CI failures. Automatic CI fix dispatches are now paused for this PR. Next steps: A human should review the recent commits and resolve the conflicting CI errors manually. |
|
Fixed @shawnborton |
|
Screenshot? |
|
|
Nice, let's just check the hover states to make sure all of those rows are touching with no gaps in between. |
|
yes, checked that. Looks good. |
14.04.2026_12.59.48_REC.mp4 |
|
All yours @chuckdries |
|
Nice! And how does mobile look? |
|
Here it is @shawnborton 14.04.2026_14.03.00_REC.mp4 |
|
Sweet, ship it! |
|
Nice! Looking gooooood 👍 |
|
@parasharrajat can you look into why perf-tests are failing? |
|
@chuckdries try to retry that. |
|
@parasharrajat They failed with the same issue 3 times in a row |
|
@MelvinBot merge main. |
…CardIcon Co-authored-by: parasharrajat <parasharrajat@users.noreply.github.com>
|
Merged main into this branch and pushed. ✅ |
|
All set @chuckdries |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚧 @chuckdries has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/chuckdries in version: 9.3.60-0 🚀
Bundle Size Analysis (Sentry): |
|
No help site changes are required for this PR. This is a visual rendering bug fix that corrects how the |
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.3.60-22 🚀
|
7 participants
Explanation of Change
The
VerticalCreditCardsillustration on the Wallet page renders blank on native apps (Android/iOS) becauseMenuItemapplies a theme tint color (fill/tintColor) by default, which overrides the SVG's multi-color CSS-based fills. On web, CSS<style>classes take precedence, so it displays correctly — but native SVG decoders don't process CSS class-based fills, and the forced tint makes the paths invisible.Adding
displayInDefaultIconColorto the MenuItem prevents it from injecting a theme fill color, allowing the illustration to render with its original multi-color SVG fills on native platforms.Fixed Issues
$ #87665
PROPOSAL: #87665 (comment)
Tests
Offline tests
N/A — This is a visual rendering fix for a static illustration. No network dependency.
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari