fix: App blinks when Attachment error modal shows up by nkdengineer · Pull Request #87848 · Expensify/App

nkdengineer · 2026-04-14T08:57:29Z

Explanation of Change

fix: App blinks when Attachment error modal shows up

Fixed Issues

$ #87605
PROPOSAL: #87605 (comment)

Tests

Open any chat.
Upload an image with size larger than the limit (attached below).
Verify that the App doesn't blink when the error modal shows up

Verify that no errors appear in the JS console

Offline tests

Same

QA Steps

Same as test

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2026-04-14.at.15.52.21.mov

Android: mWeb Chrome

Screen.Recording.2026-04-14.at.15.52.57.mov

iOS: Native

Screen.Recording.2026-04-14.at.15.49.51.mov

iOS: mWeb Safari

Screen.Recording.2026-04-14.at.15.51.45.mov

MacOS: Chrome / Safari

Screen.Recording.2026-04-14.at.15.48.15.mov

codecov · 2026-04-14T09:06:13Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/hooks/useFilesValidation.tsx	`28.75% <33.33%> (+3.03%)`	⬆️
... and 13 files with indirect coverage changes

melvin-bot · 2026-04-14T10:15:54Z

@dukenv0307 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

dukenv0307 · 2026-04-14T11:18:12Z

@nkdengineer pls fix the issues above. Thanks

nkdengineer · 2026-04-16T06:35:04Z

@dukenv0307 I updated.

dukenv0307 · 2026-04-16T08:31:48Z

Should we clearTimeout in useEffect cleanup function?

dukenv0307 · 2026-04-16T08:31:58Z

@codex review

chatgpt-codex-connector · 2026-04-16T08:40:26Z

Codex Review: Didn't find any major issues. More of your lovely PRs please.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

nkdengineer · 2026-04-16T08:46:37Z

@dukenv0307 I updated.

dukenv0307 · 2026-04-16T09:47:39Z

+
+            loaderTimeoutRef.current = setTimeout(() => {
+                hideLoaderAndHandleNext();
+            }, MIN_LOADER_VISIBLE_DURATION_MS - elapsedTime);


@dangrous can you please confirm if the value of 200 for MIN_LOADER_VISIBLE_DURATION_MS is enough?

Screen.Recording.2026-04-16.at.16.44.35.mov

dangrous · 2026-04-17T14:35:07Z

I defer to @Expensify/design on this one, to me I think maybe a little longer might be better, even 500 ms? But they'll have a good eye for it.

Basically we're artificially lengthening the loader when an image is too large to be processed, so it doesn't "flash" really quickly which looks worse than a longer load.

dannymcclain · 2026-04-17T15:15:56Z

I think the videos in the issue description seem fine to me. cc @Expensify/design for more thoughts.

But if we know the image is too big, why do we even show the loader at all? Couldn't we just pop the modal straight away?

nkdengineer · 2026-04-22T03:46:54Z

@dannymcclain The dimensions is checking in the resize process so we don't know about this before and always show the loading before process the resize logic.

dukenv0307 · 2026-04-22T16:42:47Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2026-04-22.at.23.42.05.mov

Android: mWeb Chrome

Screen.Recording.2026-04-22.at.23.31.42.mov

iOS: HybridApp

Screen.Recording.2026-04-22.at.23.36.47.mov

iOS: mWeb Safari

Screen.Recording.2026-04-22.at.23.29.41.mov

MacOS: Chrome / Safari

Screen.Recording.2026-04-22.at.23.27.34.mov

dukenv0307 · 2026-04-22T16:45:56Z

@dannymcclain can you please check my videos above to confirm they're correct? Thanks

dannymcclain · 2026-04-22T20:26:18Z

Feels pretty good to me 👍

cc @Expensify/design too

dubielzyk-expensify · 2026-04-23T00:46:57Z

Yeah feeling better for sure 👍

fix: App blinks when Attachment error modal shows up

c4f623a

melvin-bot Bot assigned nkdengineer Apr 14, 2026

nkdengineer marked this pull request as ready for review April 14, 2026 10:15

nkdengineer requested review from a team as code owners April 14, 2026 10:15

melvin-bot Bot requested review from JmillsExpensify and dukenv0307 and removed request for a team and JmillsExpensify April 14, 2026 10:15

melvin-bot Bot removed the request for review from a team April 14, 2026 10:15

github-actions Bot reviewed Apr 14, 2026

View reviewed changes

Comment thread src/hooks/useFilesValidation.tsx

github-actions Bot reviewed Apr 14, 2026

View reviewed changes

Comment thread src/hooks/useFilesValidation.tsx Outdated

nkdengineer added 2 commits April 16, 2026 13:29

Merge branch 'main' into fix/87605

e53f700

refactor code

3f8c27b

dukenv0307 reviewed Apr 16, 2026

View reviewed changes

Comment thread src/hooks/useFilesValidation.tsx

cleanup timeout when unmount

5fd7988

dukenv0307 reviewed Apr 16, 2026

View reviewed changes

dukenv0307 approved these changes Apr 22, 2026

View reviewed changes

melvin-bot Bot requested a review from dangrous April 22, 2026 16:43

dukenv0307 approved these changes Apr 22, 2026

View reviewed changes

Conversation

nkdengineer commented Apr 14, 2026

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov Bot commented Apr 14, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot Bot commented Apr 14, 2026

Uh oh!

Uh oh!

Uh oh!

dukenv0307 commented Apr 14, 2026

Uh oh!

nkdengineer commented Apr 16, 2026

Uh oh!

Uh oh!

dukenv0307 commented Apr 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dukenv0307 commented Apr 16, 2026

Uh oh!

chatgpt-codex-connector Bot commented Apr 16, 2026

Uh oh!

nkdengineer commented Apr 16, 2026

Uh oh!

dukenv0307 Apr 16, 2026

Choose a reason for hiding this comment

Uh oh!

dangrous commented Apr 17, 2026

Uh oh!

dannymcclain commented Apr 17, 2026

Uh oh!

nkdengineer commented Apr 22, 2026

Uh oh!

dukenv0307 commented Apr 22, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

dukenv0307 commented Apr 22, 2026

Uh oh!

dannymcclain commented Apr 22, 2026

Uh oh!

dubielzyk-expensify commented Apr 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

codecov Bot commented Apr 14, 2026 •

edited by github-actions Bot

Loading

dukenv0307 commented Apr 16, 2026 •

edited

Loading