Allow submitters to see admin-dismissed duplicate violations#87897
Draft
Allow submitters to see admin-dismissed duplicate violations#87897
Conversation
…reports When an admin dismisses duplicate transaction violations via "Keep all", the dismissal is recorded under the admin's email. The submitter's client previously had no reciprocal check to see that dismissal, causing the duplicate review UI to persist. Add a check so that when the submitter views their own open expense report, any existing dismissal (by admin or approver) is recognized. Co-authored-by: Abdelrahman Khattab <abzokhattab@users.noreply.github.com>
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
When an admin resolves duplicate transaction violations via "Keep all", the dismissal is recorded under the admin's email. The employee/submitter's client had no reciprocal check to recognize that dismissal, so the duplicate review UI (RBR + "Review Duplicates" button) persisted on the employee side.
This adds a check in
isViolationDismissedso that when the submitter views their own open expense report and anyone (admin/approver) has already dismissed the violation, it returnstrue— mirroring the existing admin-side logic that checks for submitter dismissals.Fixed Issues
$ #86715
PROPOSAL: #86715 (comment)
AI Tests
TransactionUtilsTest.ts— 256 tests passed, 0 failedtruewhen submitter views open report with admin-dismissed violationfalse(correct boundary)typecheck-tsgo): passedHuman Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.
QA
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
Suggested QA steps:
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.