Skip to content

Sage Intacct - Add Travel Invoicing vendor & payable account selectors#88483

Open
brunovjk wants to merge 27 commits into
Expensify:mainfrom
brunovjk:fix/88269-sage-intacct-travel-invoicing
Open

Sage Intacct - Add Travel Invoicing vendor & payable account selectors#88483
brunovjk wants to merge 27 commits into
Expensify:mainfrom
brunovjk:fix/88269-sage-intacct-travel-invoicing

Conversation

@brunovjk
Copy link
Copy Markdown
Contributor

@brunovjk brunovjk commented Apr 21, 2026

Explanation of Change

Adds the Travel Invoicing configuration section to the Sage Intacct accounting export settings, mirroring the existing QuickBooks Online behavior. The new section is only shown when Travel Invoicing is enabled for the workspace and lets admins select a Travel vendor and a Travel payable account, with optimistic updates and standard error/pending handling.

Fixed Issues

$ #88269
PROPOSAL:

Tests

Preconditions

  • Workspace has Sage Intacct accounting integration enabled
  • Travel Invoicing beta and the feature should both be enabled (Central Invoicing ON)

1. Verify Section Rendering

Objective: Ensure the "Travel Invoicing" section renders only when the feature is enabled.

Steps:

  1. Navigate to the workspace Sage Intacct accounting integration settings page and click on Export menu item.
  2. Case A: Travel Invoicing disabled
    • Verify the "Travel Invoicing" menu item does not appear in the Export RHP.
  3. Case B: Travel Invoicing enabled
    • Verify the "Travel Invoicing" menu item appears in the Export RHP.
    • Click on "Travel Invoicing" and verify two rows are visible in the RHP:
      • "Travel vendor"
      • "Travel payable account"

2. Verify Selection Interaction

Objective: Ensure each row is selectable and opens the correct picker.

Steps:

  1. Click the "Travel vendor" row.
    • Verify it navigates to a searchable picker (SelectionList) showing available vendors.
  2. Click the "Travel payable account" row.
    • Verify it navigates to a searchable picker (SelectionList) showing available payable accounts.

3. Verify Updating Vendor/Account

Objective: Ensure selection updates the integration config via the backend.

Steps:

  1. In the vendor picker, select a new vendor.
  2. Verify the "Travel vendor" row now shows the newly selected vendor.
  3. In the payable account picker, select a new payable account.
  4. Verify the "Travel payable account" row now shows the newly selected payable account.
  • Verify that no errors appear in the JS console

Offline tests

  1. Disable network (app is offline).
  2. Tap Travel vendor and select a different vendor.
  3. Verify the selection is applied optimistically (you return to the Travel Invoicing configuration page) and the row shows a pending state (OfflineWithFeedback).
  4. Re-enable network (go back online).
  5. Verify the pending state clears and the selected vendor remains.
  6. Repeat steps 1-6 for Travel payable account.

QA Steps

Same as tests

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
88483_android_web.mov
Android: mWeb Chrome
88483_android_web.mov
iOS: Native
88483_ios_native.mov
iOS: mWeb Safari
88483_ios_web.mov
MacOS: Chrome / Safari
Screen.Recording.2026-04-22.at.12.06.36.mov

@melvin-bot
Copy link
Copy Markdown

melvin-bot Bot commented Apr 21, 2026

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

  1. Look at the code and make sure there are no malicious changes.
  2. Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

@brunovjk brunovjk changed the title Sage Intacct - Add Travel Invoicing vendor & payable account selectors [WIP] Sage Intacct - Add Travel Invoicing vendor & payable account selectors Apr 21, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 21, 2026

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
src/CONST/index.ts 92.30% <ø> (ø)
src/ROUTES.ts 17.20% <ø> (-0.07%) ⬇️
src/SCREENS.ts 100.00% <ø> (ø)
...gation/linkingConfig/RELATIONS/WORKSPACE_TO_RHP.ts 100.00% <ø> (ø)
src/libs/Navigation/linkingConfig/config.ts 76.92% <ø> (ø)
src/libs/actions/connections/SageIntacct.ts 6.21% <100.00%> (+6.21%) ⬆️
...gation/AppNavigator/ModalStackNavigators/index.tsx 7.13% <0.00%> (-0.03%) ⬇️
...etSuiteTravelInvoicingPayableAccountSelectPage.tsx 0.00% <0.00%> (ø)
.../export/QuickbooksExportTravelVendorSelectPage.tsx 0.00% <0.00%> (ø)
...QuickbooksExportTravelPayableAccountSelectPage.tsx 0.00% <0.00%> (ø)
... and 5 more
... and 18 files with indirect coverage changes

@brunovjk brunovjk marked this pull request as ready for review April 23, 2026 00:05
@brunovjk brunovjk requested review from a team as code owners April 23, 2026 00:05
@melvin-bot melvin-bot Bot requested review from parasharrajat and trjExpensify and removed request for a team April 23, 2026 00:05
@melvin-bot
Copy link
Copy Markdown

melvin-bot Bot commented Apr 23, 2026

@parasharrajat Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot Bot removed the request for review from a team April 23, 2026 00:05
@brunovjk brunovjk changed the title [WIP] Sage Intacct - Add Travel Invoicing vendor & payable account selectors Sage Intacct - Add Travel Invoicing vendor & payable account selectors Apr 23, 2026
Copy link
Copy Markdown
Contributor

@trjExpensify trjExpensify left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@heyjennahay confirming you're happy with this?

@brunovjk
Copy link
Copy Markdown
Contributor Author

brunovjk commented May 4, 2026

@brunovjk lint is failing

@rlinoz I don't think is related to our PR. I will check again in a moment

Copy link
Copy Markdown
Contributor

@blimpich blimpich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brunovjk can we update this PR based of these new requirements?

@brunovjk
Copy link
Copy Markdown
Contributor Author

brunovjk commented May 5, 2026

I made the requested changes @parasharrajat, @ishpaul777, and @blimpich. Could you please take a look?

Screen.Recording.2026-05-05.at.12.35.57.mov

I still need to confirm the translations. Thank you very much.

@blimpich
Copy link
Copy Markdown
Contributor

blimpich commented May 5, 2026

@brunovjk looks great! Thank you!

@ishpaul777 @parasharrajat can you please re-review?

@blimpich
Copy link
Copy Markdown
Contributor

blimpich commented May 5, 2026

@brunovjk can you please link to where you requested translation confirmation?

Comment thread src/types/onyx/Policy.ts Outdated
Comment thread src/CONST/index.ts Outdated
Comment thread src/libs/actions/connections/SageIntacct.ts Outdated
@brunovjk
Copy link
Copy Markdown
Contributor Author

brunovjk commented May 6, 2026

@brunovjk can you please link to where you requested translation confirmation?

Sorry @blimpich, I missed that, but here's the link to confirm the translation.

@brunovjk
Copy link
Copy Markdown
Contributor Author

brunovjk commented May 6, 2026

Thank you for noticing the remnants of VENDOR @ishpaul777. Could you please take a look? Thank you very much.

@blimpich blimpich requested a review from ishpaul777 May 6, 2026 16:23
@parasharrajat
Copy link
Copy Markdown
Member

Thanks. I will check.

Comment on lines +64 to +72
? [
{
title: translate(`workspace.sageIntacct.nonReimbursableExpenses.values.${CONST.SAGE_INTACCT_NON_REIMBURSABLE_EXPENSE_TYPE.CREDIT_CARD_CHARGE}`),
description: translate('workspace.common.travelInvoicing'),
action: !policyID ? undefined : () => Navigation.navigate(createDynamicRoute(DYNAMIC_ROUTES.POLICY_ACCOUNTING_SAGE_INTACCT_TRAVEL_INVOICING_CONFIGURATION.path)),
subscribedSettings: [CONST.SAGE_INTACCT_CONFIG.TRAVEL_INVOICING_PAYABLE_ACCOUNT],
},
]
: []),
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this "Export Expensify Travel Payable To"  be the selected account name not "Credit cards"

https://expensify.slack.com/archives/C05S5EV2JTX/p1778178740197289?thread_ts=1778175591.776559&cid=C05S5EV2JTX

@brunovjk
Copy link
Copy Markdown
Contributor Author

brunovjk commented May 8, 2026

this "Export Expensify Travel Payable To" be the selected account name not "Credit cards"

Done:

Screen.Recording.2026-05-08.at.11.14.41.mov

What do you think @ishpaul777 @blimpich @parasharrajat? Do you think we should set a fallback/default if no account is selected? I believe we don’t need one, but I’d like to confirm. Thanks!

@blimpich blimpich requested a review from ishpaul777 May 11, 2026 17:10
@blimpich
Copy link
Copy Markdown
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants