Sage Intacct - Add Travel Invoicing vendor & payable account selectors#88483
Sage Intacct - Add Travel Invoicing vendor & payable account selectors#88483brunovjk wants to merge 27 commits into
Conversation
…xport + intacct.data)
|
Hey, I noticed you changed If you want to automatically generate translations for other locales, an Expensify employee will have to:
Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running: npx ts-node ./scripts/generateTranslations.ts --helpTypically, you'd want to translate only what you changed by running |
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
This reverts commit 94a92ba.
…kspace.common and Run Prettier
|
@parasharrajat Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
trjExpensify
left a comment
There was a problem hiding this comment.
@heyjennahay confirming you're happy with this?
blimpich
left a comment
There was a problem hiding this comment.
@brunovjk can we update this PR based of these new requirements?
|
I made the requested changes @parasharrajat, @ishpaul777, and @blimpich. Could you please take a look? Screen.Recording.2026-05-05.at.12.35.57.movI still need to confirm the translations. Thank you very much. |
|
@brunovjk looks great! Thank you! @ishpaul777 @parasharrajat can you please re-review? |
|
@brunovjk can you please link to where you requested translation confirmation? |
Co-authored-by: Ishpaul Singh <104348397+ishpaul777@users.noreply.github.com>
Sorry @blimpich, I missed that, but here's the link to confirm the translation. |
|
Thank you for noticing the remnants of |
|
Thanks. I will check. |
| ? [ | ||
| { | ||
| title: translate(`workspace.sageIntacct.nonReimbursableExpenses.values.${CONST.SAGE_INTACCT_NON_REIMBURSABLE_EXPENSE_TYPE.CREDIT_CARD_CHARGE}`), | ||
| description: translate('workspace.common.travelInvoicing'), | ||
| action: !policyID ? undefined : () => Navigation.navigate(createDynamicRoute(DYNAMIC_ROUTES.POLICY_ACCOUNTING_SAGE_INTACCT_TRAVEL_INVOICING_CONFIGURATION.path)), | ||
| subscribedSettings: [CONST.SAGE_INTACCT_CONFIG.TRAVEL_INVOICING_PAYABLE_ACCOUNT], | ||
| }, | ||
| ] | ||
| : []), |
There was a problem hiding this comment.
this "Export Expensify Travel Payable To" be the selected account name not "Credit cards"
Done: Screen.Recording.2026-05-08.at.11.14.41.movWhat do you think @ishpaul777 @blimpich @parasharrajat? Do you think we should set a fallback/default if no account is selected? I believe we don’t need one, but I’d like to confirm. Thanks! |
Explanation of Change
Adds the Travel Invoicing configuration section to the Sage Intacct accounting export settings, mirroring the existing QuickBooks Online behavior. The new section is only shown when Travel Invoicing is enabled for the workspace and lets admins select a Travel vendor and a Travel payable account, with optimistic updates and standard error/pending handling.
Fixed Issues
$ #88269
PROPOSAL:
Tests
Preconditions
1. Verify Section Rendering
Objective: Ensure the "Travel Invoicing" section renders only when the feature is enabled.
Steps:
2. Verify Selection Interaction
Objective: Ensure each row is selectable and opens the correct picker.
Steps:
SelectionList) showing available vendors.SelectionList) showing available payable accounts.3. Verify Updating Vendor/Account
Objective: Ensure selection updates the integration config via the backend.
Steps:
Offline tests
Travel vendorand select a different vendor.Travel payable account.QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
88483_android_web.mov
Android: mWeb Chrome
88483_android_web.mov
iOS: Native
88483_ios_native.mov
iOS: mWeb Safari
88483_ios_web.mov
MacOS: Chrome / Safari
Screen.Recording.2026-04-22.at.12.06.36.mov