[NO QA][QBO] Redesign Travel Invoicing export settings UI to match Sage Intacct pattern#90262
Open
blimpich wants to merge 2 commits into
Open
[NO QA][QBO] Redesign Travel Invoicing export settings UI to match Sage Intacct pattern#90262blimpich wants to merge 2 commits into
blimpich wants to merge 2 commits into
Conversation
Contributor
🦜 Polyglot Parrot! 🦜Squawk! Looks like you added some shiny new English strings. Allow me to parrot them back to you in other tongues: View the translation diffdiff --git a/src/languages/de.ts b/src/languages/de.ts
index dbee784d..6e650f19 100644
--- a/src/languages/de.ts
+++ b/src/languages/de.ts
@@ -4561,7 +4561,7 @@ ${amount} für ${merchant} – ${date}`,
notConfigured: 'Nicht konfiguriert',
bankAccountDescription: 'Wähle aus, von wo Schecks versendet werden sollen.',
creditCardAccount: 'Kreditkartenkonto',
- travelInvoicingDescription: 'Reisekosten werden als Kreditkartenbelastungen in das unten angegebene QuickBooks Online-Konto exportiert.',
+ travelInvoicingDescription: 'Reisekosten werden als Kreditkartentransaktionen in das unten angegebene QuickBooks Online-Konto exportiert.',
companyCardsLocationEnabledDescription:
'QuickBooks Online unterstützt keine Standorte beim Export von Kreditorenrechnungen. Da in deinem Workspace Standorte aktiviert sind, ist diese Exportoption nicht verfügbar.',
outOfPocketTaxEnabledDescription:
diff --git a/src/languages/fr.ts b/src/languages/fr.ts
index d306daed..234fc05f 100644
--- a/src/languages/fr.ts
+++ b/src/languages/fr.ts
@@ -4571,7 +4571,7 @@ ${amount} pour ${merchant} - ${date}`,
notConfigured: 'Non configuré',
bankAccountDescription: 'Choisissez d’où envoyer les chèques.',
creditCardAccount: 'Compte de carte de crédit',
- travelInvoicingDescription: 'Les frais de voyage seront exportés comme des débits de carte de crédit vers le compte QuickBooks Online indiqué ci-dessous.',
+ travelInvoicingDescription: 'Les frais de déplacement seront exportés comme des frais de carte de crédit vers le compte QuickBooks Online indiqué ci-dessous.',
companyCardsLocationEnabledDescription:
'QuickBooks Online ne prend pas en charge les emplacements pour l’exportation des factures fournisseur. Comme vous avez activé les emplacements sur votre espace de travail, cette option d’exportation n’est pas disponible.',
outOfPocketTaxEnabledDescription:
diff --git a/src/languages/it.ts b/src/languages/it.ts
index cd6cbbd5..12fbf6c0 100644
--- a/src/languages/it.ts
+++ b/src/languages/it.ts
@@ -4546,7 +4546,7 @@ ${amount} per ${merchant} - ${date}`,
notConfigured: 'Non configurato',
bankAccountDescription: 'Scegli da dove inviare gli assegni.',
creditCardAccount: 'Conto della carta di credito',
- travelInvoicingDescription: 'Le spese di viaggio verranno esportate come addebiti su carta di credito nel conto QuickBooks Online specificato di seguito.',
+ travelInvoicingDescription: 'Le spese di viaggio verranno esportate come addebiti su carta di credito nel conto QuickBooks Online specificato qui sotto.',
companyCardsLocationEnabledDescription:
'QuickBooks Online non supporta le sedi nell’esportazione delle fatture fornitore. Poiché hai le sedi abilitate nel tuo spazio di lavoro, questa opzione di esportazione non è disponibile.',
outOfPocketTaxEnabledDescription:
diff --git a/src/languages/ja.ts b/src/languages/ja.ts
index b0cf0f2e..29f93a1b 100644
--- a/src/languages/ja.ts
+++ b/src/languages/ja.ts
@@ -4511,7 +4511,7 @@ ${integrationName === CONST.ONBOARDING_ACCOUNTING_MAPPING.other ? 'あなたの'
notConfigured: '未設定',
bankAccountDescription: '小切手の送金元を選択してください。',
creditCardAccount: 'クレジットカード口座',
- travelInvoicingDescription: '旅費は、以下で指定した QuickBooks Online アカウントにクレジットカード請求としてエクスポートされます。',
+ travelInvoicingDescription: '出張費は、以下で指定された QuickBooks Online アカウントにクレジットカード請求としてエクスポートされます。',
companyCardsLocationEnabledDescription:
'QuickBooks Online は仕入先請求書のエクスポートでロケーションをサポートしていません。ワークスペースでロケーションが有効になっているため、このエクスポートオプションは使用できません。',
outOfPocketTaxEnabledDescription:
diff --git a/src/languages/nl.ts b/src/languages/nl.ts
index 2b40b6e1..98a273bf 100644
--- a/src/languages/nl.ts
+++ b/src/languages/nl.ts
@@ -4539,7 +4539,7 @@ ${amount} voor ${merchant} - ${date}`,
notConfigured: 'Niet geconfigureerd',
bankAccountDescription: 'Kies vanaf waar cheques worden verzonden.',
creditCardAccount: 'Creditcardrekening',
- travelInvoicingDescription: 'Reiskosten worden als creditcardkosten geëxporteerd naar het hieronder opgegeven QuickBooks Online-account.',
+ travelInvoicingDescription: 'Reiskosten worden geëxporteerd als creditcardafschrijvingen naar de hieronder opgegeven QuickBooks Online‑rekening.',
companyCardsLocationEnabledDescription:
'QuickBooks Online ondersteunt geen locaties bij het exporteren van leveranciersfacturen. Omdat je locaties hebt ingeschakeld in je workspace, is deze exportoptie niet beschikbaar.',
outOfPocketTaxEnabledDescription:
diff --git a/src/languages/pl.ts b/src/languages/pl.ts
index 7ea6da48..74fb9837 100644
--- a/src/languages/pl.ts
+++ b/src/languages/pl.ts
@@ -4532,7 +4532,7 @@ ${amount} dla ${merchant} - ${date}`,
notConfigured: 'Nie skonfigurowano',
bankAccountDescription: 'Wybierz, skąd wysyłać czeki.',
creditCardAccount: 'Konto karty kredytowej',
- travelInvoicingDescription: 'Wydatki na podróże zostaną wyeksportowane jako obciążenia karty kredytowej na konto QuickBooks Online wskazane poniżej.',
+ travelInvoicingDescription: 'Wydatki podróżne zostaną wyeksportowane jako obciążenia karty kredytowej do wskazanego poniżej konta QuickBooks Online.',
companyCardsLocationEnabledDescription:
'QuickBooks Online nie obsługuje lokalizacji w eksporcie rachunków do dostawców. Ponieważ masz włączone lokalizacje w swoim obszarze roboczym, ta opcja eksportu jest niedostępna.',
outOfPocketTaxEnabledDescription:
diff --git a/src/languages/zh-hans.ts b/src/languages/zh-hans.ts
index cdeb22f4..53ceac7e 100644
--- a/src/languages/zh-hans.ts
+++ b/src/languages/zh-hans.ts
@@ -4436,7 +4436,7 @@ ${amount}，商户：${merchant} - 日期：${date}`,
notConfigured: '未配置',
bankAccountDescription: '选择从哪里寄送支票。',
creditCardAccount: '信用卡账户',
- travelInvoicingDescription: '差旅费用将作为信用卡费用导出到下面指定的 QuickBooks Online 账户。',
+ travelInvoicingDescription: '差旅报销将作为信用卡消费导出到下方指定的 QuickBooks Online 账户。',
companyCardsLocationEnabledDescription: 'QuickBooks Online 不支持在供应商账单导出中使用地点。由于您在工作区中启用了地点功能，该导出选项不可用。',
outOfPocketTaxEnabledDescription: 'QuickBooks Online 不支持在日记账分录导出中包含税费。由于你已在工作区中启用税费功能，因此无法使用此导出选项。',
outOfPocketTaxEnabledError: '启用税费时无法使用日记账分录。请选择其他导出选项。',
Note You can apply these changes to your branch by copying the patch to your clipboard, then running |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
melvin-bot
Bot
requested review from
Ollyws and
flaviadefaria
and removed request for
a team
Contributor
Author
|
@flaviadefaria @Ollyws please ignore the ping |
blimpich
changed the title
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 83635c0eae
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Redesigns the QBO Travel Invoicing detail settings page to match the Sage Intacct pattern (ref: #88483):
Fixed Issues
$ #90257
PROPOSAL:
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Screen.Recording.2026-05-11.at.4.00.30.PM.mov