[BATCH 2] Migrate Navigation usage, part 1 by collectioneur · Pull Request #88538 · Expensify/App

collectioneur · 2026-04-22T15:50:20Z

Explanation of Change

Migrates 15 InteractionManager.runAfterInteractions usages to TransitionTracker-based APIs. All entries are navigation-related, replaces fire-and-forget post-navigation callbacks with structured afterTransition options on Navigation.goBack, Navigation.dismissModal, Navigation.navigate, and closeSidePanel. Ensures cleanup callbacks run only after transitions complete, preventing stale UI flashes.

Fixed Issues

$ #83062

Tests

Verify that no errors appear in the JS console

Test 1: Delete a single-expense report from Search

Create a new expense report with one expense
Navigate to the Search page and locate the newly created report entry
Open the report and delete the expense (via the More button → Delete)
Verify that the report entry in Search disappears only after the closing/navigation animation has fully completed (i.e., the entry should not vanish while the screen is still animating away)

Test 2: Delete an entire report with multiple expenses from Search

Create a new expense report with two expenses
Navigate to the Search page and locate the report entry
Open the report, tap the More button, and delete the entire report along with both expenses
Verify that the report entry in Search is removed only after the report screen has fully closed (the entry should remain visible during the closing transition and disappear afterward)

Test 3: Delete a single transaction from within a transaction thread

Create a new expense report with two expenses
Navigate to the Search page and open the report
Tap on one of the expenses to enter its transaction thread
Inside the transaction thread, tap More → Delete
Verify that the transaction thread screen closes first, and only then the transaction entry disappears from the report view (the entry should not vanish while the transaction thread is still animating closed)

Offline tests

N/A

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Test 1

Screen.Recording.2026-05-21.at.14.41.22.mov

Test 2

Screen.Recording.2026-05-21.at.14.41.51.mov

Test 3

Screen.Recording.2026-05-21.at.14.42.49.mov

codecov · 2026-04-22T16:10:48Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/components/MoneyRequestHeader.tsx	`0.00% <ø> (ø)`
src/components/MoneyRequestHeaderActions.tsx	`6.66% <ø> (ø)`
.../components/SidePanel/SidePanelContextProvider.tsx	`87.75% <100.00%> (+1.75%)`	⬆️
...ges/inbox/DeleteTransactionNavigateBackHandler.tsx	`80.00% <ø> (ø)`
src/pages/inbox/ReportHeader.tsx	`71.05% <100.00%> (ø)`
...space/companyCards/assignCard/ConfirmationStep.tsx	`79.54% <ø> (ø)`
.../components/MoneyRequestHeaderSecondaryActions.tsx	`0.53% <0.00%> (-0.01%)`	⬇️
src/hooks/useExpenseActions.ts	`0.00% <0.00%> (ø)`
...report/ContextMenu/BaseReportActionContextMenu.tsx	`85.53% <0.00%> (+0.53%)`	⬆️
src/libs/Navigation/TransitionTracker.ts	`96.92% <60.00%> (-3.08%)`	⬇️
... and 7 more
... and 28 files with indirect coverage changes

grated transition tracker

war-in · 2026-05-21T13:07:46Z


+        onCloseCompleteRef.current = options?.afterTransition;
        setIsSidePanelTransitionEnded(false);
-        SidePanelActions.closeSidePanel(!isExtraLargeScreenWidth || shouldUpdateNarrow);


I don't get why we no longer need shouldUpdateNarrow here 🤔

I noticed that we never use this flag when calling closeSidePanel, so I just removed it

war-in · 2026-05-21T13:11:37Z

+                        if (isInNarrowPaneModal) {
+                            Navigation.navigateBackToLastSuperWideRHPScreen({afterTransition: afterDelete});
+                            return;
+                        }
+                        onBackButtonPress(false, {afterTransition: afterDelete});


Why do we change the logic here?

I probably messed up resolving the merge conflicts 😓 , I'll double-check

war-in · 2026-05-21T13:13:11Z

+    TransitionTracker.runAfterTransitions({
+        callback: () => {
+            waitForUserSignIn().then(() => {
+                Navigation.waitForProtectedRoutes().then(() => {


We wait 3 times here 😓 Can't this logic be simplified a bit?

I simplified it with async/await, looks like the best approach here

war-in · 2026-05-21T13:15:56Z

@@ -24,10 +23,11 @@ function DeleteTransactionNavigateBackHandler() {
            return;
        }
        // Clear the URL only after we navigate away to avoid a brief Not Found flash.


that sounds like the use-case for afterTransition. Do we have to use transition tracker here?

war-in · 2026-05-21T13:16:40Z

@@ -102,10 +101,11 @@ function SearchMoneyRequestReportPage({route}: SearchMoneyRequestPageProps) {
            return;
        }
        // Clear the URL only after we navigate away to avoid a brief Not Found flash.


I feel like doing it that way in these two cases might be a bit tricky. Since the report has quite a few flows where a transaction can be deleted, we'd have to track down every single goBack/other navigation call triggered after a deletion and manually insert the same afterTransition everywhere.
Also, the report data gets deleted before the navigation starts. Because of this, using a useEffect with transitionTracker works better here. It catches the exact moment when the data is gone and the screen loses focus, and only then queues up the callback (which safely runs after the navigation completes). Plus, the navigation method after a deletion can vary quite a bit (dismissModal, goBack, etc), so this approach handles all those cases more cleanly imo

war-in · 2026-05-21T13:17:56Z

-        Navigation.dismissModal();
        if (backTo) {
-            Navigation.navigate(backTo);
+            Navigation.dismissModal();


I wonder if we should put the next navigate in afterTransition callback here 🤔

The navigation already has internal mechanisms that put navigation calls onto the stack, so there will be no conflicts. React Navigation will dismiss the modal first and then navigate using the afterTransition callback

melvin-bot · 2026-05-26T11:00:34Z

@daledah Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

daledah · 2026-05-27T04:14:17Z

on it now

daledah · 2026-05-27T04:18:00Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2026-05-27.at.14.05.21.mov

Android: mWeb Chrome

am.mov

iOS: HybridApp

ios.mov

iOS: mWeb Safari

ios-mweb.mov

MacOS: Chrome / Safari

Test 1

web-1.mov

Test 2

web-2.mov

Test 3

web-3.mov

daledah · 2026-05-27T04:39:15Z

flushCallbacks() calls callback() without await, so the try/catch block won't catch errors from async callbacks. I think we should consider making flushCallbacks async-aware

Added error handling for async callbacks, thanks for the suggestion!

melvin-bot · 2026-05-28T03:18:10Z

We did not find an internal engineer to review this PR, trying to assign a random engineer to #83062 as well as to this PR... Please reach out for help on Slack if no one gets assigned!

github-actions · 2026-05-28T13:43:29Z

🚧 @luacmartins has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-05-28T13:49:07Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #88538.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-6768020f6fa-352a18a-61c7134d6591a33b8e3b67ed2f2855964ae701d0/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-6768020-352a18a-c7e7b415f69870e5641221ad268ee22425d47545/index.html

Web 🕸️
https://88538.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-05-28T13:52:09Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-05-28T21:10:44Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 9.3.89-1 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

MelvinBot · 2026-05-28T21:12:02Z

🤖 Help site review: No changes required.

This PR is an internal refactor — it migrates 15 InteractionManager.runAfterInteractions callbacks to TransitionTracker-based APIs (afterTransition on Navigation.goBack, Navigation.dismissModal, Navigation.navigate, etc.) to prevent stale UI flashes during navigation transitions.

There are no user-facing changes:

No new or renamed features, tabs, settings, or buttons
No changes to user flows or workflows
No new functionality customers would need documented
Only timing improvements for transition cleanup (smoother animations)

No corresponding App/docs/articles updates are needed.

mitarachim · 2026-05-29T04:03:53Z

@collectioneur This PR is failing in Test 2 and Test 3 because of a regression issue #92036

The issue is reproducible in: Web

Bug7165846_1780008223260.Report_disappears.mp4

collectioneur · 2026-05-29T09:21:39Z

@miratachim I'm already looking into it. I'll try to release a fix today 🙌

collectioneur · 2026-05-29T12:34:01Z

@mitarachim after investigating, I discovered that the goBack animation for RHPs (both wide and Super Wide) is now much faster. I tested these two flows using my reverted PR and an AdHoc build. The transaction/report does get deleted after the animation ends, exactly as intended. However, due to the increased speed of the transition, it creates a visual illusion that the deletion happens before the transition finishes. I've attached two videos demonstrating that the transaction correctly waits for the transition to end:

2.mov

Also, when the transition starts, an unrelated bug occurs (the overlay's opacity doesn't animate with the transition). This also contributes to the illusion that the transaction deletes before transitionEnd. As shown in the video, this is not the case, the transaction properly deletes after the transition:

1.mov

collectioneur added 4 commits April 22, 2026 17:29

migrate interactionManager in tasks

095c47a

migrate assign card

58209df

migrate two factor auth actions

99df816

migrate clearGroupChat

df8f569

melvin-bot Bot assigned collectioneur Apr 22, 2026

fix navigateToReport args

0b4aa34

dukenv0307 mentioned this pull request May 12, 2026

[Requires Payment] Restrict InteractionManager and TransitionTracker usage with 'no-restricted-imports' eslint rule #83072

Closed

collectioneur added 10 commits May 13, 2026 15:55

small refactor of one case

c6e111f

migrate Clear report data 1909 Report/index.ts

df073ed

migrate another variant

0bb06c5

migrate MoneyRequestReportView.tsx 137

b8e3ea8

migrate ReportScreen.tsx 493

7512130

migrate ReportScreen.tsx 681

fd1c15e

migrate 3 interactionManagers

a68f053

Merge branch 'main' into collectioneur/transition-tracker-batch-2

cbd815f

migrate InteractionManager

07a9985

cleanup

ed8a44b

collectioneur changed the title ~~Collectioneur/transition tracker batch 2~~ [BATCH 2] Migrate Navigation usage, part 1 May 20, 2026

collectioneur added 9 commits May 20, 2026 16:02

add some files to eslint seatbelt

489a036

Merge branch 'main' into collectioneur/transition-tracker-batch-2

305a2ba

fix lint

e8a1b1b

fix typescript

f8203cf

fix tests

40cd901

fix navigateToReport

91cd69a

migrate three more interaction managers

48c6581

fix mi

c3303b8

grated transition tracker

fix prettier

a2b4443

war-in reviewed May 21, 2026

View reviewed changes

Merge branch 'main' into collectioneur/transition-tracker-batch-2

894b841

collectioneur marked this pull request as ready for review May 26, 2026 11:00

collectioneur requested review from a team as code owners May 26, 2026 11:00

melvin-bot Bot requested review from daledah and flaviadefaria May 26, 2026 11:00

melvin-bot Bot removed request for a team May 26, 2026 11:00

daledah reviewed May 27, 2026

View reviewed changes

collectioneur added 2 commits May 27, 2026 11:58

add error handling for async callbacks

65bef62

Merge branch 'main' into collectioneur/transition-tracker-batch-2

b07350f

daledah approved these changes May 28, 2026

View reviewed changes

melvin-bot Bot requested a review from luacmartins May 28, 2026 03:18

luacmartins approved these changes May 28, 2026

View reviewed changes

luacmartins merged commit 6768020 into Expensify:main May 28, 2026
40 checks passed

OSBotify mentioned this pull request May 28, 2026

Deploy Checklist: New Expensify 2026-05-28 #92014

Open

64 tasks

applause-bot Bot mentioned this pull request May 29, 2026

Expense disappears from the report view before the thread screen is closed #92036

Open

7 tasks

MelvinBot mentioned this pull request May 29, 2026

Email- Endless loading instead redirect to the workspace chat when user click invite link #92047

Open

7 tasks

MelvinBot mentioned this pull request May 29, 2026

Onboarding-Welcome message and Join button are not displayed in OD for private domain account #92060

Open

7 tasks

Conversation

collectioneur commented Apr 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov Bot commented Apr 22, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

melvin-bot Bot commented May 26, 2026

Uh oh!

daledah commented May 27, 2026

Uh oh!

daledah commented May 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Test 1

Test 2

Test 3

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

melvin-bot Bot commented May 28, 2026

Uh oh!

Uh oh!

github-actions Bot commented May 28, 2026

Uh oh!

github-actions Bot commented May 28, 2026

Uh oh!

OSBotify commented May 28, 2026

Uh oh!

OSBotify commented May 28, 2026

Uh oh!

MelvinBot commented May 28, 2026

Uh oh!

mitarachim commented May 29, 2026

Uh oh!

collectioneur commented May 29, 2026

Uh oh!

collectioneur commented May 29, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

collectioneur commented Apr 22, 2026 •

edited

Loading

codecov Bot commented Apr 22, 2026 •

edited by github-actions Bot

Loading

daledah commented May 27, 2026 •

edited

Loading