fix: Mark as paid on Reports pays the full amount without asking paying option by paulnjs · Pull Request #88569 · Expensify/App

paulnjs · 2026-04-23T08:02:28Z

Explanation of Change

Fixed Issues

$#88375
PROPOSAL:#88375 (comment)

Tests

Open app
User A navigate to the chat with user B
User A create 2 expenses
User B navigate to the chat with user A
User B hold one expense
User B click on Mark as paid
Verify a prompt is displayed to pay the full report amount or just the amount that is pending

Verify that no errors appear in the JS console

Offline tests

QA Steps

Open app
User A navigate to the chat with user B
User A create 2 expenses
User B navigate to the chat with user A
User B hold one expense
User B click on Mark as paid
Verify a prompt is displayed to pay the full report amount or just the amount that is pending

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

android-web.mov

iOS: Native

ios.mov

iOS: mWeb Safari

ios-web.mov

MacOS: Chrome / Safari

web.mov

…ng option

codecov · 2026-04-23T08:12:45Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
...eaderActions/MoneyReportHeaderSecondaryActions.tsx	`0.00% <ø> (ø)`
...aderActions/MoneyReportHeaderSelectionDropdown.tsx	`1.20% <ø> (+0.02%)`	⬆️
src/hooks/useLifecycleActions.tsx	`0.00% <ø> (ø)`
src/hooks/useSelectionModeReportActions.ts	`82.65% <100.00%> (ø)`
src/libs/ReportUtils.ts	`82.49% <100.00%> (-0.02%)`	⬇️
src/components/MoneyReportHeaderModals.tsx	`0.00% <0.00%> (ø)`
...oneyReportHeaderPrimaryAction/PayPrimaryAction.tsx	`0.00% <0.00%> (ø)`
.../MoneyRequestReportPreview/ApproveActionButton.tsx	`0.00% <0.00%> (ø)`
...Item/MoneyRequestReportPreview/PayActionButton.tsx	`0.00% <0.00%> (ø)`
... and 7 files with indirect coverage changes

melvin-bot · 2026-04-23T08:36:03Z

@dukenv0307 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

dukenv0307 · 2026-04-23T11:59:50Z

Please use the new util function in useSelectionModeReportActions as well

dukenv0307 · 2026-04-26T02:54:40Z

@paulnjs can you please check the failing test?

paulnjs · 2026-04-28T03:06:18Z

@dukenv0307 I updated. Please help to check again.

dukenv0307 · 2026-04-28T14:18:02Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2026-04-28.at.21.17.26.mov

Android: mWeb Chrome

Screen.Recording.2026-04-30.at.22.17.41.mov

iOS: HybridApp

Screen.Recording.2026-04-28.at.21.08.47.mov

iOS: mWeb Safari

Screen.Recording.2026-04-28.at.21.04.23.mov

MacOS: Chrome / Safari

Screen.Recording.2026-04-30.at.21.53.41.mov

dukenv0307 · 2026-04-28T14:18:45Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 02b880f379

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-04-28T14:26:26Z

+                nonHeldAmount: !hasHeldExpenses && hasValidNonHeldAmount ? nonHeldAmount : undefined,
                fullAmount,
-                hasNonHeldExpenses: !hasOnlyHeldExpenses,
+                hasNonHeldExpenses: !hasHeldExpenses,


Use hasOnlyHeldExpenses when building hold-menu options

In openHoldMenu, hasNonHeldExpenses and nonHeldAmount are now derived from hasHeldExpenses (any held transaction) instead of the previous “only held” check. For reports that contain a mix of held and non-held expenses, hasHeldExpenses is true, so this code hides the partial option and treats the report as fully held, forcing users into the full-amount path. That regresses the intended behavior for mixed reports (the exact case this change is meant to fix).

Useful? React with 👍 / 👎.

Make sense to me, please fix it @paulnjs

@dukenv0307 I updated

dukenv0307 · 2026-04-30T14:39:40Z

on it now

dukenv0307 · 2026-04-30T14:54:46Z

Looks good

dukenv0307 · 2026-04-30T14:54:51Z

@codex review

chatgpt-codex-connector · 2026-04-30T15:10:29Z

Codex Review: Didn't find any major issues. Keep it up!

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

OSBotify · 2026-05-01T07:03:52Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-05-01T07:11:34Z

🚧 @mjasikowski has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-05-01T07:15:55Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #88569.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-d51eca5-933a3e4-1c38f815952469dc25fad4dda48471f84e724b8f/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-d51eca5-933a3e4-a7a35af5ff4e3b6934007c89e1accbc22508ee2e/index.html

Web 🕸️
https://88569.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-05-04T13:27:26Z

🚀 Deployed to staging by https://github.com/mjasikowski in version: 9.3.66-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	cancelled 🔪
🍎 iOS 🍎	cancelled 🔪

MelvinBot · 2026-05-04T13:29:14Z

No help site changes are required for this PR.

This is an internal bug fix that changes how held expenses are detected (hasHeldExpenses → hasHeldExpensesFromTransactions) to ensure the prompt asking whether to pay the full report amount or just the non-held amount appears correctly. No user-facing terminology, UI labels, feature names, or workflows were changed — the existing help site articles already accurately describe the Hold and Pay behaviors.

fix: Mark as paid on Reports pays the full amount without asking payi…

365e030

…ng option

melvin-bot Bot assigned paulnjs Apr 23, 2026

update code

d7ccdb3

paulnjs marked this pull request as ready for review April 23, 2026 08:35

paulnjs requested review from a team as code owners April 23, 2026 08:35

melvin-bot Bot requested review from JmillsExpensify and dukenv0307 and removed request for a team April 23, 2026 08:36

melvin-bot Bot removed the request for review from a team April 23, 2026 08:36

dukenv0307 reviewed Apr 23, 2026

View reviewed changes

Comment thread src/libs/ReportUtils.ts Outdated

paulnjs added 2 commits April 24, 2026 14:16

Merge branch 'main' into paulnjs-fix/88375

3b57469

update code

4e5524a

paulnjs added 2 commits April 28, 2026 09:29

Merge branch 'main' into paulnjs-fix/88375

10cab9b

udpate code

02b880f

chatgpt-codex-connector Bot reviewed Apr 28, 2026

View reviewed changes

paulnjs added 2 commits April 29, 2026 11:33

update code

8f58c38

Merge branch 'main' into paulnjs-fix/88375

8a5ae61

dukenv0307 approved these changes Apr 30, 2026

View reviewed changes

melvin-bot Bot requested a review from mjasikowski April 30, 2026 15:18

mjasikowski approved these changes May 1, 2026

View reviewed changes

mjasikowski merged commit d51eca5 into Expensify:main May 1, 2026
41 checks passed

OSBotify mentioned this pull request May 4, 2026

Deploy Checklist: New Expensify 2026-05-04 #89508

Open

75 tasks

Conversation

paulnjs commented Apr 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov Bot commented Apr 23, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot Bot commented Apr 23, 2026

Uh oh!

Uh oh!

dukenv0307 commented Apr 23, 2026

Uh oh!

dukenv0307 commented Apr 26, 2026

Uh oh!

paulnjs commented Apr 28, 2026

Uh oh!

dukenv0307 commented Apr 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

dukenv0307 commented Apr 28, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Apr 28, 2026

Choose a reason for hiding this comment

Uh oh!

dukenv0307 Apr 28, 2026

Choose a reason for hiding this comment

Uh oh!

paulnjs Apr 29, 2026

Choose a reason for hiding this comment

Uh oh!

dukenv0307 commented Apr 30, 2026

Uh oh!

dukenv0307 commented Apr 30, 2026

Uh oh!

dukenv0307 commented Apr 30, 2026

Uh oh!

chatgpt-codex-connector Bot commented Apr 30, 2026

Uh oh!

Uh oh!

OSBotify commented May 1, 2026

Uh oh!

github-actions Bot commented May 1, 2026

Uh oh!

github-actions Bot commented May 1, 2026

Uh oh!

OSBotify commented May 4, 2026

Uh oh!

MelvinBot commented May 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

paulnjs commented Apr 23, 2026 •

edited

Loading

codecov Bot commented Apr 23, 2026 •

edited by github-actions Bot

Loading

dukenv0307 commented Apr 28, 2026 •

edited

Loading