Skip to content

[GPS] Pause/Resume functionality#88609

Merged
puneetlath merged 19 commits into
Expensify:mainfrom
software-mansion-labs:@GCyganek/gps/pause-resume-gps-trip
May 7, 2026
Merged

[GPS] Pause/Resume functionality#88609
puneetlath merged 19 commits into
Expensify:mainfrom
software-mansion-labs:@GCyganek/gps/pause-resume-gps-trip

Conversation

@GCyganek
Copy link
Copy Markdown
Contributor

@GCyganek GCyganek commented Apr 23, 2026

Explanation of Change

  • gpsPoints in GpsDraftDetails changed from 1D array to 2D array of segments. Each paused-and-resumed section of a trip becomes a separate segment.
  • startAddress and endAddress top-level fields removed from GpsDraftDetails. Address is now stored directly on each GPSPoint as an optional address field, so each segment carries its own start/end address.
  • Stopping tracking no longer ends the trip — it moves to a "stopped" state. The user can then resume (starts a new segment) or save (submits the trip).
  • resumeGpsTrip action adds a new empty segment to gpsPoints and sets isTracking: true. The background location task automatically resolves the start address for the new segment when the first point arrives.
  • The stop confirmation modal has been removed. Stop is now immediate; discard has moved to a dedicated trash icon button (DiscardGPSTripButton) shown only in the stopped state.
  • The "Stop" button's danger style removed; the "Discard" button replaced with "Resume"; the "Next" button replaced with "Save".
  • directionCoordinates in MapViewProps and DirectionProps updated to accept Coordinate[] | Coordinate[][].
  • Direction.tsx renders separate ShapeSource/LineLayer pairs for each segment, preserving the visual gap between paused segments on the map.
  • MapView.tsx and MapViewImpl.website.tsx flatten multi-segment coordinates for bounds/centering calculations only, while passing the original segmented array to Direction.
  • ConvertGpsPointsTo2DArray migration wraps any old existing gpsPoints into an additional array to make it 2D and migrates startAddress/endAddress values into the address field on the first and last points respectively.

Fixed Issues

$ #86026
PROPOSAL: N/A

Tests

Discard button:

  1. FAB > Track distance > GPS
  2. Tap Start and track some distance
  3. Verify that there is a correct route on the map as you travel
  4. Tap Stop
  5. Verify that Start and Stop addresses load correctly
  6. Verify that the discard button appears next to the distance counter on the right
  7. Tap the discard button
  8. Verify that it shows confirm dialog
  9. Confirm to discard the trip
  10. Verify that it resets the state and that the trip can be started again

Multi-segment trip:

  1. FAB > Track distance > GPS
  2. Tap Start and track some distance
  3. Verify that there is a correct route on the map as you travel
  4. Tap Stop
  5. Verify that Start and Stop addresses have loaded correctly
  6. Tap Resume after a while to continue the trip from a different location
  7. Verify that the trip resumes and the Stop address is replaced with Tracking distance... and there is a new separate segment of the trip on the map
  8. Tap Stop again
  9. Verify that the Stop address loads correctly
  10. Tap Save and select a Workspace
  11. Verify that the expense is created successfully
  12. Open the generated receipt
  13. Verify that the receipt is correct and that it shows Stop/Start waypoints for all segments of the trip
    Repeat, but create selfDM expense this time

Single segment trip:

  1. FAB > Track distance > GPS
  2. Tap Start and track some distance
  3. Verify that there is a correct route on the map as you travel
  4. Tap Stop
  5. Verify that Start and Stop addresses have loaded correctly
  6. Tap Save and select a Workspace
  7. Verify that the expense is created successfully
  8. Open the generated receipt
  9. Verify that the receipt is correct and that it shows Stop/Start waypoints for all segments of the trip
    Repeat, but create selfDM expense this time
  • Verify that no errors appear in the JS console

Offline tests

  1. Start a trip in offline mode
  2. Pause and resume a trip a few times to make sure that the trip will be segmented
  3. Verify that Stop/Start waypoints have coordinates instead of human readable addresses
  4. Stop the trip
  5. Go online
  6. Verify that Stop/Start waypoints have human readable addresses instead of coordinates
  7. Submit the trip
  8. Open the generated receipt
  9. Verify that the Start/Stop waypoints have human readable addresses

QA Steps

Same as tests

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Screen.Recording.2026-05-04.at.15.48.17.mov
Screen.Recording.2026-05-04.at.15.49.15.mov
Screen.Recording.2026-05-04.at.17.35.53.mov
Screen.Recording.2026-05-04.at.17.37.12.mov
iOS: Native
Screen.Recording.2026-05-04.at.17.54.18.mov
Screen.Recording.2026-05-04.at.17.55.40.mov
Screen.Recording.2026-05-04.at.17.56.22.mov
Screen.Recording.2026-05-04.at.17.57.37.mov
Screen.Recording.2026-05-04.at.17.57.37.mov

@melvin-bot
Copy link
Copy Markdown

melvin-bot Bot commented Apr 23, 2026

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

  1. Look at the code and make sure there are no malicious changes.
  2. Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 23, 2026

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
src/components/GPSInProgressModal/index.native.tsx 100.00% <100.00%> (ø)
...rc/components/GPSTripStateChecker/index.native.tsx 73.68% <100.00%> (+0.71%) ⬆️
src/components/MapView/utils.ts 31.74% <100.00%> (+2.23%) ⬆️
src/libs/getArrayDepth.ts 100.00% <100.00%> (ø)
src/libs/is2dArray.ts 100.00% <100.00%> (ø)
src/libs/migrateOnyx.ts 100.00% <100.00%> (+18.75%) ⬆️
src/components/AccountSwitcher.tsx 0.00% <0.00%> (ø)
src/components/MapView/MapView.tsx 56.60% <50.00%> (+0.41%) ⬆️
.../request/step/confirmation/useExpenseSubmission.ts 52.55% <50.00%> (ø)
src/components/ConfirmedRoute.tsx 0.00% <0.00%> (ø)
... and 14 more
... and 200 files with indirect coverage changes

@GCyganek
Copy link
Copy Markdown
Contributor Author

@Expensify/design the backend is not merged yet and we need to wait for it to be able to create receipts with split GPS trips, but here you can see how it will look like:

Screen.Recording.2026-04-23.at.18.00.07.mov

Of course map styles (icons and route) will be updated soon in a separate PR

@shawnborton
Copy link
Copy Markdown
Contributor

I would think we don't need this modal, right?
CleanShot 2026-04-23 at 18 13 05@2x

Otherwise this is feeling nice!

@GCyganek
Copy link
Copy Markdown
Contributor Author

I would think we don't need this modal, right?

We have it from the beginning, but I can delete it if you prefer, of course

@shawnborton
Copy link
Copy Markdown
Contributor

Yeah now that we have a super simple way to resume if you accidentally stopped, I think we don't need it personally.

@GCyganek
Copy link
Copy Markdown
Contributor Author

Will do!

@dannymcclain
Copy link
Copy Markdown
Contributor

Yeah now that we have a super simple way to resume if you accidentally stopped, I think we don't need it personally.

Totally agree!

@dubielzyk-expensify
Copy link
Copy Markdown
Contributor

dubielzyk-expensify commented Apr 27, 2026

Agree with removing the modal. That was there for safety before the pause.

Can we change the wording here a bit. The primary button for in progress should say: Pause (instead of Stop).

And then ones paused can we say Resume and Finish. I just think that soften the language a bit to ensure people know that they can start/stop at any point. And finish is a clearer way to say the journey is ending than Save.

That is if @Expensify/design team is okay with that ofc.

@GCyganek
Copy link
Copy Markdown
Contributor Author

Can we change the wording here a bit. The primary button for in progress should say: Pause (instead of Stop).

And then ones paused can we say Resume and Finish. I just think that soften the language a bit to ensure people know that they can start/stop at any point. And finish is a clearer way to say the journey is ending than Save.

I like this change, will wait for confirmation before I change it here

@shawnborton
Copy link
Copy Markdown
Contributor

I don't feel strongly. Part of me thinks it won't be common for people to pause and resume, so having the only word to "finish" your tracking be "Pause" feels a bit odd to me. I think I would personally just keep Stop but let's see how the others feel!

@dannymcclain
Copy link
Copy Markdown
Contributor

No strong feelings from me - when I first read your updated copy I thought "Oh yeah I like that!" but then when I read Shawn's comment I did kinda feel like oh yeah, stop is more clear/expected than pause for ending my tracking. I do kinda like Finish instead of Save though, but ultimately I'm not super passionate and think either would be fine.

I also don't really use any GPS tracking apps or workflows, so I'm not familiar with what the most common patterns and verbiage are. Happy to lean on those with more experience/context!

@dubielzyk-expensify
Copy link
Copy Markdown
Contributor

Alright, let's leave it as is then.

@GCyganek
Copy link
Copy Markdown
Contributor Author

GCyganek commented May 4, 2026

@codex review

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 68184edd30

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread src/libs/actions/GPSDraftDetails.ts Outdated
Comment thread src/components/GPSTripStateChecker/useUpdateGpsTripOnReconnect.ts Outdated
Comment thread src/components/GPSTripStateChecker/useUpdateGpsTripOnReconnect.ts Outdated
@GCyganek
Copy link
Copy Markdown
Contributor Author

GCyganek commented May 4, 2026

@codex review

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: de02cb9ad7

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread src/setup/backgroundLocationTrackingTask/index.native.ts Outdated
Comment thread src/components/MapView/MapViewImpl.website.tsx
@GCyganek
Copy link
Copy Markdown
Contributor Author

GCyganek commented May 5, 2026

Let me check that address issue. We should be showing coordinates only if fetching human readable address from coordinates fails or user's offline

EDIT: Should be fixed now

@shawnborton
Copy link
Copy Markdown
Contributor

shawnborton commented May 5, 2026

Tests super well! I have the same GPS starting thing that Jon reported, otherwise it seems to be great.

One thing I noticed, that is likely a separate conversation, is that I went through a tunnel with poor cell service and the map line didn't really get my path right:
CleanShot 2026-05-05 at 14 08 57@2x

You can see where it missed the road and has a triangular shape. Anything we can do about that?

@GCyganek
Copy link
Copy Markdown
Contributor Author

GCyganek commented May 5, 2026

Anything we can do about that?

Tunnels are problematic for GPS tracking as if satellite is not reachable and there is no cell service then there is no way to get location updates. If this is a real problem for us then I could do some research, but I don't have a solution at the moment unfortunately.

This actually reminds me that @JmillsExpensify is working on the option to choose alternative routes, so maybe using it user would have a way to choose the same route, but with the fixed tunnel part?

@dubielzyk-expensify
Copy link
Copy Markdown
Contributor

How often are we adding a geolocation and spot on the polyline? Obviously I'm assuming we don't wanna add a mapping solution, but I did find it a bit jarring that, when driving, it took quite a few meters before the trip length grew. Maybe it's fine though

@GCyganek
Copy link
Copy Markdown
Contributor Author

GCyganek commented May 6, 2026

How often are we adding a geolocation and spot on the polyline? Obviously I'm assuming we don't wanna add a mapping solution, but I did find it a bit jarring that, when driving, it took quite a few meters before the trip length grew. Maybe it's fine though

We have 0.1 mi distance interval. It can be changed, but we decided to stick with it, because the longer the trip, the more points we save and we have a limit in the backend of how many points can be used to create a receipt and if we have too many points, then we have to use an algorithm which discards every n-th point to go down to the limit and makes the trip lose precision anyway

Anyway, we could try reducing the distance interval, which will make the trip updates more frequent and the only downside would be that the map with the route on the receipt generated in the backend will be less precise than what the user sees on the map while the trip is in progress and before it's saved as an expense faster (less distance needed to reach the limit when we have to use the algorithm that discards points).

@dukenv0307
Copy link
Copy Markdown
Contributor

on it now

import type {GPSPoint} from '@src/types/onyx/GpsDraftDetails';

function useUpdateGpsTripOnReconnect() {
const [gpsDraftDetails] = useOnyx(ONYXKEYS.GPS_DRAFT_DETAILS);
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can remove it entirely, then use OnyxUtils.get inside updateAddressesToHumanReadable. If we still need gpsDraftDetails reactive value, we can pass it from its parent

Comment thread src/components/MapView/utils.ts Outdated
import type {Coordinate} from './MapViewTypes';

function isSingleSegmentRoute(directionCoordinates: Coordinate[] | Coordinate[][]): directionCoordinates is Coordinate[] {
return getArrayDepth(directionCoordinates) === 2;
Copy link
Copy Markdown
Contributor

@dukenv0307 dukenv0307 May 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's use is2dArray, or we can use is2dArray directly, no need to create isSingleSegmentRoute

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can use is2dArray in this function, but I'd leave the isSingleSegmentRoute, as it makes the code more readable IMO. Without it it can be confusing, as looking at the type Coordinate[] you'd guess it's 1d array, but it's actually a 2d array because Coordinate is [number, number], so using isSingleSegmentRoute immediately tells us that we're checking if we're using a segmented trip (3d array) or a simple trip without segments (2d array)

@dukenv0307
Copy link
Copy Markdown
Contributor

In useGPSWaypointMarkers.tsx

const waypointEntries = Object.entries(getGPSWaypoints(gpsDraftDetails));
    const lastIndex = waypointEntries.length - 1;

    return waypointEntries.flatMap(([key, waypoint], index): WayPoint[] => {
        const isStart = index === 0;
        const isEnd = index === lastIndex;

        if (isEnd && !isTripStopped) {
            return [];
        }

        let icon = DotIndicator;
        if (isStart) {
            icon = DotIndicatorUnfilled;
        } else if (isEnd) {
            icon = Location;
        }

        return [
            {
                id: key,
                coordinate: [waypoint.lng, waypoint.lat],
                markerComponent: (): ReactNode => getMarkerComponent(icon),
            },
        ];
    });
}

@dukenv0307
Copy link
Copy Markdown
Contributor

The rest looks good

@GCyganek
Copy link
Copy Markdown
Contributor Author

GCyganek commented May 7, 2026

The rest looks good

Applied changes according to the review

@dukenv0307
Copy link
Copy Markdown
Contributor

on it now

@dukenv0307
Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Screen.Recording.2026-05-07.at.23.38.23.mov
Android: mWeb Chrome
iOS: HybridApp
Screen.Recording.2026-05-07.at.23.28.58.mov
iOS: mWeb Safari
MacOS: Chrome / Safari

@melvin-bot melvin-bot Bot requested a review from puneetlath May 7, 2026 16:42
@puneetlath puneetlath merged commit 5d094c0 into Expensify:main May 7, 2026
39 checks passed
@OSBotify
Copy link
Copy Markdown
Contributor

OSBotify commented May 7, 2026

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 7, 2026

🚧 @puneetlath has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify
Copy link
Copy Markdown
Contributor

OSBotify commented May 8, 2026

🚀 Deployed to staging by https://github.com/puneetlath in version: 9.3.69-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@MelvinBot
Copy link
Copy Markdown
Contributor

Yes, help site changes are required. The GPS tracking flow changed significantly in this PR — stop is now immediate (no confirmation dialog), Resume enables multi-segment trips, Save replaces Next, and there's a new discard button.

I've created a draft PR with the necessary updates to two help site articles:

Draft PR: #90014

Files updated:

  • docs/articles/new-expensify/reports-and-expenses/Distance-Expenses.md — Updated GPS steps, keywords, and receipt FAQ
  • docs/articles/new-expensify/reports-and-expenses/Create-an-Expense.md — Updated GPS steps

Changes made:

  • Removed "confirm by selecting Stop GPS tracking" (confirmation modal was removed)
  • Added Resume step for multi-segment trips
  • Replaced Next with Save
  • Added discard trip step (trash icon)
  • Updated GPS receipt FAQ to mention multi-segment trip receipts
  • Added pause/resume keywords for search discoverability

@OSBotify
Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/Beamanator in version: 9.3.69-18 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@QichenZhu QichenZhu mentioned this pull request May 12, 2026
51 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants