Skip to content

[No QA] Docs updates for E/A#88609 GPS pause resume and save flow#90014

Open
MelvinBot wants to merge 3 commits into
mainfrom
melvin-docs-gps-pause-resume
Open

[No QA] Docs updates for E/A#88609 GPS pause resume and save flow#90014
MelvinBot wants to merge 3 commits into
mainfrom
melvin-docs-gps-pause-resume

Conversation

@MelvinBot
Copy link
Copy Markdown
Contributor

Summary

  • Updates GPS distance tracking docs to reflect the new pause/resume functionality from [GPS] Pause/Resume functionality #88609
  • Stop is now immediate — removed reference to the "Stop GPS tracking" confirmation dialog
  • Resume button added — users can pause and resume tracking to create multi-segment trips
  • Save replaces Next as the button to submit a GPS trip
  • Discard via trash icon documented for discarding trips in stopped state
  • Updated GPS receipt FAQ to mention multi-segment trip receipts

Files changed

  • docs/articles/new-expensify/reports-and-expenses/Distance-Expenses.md
  • docs/articles/new-expensify/reports-and-expenses/Create-an-Expense.md

Update help site articles to reflect new GPS tracking flow:
- Stop is now immediate (no confirmation dialog)
- Add Resume button for multi-segment trips
- Replace Next with Save button
- Add discard trip via trash icon
- Update receipt FAQ for multi-segment trips

Co-authored-by: Gabriel Cyganek <GCyganek@users.noreply.github.com>
@MelvinBot MelvinBot added the HelpDot Apply this label if the issue relates to ExpensifyHelp label May 8, 2026
@MelvinBot MelvinBot mentioned this pull request May 8, 2026
54 tasks
@stephanieelliott stephanieelliott marked this pull request as ready for review May 11, 2026 20:39
@github-actions
Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment

This PR updates GPS distance tracking documentation across two files to reflect a new pause/resume feature (from E/A#88609). The changes are well-scoped: updating button names to match new UI (Save replaces Next, Stop is now immediate), adding the new Resume and discard flows, and updating the FAQ. The writing is clear and action-oriented. There is one build-breaking issue (duplicate YAML key) that must be fixed before merge.

Scores Summary

  • Readability: 9/10 - Steps are sequential, clear, and action-oriented. The optional step in parentheses is well-formatted. The multi-segment explanation in the intro paragraph is concise.
  • AI Readiness: 8/10 - New keywords for pause/resume/multi-segment/discard are added, which is good. However, a duplicate keywords field in the YAML frontmatter will cause parsing issues. The headings and metadata are otherwise well-structured.
  • Style Compliance: 9/10 - Button names are bolded correctly (Stop, Resume, Save, Start, Create expense). UI terminology appears accurate to the new flow. Navigation and platform notes are properly handled.

Key Findings

  • CRITICAL: Duplicate keywords field in Distance-Expenses.md frontmatter. The diff adds a new keywords line (with pause/resume/multi-segment terms) but the old keywords line (with save-for-later/in-progress/incomplete odometer terms) remains. YAML does not support duplicate keys -- most parsers will silently use only the last occurrence, meaning the new GPS-related keywords would be lost. These two lines must be merged into a single keywords field.
  • The old keywords included terms like "save for later", "in-progress odometer", "incomplete odometer" which may still be relevant and would be dropped if only the new line is kept.
  • The new keywords ("pause GPS", "resume GPS", "multi-segment trip", "discard trip") are well-chosen and align with the new feature.
  • Step formatting in both files is consistent and follows the governance step formatting standard.
  • Bold formatting on all button/UI element references is correct throughout.
  • The FAQ update about multi-segment receipts is a good addition and keeps the article self-contained.

Recommendations

  1. [Must fix] Merge the two keywords lines in Distance-Expenses.md into a single field. Combine the new terms (pause GPS, resume GPS, multi-segment trip, discard trip) with the existing terms (save for later, in-progress odometer, incomplete odometer) and remove whichever are no longer relevant.
  2. [Minor] In Create-an-Expense.md step 6, consider clarifying "creating a new segment" slightly -- the phrasing "creating a new segment" is somewhat technical. The Distance-Expenses.md version ("Each resumed section appears as a separate segment on the map") is clearer and could serve as a model.
  3. [Minor] In Distance-Expenses.md step 7 ("tap the trash icon next to the distance counter"), confirm that "trash icon" matches the exact UI element. Per naming conventions, UI references should use the exact label or icon shown in the product.

Files Reviewed

  • docs/articles/new-expensify/reports-and-expenses/Create-an-Expense.md -- Steps updated correctly for pause/resume flow; button names match new UI. Minor clarity improvement possible in step 6.
  • docs/articles/new-expensify/reports-and-expenses/Distance-Expenses.md -- Good content updates for multi-segment GPS tracking. Duplicate keywords YAML key must be fixed before merge. FAQ update is appropriate.

Comment thread docs/articles/new-expensify/reports-and-expenses/Distance-Expenses.md Outdated
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2ce8ecc34d

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@github-actions github-actions Bot changed the title Docs updates for E/A#88609 GPS pause resume and save flow [No QA] Docs updates for E/A#88609 GPS pause resume and save flow May 11, 2026
@OSBotify
Copy link
Copy Markdown
Contributor

OSBotify commented May 11, 2026

A preview of your ExpensifyHelp changes have been deployed to https://29c0c097.helpdot.pages.dev ⚡️

Updated articles:

@stephanieelliott stephanieelliott self-assigned this May 12, 2026
@stephanieelliott stephanieelliott requested a review from a team May 15, 2026 02:33
@melvin-bot
Copy link
Copy Markdown

melvin-bot Bot commented May 15, 2026

Concierge reviewer checklist:

  • I have verified the accuracy of the article
    • The article is within a hub that makes sense, and the navigation is correct
    • All processes, screenshots, and examples align with current product behavior.
    • All links within the doc have been verified for correct destination and functionality.
  • I have verified the readability of the article
    • The article's language is clear, concise, and free of jargon.
    • The grammar, spelling, and punctuation are correct.
    • The article contains at least one image, or that an image is not necessary
  • I have verified the formatting of the article
    • The article has consistent formatting (headings, bullet points, etc.) with other HelpDot articles and that aligns with the HelpDot formatting standards.
    • The article has proper text spacing and breaks for readability.
  • I have verified the article has the appropriate tone and style
    • The article's tone is professional, friendly, and suitable for the target audience.
    • The article's tone, terminology, and voice are consistent throughout.
  • I have verified the overall quality of the article
    • The article is not missing any information, nor does it contain redundant information.
    • The article fully addresses user needs.
  • I have verified that all requested improvements have been addressed

For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member?

cc @VictoriaExpensify

@melvin-bot melvin-bot Bot requested a review from VictoriaExpensify May 15, 2026 02:34
@melvin-bot
Copy link
Copy Markdown

melvin-bot Bot commented May 15, 2026

@VictoriaExpensify Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot Bot removed the request for review from a team May 15, 2026 02:34
5. Tap **Stop** when you arrive.
6. (Optional) To continue the trip from a new location, tap **Resume**. Each resumed section appears as a separate segment on the map. Tap **Stop** again when you're done.
7. To discard the trip, tap the trash icon next to the distance counter and confirm.
8. To save the trip, review the route summary showing your start and end addresses, then tap **Save**.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Step formatting / structure: Steps 7 and 8 describe two mutually exclusive actions (discard vs. save) placed inside a single numbered sequence. Per the Step Formatting Standard (HELP_AUTHORING_GUIDELINES.md Section 5), numbered steps must be sequential and aligned with the actual UI flow. Consider moving the discard instruction out of the numbered steps — for example, as a note or separate paragraph after the procedure — so the numbered list stays on the happy path (start → stop → optionally resume → save → create).

@github-actions
Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment

This PR updates two documentation files to reflect the new GPS pause/resume functionality for distance tracking. The changes are well-scoped, covering step renumbering, new UI button references, keyword updates, and FAQ clarifications. The edits are focused and align with the single-workflow principle.

Scores Summary

  • Readability: 9/10 - Steps are clear, sequential, and action-oriented. The optional Resume step is cleanly introduced with "(Optional)" prefix. The discard instruction in step 7 is straightforward.
  • AI Readiness: 9/10 - Keywords updated appropriately with new terms (pause GPS, resume GPS, multi-segment trip, discard trip). The internalScope and description remain accurate. Headings are unchanged and already compliant.
  • Style Compliance: 8/10 - Button names are correctly bolded (Stop, Resume, Save, Start, Create expense). One minor issue: the discard action in Distance-Expenses.md step 7 references "the trash icon" -- this is a UI element reference that could be more precise per naming conventions (exact icon label if one exists in the UI). Additionally, the cross-link in Create-an-Expense.md uses a full URL rather than a relative link, but this is pre-existing and not introduced by this PR.

Key Findings

  • The removal of the "Stop GPS tracking" confirmation dialog reference and replacement with the simpler "Tap Stop" correctly reflects the updated UI flow.
  • The new "(Optional)" step for Resume is well-structured and does not disrupt the main procedural flow.
  • Keywords in Distance-Expenses.md were updated to remove stale terms (save for later, in-progress odometer, incomplete odometer) and add relevant new ones (pause GPS, resume GPS, multi-segment trip, discard trip) -- good practice for search discoverability.
  • The FAQ update about multi-segment receipts is a useful addition that anticipates user questions.
  • Button name change from Next to Save in step 7/8 appears to reflect an actual UI change -- this is correctly documented.

Recommendations

  • Verify that "the trash icon" in step 7 of Distance-Expenses.md matches the exact UI element. If the icon has a tooltip or accessible label, consider referencing it more precisely per the naming conventions (e.g., "tap the delete icon" or whatever the UI shows on hover/accessibility).
  • No other blocking issues found. The changes are clean and well-aligned with governance standards.

Files Reviewed

  • docs/articles/new-expensify/reports-and-expenses/Create-an-Expense.md -- Steps updated for pause/resume flow; compliant with authoring guidelines.
  • docs/articles/new-expensify/reports-and-expenses/Distance-Expenses.md -- Keywords, intro, steps, and FAQ updated; metadata properly maintained.

Review based on docs/HELP_AUTHORING_GUIDELINES.md, docs/HELPSITE_NAMING_CONVENTIONS.md, and docs/TEMPLATE.md governance standards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants