[Payment due @huult] Send analytic events to Reddit, Meta, & Linkedin by youssef-lr · Pull Request #88759 · Expensify/App

youssef-lr · 2026-04-25T01:10:18Z

Explanation of Change

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/626849
PROPOSAL:

Tests

Verify that no errors appear in the JS console

Open NewDot on Web and have the Network tab open
Sign up as a new user and finish onboarding
Search in the network tab for "reddit", "linkedin", and "facebook".
Verify conversion events have been fired

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
I added steps for local testing in the Tests section
I added steps for the expected offline behavior in the Offline steps section
I added steps for Staging and/or Production testing in the QA steps section
I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I verified there are no new alerts related to the canBeMissing param for useOnyx
I followed proper code patterns (see Reviewing the code)
I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
I verified that comments were added to code that is not self explanatory
I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
A similar style doesn't already exist
The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If new assets were added or existing ones were modified, I verified that:
The assets are optimized and compressed (for SVG files, run npm run compress-svg)
The assets load correctly across all supported platforms.
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
I verified that all the inputs inside a form are aligned with each other.
I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

codecov · 2026-04-25T01:23:02Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/CONST/index.ts	`92.30% <ø> (ø)`
src/libs/GoogleTagManager/index.native.ts	`100.00% <100.00%> (ø)`
...pNavigator/Navigators/OnboardingModalNavigator.tsx	`89.36% <100.00%> (+0.23%)`	⬆️
src/libs/actions/IOU/TrackExpense.ts	`80.64% <100.00%> (ø)`
src/libs/actions/PaymentMethods.ts	`26.49% <100.00%> (ø)`
src/libs/actions/Policy/Policy.ts	`69.11% <100.00%> (-0.32%)`	⬇️
src/libs/GoogleTagManager/index.ts	`0.00% <0.00%> (ø)`
... and 11 files with indirect coverage changes

melvin-bot · 2026-05-01T01:34:50Z

@ChavdaSachin Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

youssef-lr · 2026-05-12T20:54:55Z

@huult I added test steps and the build is ready above

huult · 2026-05-13T02:38:33Z

Screen.Recording.2026-05-13.at.09.24.39.mov

Screen.Recording.2026-05-13.at.09.36.40.mov

@youssef-lr I didn’t see any reddit, linkedin, or facebook requests in the Network tab. I also checked and window.dataLayer is undefined. Could you check why window.dataLayer is not initialized?

youssef-lr · 2026-05-13T02:41:03Z

ah you might need to test this in dev, and hardcode this to true, I'll figure out why third party scripts are not loading in adhoc builds.

huult · 2026-05-13T03:01:10Z

Screen.Recording.2026-05-13.at.09.58.47.mov

Here is the result on my side. Facebook does not appear, Reddit can be seen without any blocking, and LinkedIn appears but is blocked

youssef-lr · 2026-05-13T03:04:54Z

oh, do you have an adblocker? if yes you need to turn it off to test this

huult · 2026-05-13T03:18:27Z

Screen.Recording.2026-05-13.at.10.16.23.mov

ahh yes

youssef-lr · 2026-05-13T22:27:26Z

bump @huult! all good?

huult · 2026-05-14T02:50:30Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2026-05-14.at.10.05.40.mov

huult · 2026-05-14T03:08:46Z

+            PRODUCT_TRAINING_SCAN_TEST_TOOLTIP_SHOWN: 'training_scan_test_tooltip_shown',
+            PRODUCT_TRAINING_SCAN_TEST_TOOLTIP_DISMISSED: 'training_scan_test_tooltip_dismissed',
+            PRODUCT_TRAINING_SCAN_TEST_TOOLTIP_CONFIRMED: 'training_scan_test_tooltip_confirmed',


I couldn’t find where PRODUCT_TRAINING_SCAN_TEST_TOOLTIP_SHOWN, PRODUCT_TRAINING_SCAN_TEST_TOOLTIP_DISMISSED, and PRODUCT_TRAINING_SCAN_TEST_TOOLTIP_CONFIRMED are used in the source code. Could you remove them?

They were reverted from main. They remained in my PR after a bad conflict resolution probably. Removing now.

huult · 2026-05-14T03:12:48Z

bump @huult! all good?

Everything looks good. I tested it and it works. Only the comment above is left. After that is resolved, we can merge.

huult

LGTM.

melvin-bot · 2026-05-14T03:18:05Z

@tylerkaraszewski Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot · 2026-05-14T03:18:06Z

🎯 @huult, thanks for reviewing and testing this PR! 🎉

A payment issue will be created for your review once this PR is deployed to production.
E/E issue linked to the PR - https://www.github.com/Expensify/Expensify/issues/626849.

If payment is not needed (e.g., regression PR review fix etc), react with 👎 to this comment to prevent the payment issue from being created.

tylerkaraszewski · 2026-05-14T16:26:51Z

Why are the perf tests failing?

OSBotify · 2026-05-14T20:29:12Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-05-14T20:31:49Z

🚧 @tylerkaraszewski has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-05-14T20:37:16Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #88759.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-8ce9d61-e0d82ac-c6f1b00a50c5ce671bea459aee1dee1ff0f02fe9/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-8ce9d61-e0d82ac-edfb5206b3a1edf1c39fcd8ca8bd87ef8c31a0c5/index.html

Web 🕸️
https://88759.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-05-15T17:23:12Z

🚀 Deployed to staging by https://github.com/tylerkaraszewski in version: 9.3.74-7 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

MelvinBot · 2026-05-15T17:25:34Z

No help site changes are required for this PR.

This PR adds conversion pixel tracking (Reddit, Meta, LinkedIn) alongside existing Google Tag Manager analytics events. The changes are purely internal — restructuring analytics constants, extending the publishEvent function signature, and firing additional ad platform pixels. No user-facing features, UI, or behavior are affected.

OSBotify · 2026-05-15T18:08:22Z

🚀 Deployed to production by https://github.com/Beamanator in version: 9.3.74-7 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

melvin-bot · 2026-05-15T18:19:50Z

🤖 Payment issue created: #90824

youssef-lr added 3 commits April 21, 2026 23:48

Add email to GTM events

f0a3303

Log email string

6efc348

Send analytic events to Reddit, Meta, & Linkedin

d8b322b

melvin-bot Bot assigned youssef-lr Apr 25, 2026

Add comment

b3a8495

youssef-lr added 6 commits April 28, 2026 22:36

Add LinkedIn conversion IDs

e488cb2

Merge branch 'youssef_add_email_gtm_event' into youssef_pixel_events

7ea2986

Add email to conversion events

611695d

Add eventID

882f3bb

Naming

1faa228

Cleanup code and include event IDs

4a9a817

youssef-lr mentioned this pull request Apr 30, 2026

Add email to GTM events #88493

Closed

54 tasks

youssef-lr added 6 commits April 30, 2026 05:06

Merge branch 'main' into youssef_pixel_events

f3b4274

Fix test & eslint

0c6d928

Merge branch 'main' into youssef_pixel_events

e602170

Fix another test

16d5ab3

Remove no longer needed NVPs

ef529dd

Add email to meta event

885c652

youssef-lr requested a review from huult May 1, 2026 01:34

youssef-lr marked this pull request as ready for review May 1, 2026 01:34

youssef-lr requested review from a team as code owners May 1, 2026 01:34

melvin-bot Bot requested review from ChavdaSachin and heyjennahay and removed request for a team and heyjennahay May 1, 2026 01:34

melvin-bot Bot removed the request for review from a team May 1, 2026 01:34

youssef-lr removed the request for review from ChavdaSachin May 1, 2026 01:34

huult reviewed May 14, 2026

View reviewed changes

Remove unused consts

09de980

huult approved these changes May 14, 2026

View reviewed changes

melvin-bot Bot requested a review from tylerkaraszewski May 14, 2026 03:18

melvin-bot Bot changed the title ~~Send analytic events to Reddit, Meta, & Linkedin~~ [Payment due @huult] Send analytic events to Reddit, Meta, & Linkedin May 14, 2026

Merge branch 'main' into youssef_pixel_events

3fe93ff

tylerkaraszewski approved these changes May 14, 2026

View reviewed changes

tylerkaraszewski merged commit 8ce9d61 into main May 14, 2026
38 checks passed

tylerkaraszewski deleted the youssef_pixel_events branch May 14, 2026 20:18

OSBotify mentioned this pull request May 15, 2026

Deploy Checklist: New Expensify 2026-05-15 #90795

Closed

melvin-bot Bot mentioned this pull request May 15, 2026

[Due for payment 2026-05-22] Payment issue for E/App PR#88759 #90824

Closed

Uh oh!

Conversation

youssef-lr commented Apr 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov Bot commented Apr 25, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot Bot commented May 1, 2026

Uh oh!

youssef-lr commented May 12, 2026

Uh oh!

huult commented May 13, 2026

Uh oh!

youssef-lr commented May 13, 2026

Uh oh!

huult commented May 13, 2026

Uh oh!

youssef-lr commented May 13, 2026

Uh oh!

huult commented May 13, 2026

Uh oh!

youssef-lr commented May 13, 2026

Uh oh!

huult commented May 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

huult May 14, 2026

Choose a reason for hiding this comment

Uh oh!

youssef-lr May 14, 2026

Choose a reason for hiding this comment

Uh oh!

huult commented May 14, 2026

Uh oh!

huult left a comment

Choose a reason for hiding this comment

Uh oh!

melvin-bot Bot commented May 14, 2026

Uh oh!

melvin-bot Bot commented May 14, 2026

Uh oh!

tylerkaraszewski commented May 14, 2026

Uh oh!

Uh oh!

OSBotify commented May 14, 2026

Uh oh!

github-actions Bot commented May 14, 2026

Uh oh!

github-actions Bot commented May 14, 2026

Uh oh!

OSBotify commented May 15, 2026

Uh oh!

MelvinBot commented May 15, 2026

Uh oh!

OSBotify commented May 15, 2026

Uh oh!

melvin-bot Bot commented May 15, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

youssef-lr commented Apr 25, 2026 •

edited

Loading

codecov Bot commented Apr 25, 2026 •

edited by github-actions Bot

Loading

huult commented May 14, 2026 •

edited

Loading