Show Unreported status badge for expenses without a report by MelvinBot · Pull Request #88851 · Expensify/App

MelvinBot · 2026-04-27T03:36:17Z

Explanation of Change

When expenses in a personal chat are not yet on an expense report, stateNum and statusNum are undefined. Previously, getReportStatusTranslation returned an empty string and getReportStatusColorStyle returned undefined in this case, causing StatusCell to render nothing — leaving visible but empty Status column cells.

This PR changes both fallbacks so that undefined state/status values now return an "Unreported" label and a neutral badge style, ensuring every expense row displays a meaningful status. The unreported badge style is added to both light and dark themes.

Fixed Issues

$ #88007
PROPOSAL: #88007 (comment)

Tests

Go to a Self DM.
Create an expense.
Navigate to Spend Tab → Expenses.
Verify that expenses which have not yet been reported display an Unreported status badge:
- In the Status column on web
- In the expense row on mobile
Verify that no Status column / expense row appears with an empty status cell.

Verify that no errors appear in the JS console

Offline tests

N/A — this change only affects how existing Onyx data is rendered; no network calls are added or modified.

QA Steps

Go to a Self DM.
Create an expense.
Navigate to Spend Tab → Expenses.
Verify that expenses which have not yet been reported display an Unreported status badge:
- In the Status column on web
- In the expense row on mobile
Verify that no Status column / expense row appears with an empty status cell.

Verify that no errors appear in the JS console

PR Author Checklist

AI Tests

typecheck (tsgo): Passed
prettier: Passed (all changed files unchanged)
eslint: Pre-existing warnings only (Onyx.connect deprecation in ReportUtils.ts) — no new issues
jest (ReportUtilsTest): Passed (900/900)

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

When expenses in personal chat are not yet reported, the Status column shows empty cells because stateNum/statusNum are undefined. Change the fallback in getReportStatusTranslation and getReportStatusColorStyle to return an "Unreported" badge instead of empty values. Add the unreported badge style to both light and dark themes. Co-authored-by: Jayesh Mangwani <jayeshmangwani@users.noreply.github.com>

jayeshmangwani · 2026-04-27T06:21:40Z

@shawnborton Adding the screenshots below for confirmation of the new unreported badge.

We have used the following colors for the light theme:

unreported: {
    backgroundColor: colors.productLight400,
    textColor: colors.productLight900,
},

We have used the following colors for the dark theme:

unreported: {
    backgroundColor: colors.productDark400,
    textColor: colors.productDark900,
},

light theme screenshots with high contrast and without it:

dark theme screenshots with high contrast and without it:

shawnborton · 2026-04-27T07:16:47Z

I think I would use the same exact colors here as our default badges:

Which use the same colors as our default buttons. Let me know if that makes sense!

shawnborton · 2026-04-27T07:17:21Z

So yeah, I think what you have above is good, but just noting we could use the button color variables if we wanted to be more specific.

jayeshmangwani · 2026-04-27T12:02:00Z

Makes sense, @MelvinBot update the colors to use the existing default buttons colors, check this comment for reference: #88851 (comment)

Co-authored-by: Jayesh Mangwani <jayeshmangwani@users.noreply.github.com>

MelvinBot · 2026-04-27T12:05:15Z

Updated the unreported badge text colors to match the default badge/button colors:

Dark theme: productDark800 → productDark900 (matches theme.text)
Light theme: productLight800 → productLight900 (matches theme.text)

The background colors (productDark400 / productLight400) already matched badgeDefaultBG, so only the text colors needed updating.

github-actions · 2026-04-27T12:12:55Z

🚧 @shawnborton has triggered a test Expensify/App build. You can view the workflow run here.

shawnborton · 2026-04-27T12:25:22Z

This works great for me 👍

jayeshmangwani · 2026-04-27T12:43:55Z

@MelvinBot , please add the tests below to the checklist. I can’t edit the PR description, so you’ll need to check all the boxes there.

Go to a Self DM.
Create an expense.
Navigate to Spend Tab → All expenses.
Observe the displayed columns.
Verify that expenses that are not yet reported display an Unreported status badge in the Status column. The Status column should always be visible, and no row should appear with an empty status cell.

MelvinBot · 2026-04-27T12:46:02Z

Done — updated the PR description with the test steps in both the Tests and QA Steps sections, and checked all the checklist boxes.

jayeshmangwani · 2026-04-28T08:03:50Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

Simulator Screenshot - iPhone 17 Pro - 2026-05-02 at 00 51 33

iOS: mWeb Safari

Simulator Screenshot - iPhone 17 Pro - 2026-05-02 at 00 44 53

MacOS: Chrome / Safari

jayeshmangwani · 2026-04-28T08:04:05Z

@MelvinBot make PR ready for review

MelvinBot · 2026-04-28T08:05:22Z

I wasn't able to mark the PR as ready for review due to a permissions restriction in my current environment. You can do it yourself by clicking "Ready for review" on the PR page, or by running:

gh pr ready 88851 --repo Expensify/App

jayeshmangwani · 2026-04-28T08:06:36Z

@MelvinBot Please mark it as "Ready for review"

MelvinBot · 2026-04-28T08:07:53Z

Marked this PR as Ready for review ✅

melvin-bot · 2026-04-28T08:07:55Z

@jayeshmangwani Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

jayeshmangwani

LGTM 🚀

melvin-bot · 2026-04-28T08:08:25Z

We did not find an internal engineer to review this PR, trying to assign a random engineer to #88007 as well as to this PR... Please reach out for help on Slack if no one gets assigned!

melvin-bot · 2026-04-28T08:08:35Z

@madmax330 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

cead22 · 2026-04-28T23:39:44Z

@jayeshmangwani do the manual tests need to be updated? I don't see the unreported badge on your mobile web screenshot

cead22 · 2026-04-30T22:22:52Z

@jayeshmangwani bump

jayeshmangwani · 2026-05-01T12:09:03Z

Sorry, I was OOO and delayed in seeing your comment.

jayeshmangwani · 2026-05-01T12:19:38Z

@MelvinBot, please update the 4th step to clarify that this is a web-only change, as mobile devices do not have the column options.

MelvinBot · 2026-05-01T12:22:09Z

Updated step 4 in both Tests and QA Steps to clarify this is a web-only change, since mobile devices do not have the column options.

jayeshmangwani · 2026-05-01T12:25:39Z

@cead22, this is a web-only change since mobile devices don’t have the column displayed. We also don’t show status badge on the Spent page’s expense rows, and although report rows under Spend -> All reports have status badge, there’s no Unreported filter option for reports. Because of that, this cannot be tested on mobile for expenses or reports.

I’ve updated the Tests section to note that this should only be verified on the web.

shawnborton · 2026-05-01T13:07:41Z

@jayeshmangwani we show the status on expense rows on mobile now:

jayeshmangwani · 2026-05-01T19:24:54Z

@MelvinBot Please update the Tests and QA sections as below.

Go to a Self DM.
Create an expense.
Navigate to Spend Tab → Expenses.
Verify that expenses which have not yet been reported display an Unreported status badge:
- In the Status column on web
- In the expense row on mobile
Verify that no Status column / expense row appears with an empty status cell.

jayeshmangwani · 2026-05-01T19:26:29Z

@shawnborton Tested on the latest main, and I can now see the status badge for the expense row.

MelvinBot · 2026-05-01T19:28:39Z

Updated the Tests and QA Steps sections as requested.

jayeshmangwani · 2026-05-01T19:37:06Z

@cead22 , updated the tests and screenshots to reflect the latest badge displayed in the expense row:

Android

iOS

mWeb chrome

mWeb safari

cead22 · 2026-05-02T00:31:03Z

Great, thank you!

github-actions · 2026-05-02T00:41:34Z

🚧 @cead22 has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-05-02T00:45:48Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #88851.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-1dd01da-34a8d39-542fc1eaec6496aba20f8c36fa6d87872738087b/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-1dd01da-34a8d39-ed261a1f48bd2e4ba6467e46b1d3de5f22f14b98/index.html

Web 🕸️
https://88851.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-05-02T00:48:52Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-05-04T13:27:59Z

🚀 Deployed to staging by https://github.com/cead22 in version: 9.3.66-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	cancelled 🔪
🍎 iOS 🍎	cancelled 🔪

MelvinBot · 2026-05-04T13:29:42Z

No help site changes are required for this PR.

This PR adds a visible "Unreported" status badge for expenses not yet on a report — the help site already documents this concept:

Getting Started with the Spend Page already lists Status (e.g. Unreported) as an expense filter and references "unreported expenses" throughout (default view, smart suggestions)
Understanding Report Statuses and Actions mentions expenses becoming "Unreported" after a report is deleted

The change is purely visual (badge where there was previously a blank cell), so no new workflows or features need documenting.

mitarachim · 2026-05-04T15:31:13Z

Deploy Blocker #89519 was identified to be related to this PR.

MelvinBot assigned jayeshmangwani Apr 27, 2026

MelvinBot requested a review from a team April 27, 2026 03:36

MelvinBot mentioned this pull request Apr 27, 2026

[$250] Status Column Displayed in Expense List Even When No Expenses Have a Status #88007

Open

7 tasks

Update unreported badge text colors to match default badge colors

9107a13

Co-authored-by: Jayesh Mangwani <jayeshmangwani@users.noreply.github.com>

This comment has been minimized.

Sign in to view

MelvinBot marked this pull request as ready for review April 28, 2026 08:07

MelvinBot requested review from a team as code owners April 28, 2026 08:07

melvin-bot Bot requested review from heyjennahay and jayeshmangwani April 28, 2026 08:07

melvin-bot Bot requested review from a team and removed request for a team April 28, 2026 08:07

jayeshmangwani approved these changes Apr 28, 2026

View reviewed changes

melvin-bot Bot requested review from madmax330 and removed request for a team April 28, 2026 08:08

melvin-bot Bot requested a review from cead22 April 28, 2026 08:08

madmax330 removed their request for review April 30, 2026 19:42

cead22 approved these changes May 2, 2026

View reviewed changes

cead22 merged commit 1dd01da into main May 2, 2026
55 of 57 checks passed

cead22 deleted the claude-unreportedStatusBadge branch May 2, 2026 00:40

OSBotify mentioned this pull request May 4, 2026

Deploy Checklist: New Expensify 2026-05-04 #89508

Open

75 tasks

mitarachim mentioned this pull request May 4, 2026

Expense - Unreported badge background is not visible when expense is selected #89519

Open

7 tasks

Conversation

MelvinBot commented Apr 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

jayeshmangwani commented Apr 27, 2026

Uh oh!

shawnborton commented Apr 27, 2026

Uh oh!

shawnborton commented Apr 27, 2026

Uh oh!

jayeshmangwani commented Apr 27, 2026

Uh oh!

MelvinBot commented Apr 27, 2026

Uh oh!

github-actions Bot commented Apr 27, 2026

Uh oh!

This comment has been minimized.

shawnborton commented Apr 27, 2026

Uh oh!

jayeshmangwani commented Apr 27, 2026

Uh oh!

MelvinBot commented Apr 27, 2026

Uh oh!

jayeshmangwani commented Apr 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

jayeshmangwani commented Apr 28, 2026

Uh oh!

MelvinBot commented Apr 28, 2026

Uh oh!

jayeshmangwani commented Apr 28, 2026

Uh oh!

MelvinBot commented Apr 28, 2026

Uh oh!

melvin-bot Bot commented Apr 28, 2026

Uh oh!

jayeshmangwani left a comment

Choose a reason for hiding this comment

Uh oh!

melvin-bot Bot commented Apr 28, 2026

Uh oh!

melvin-bot Bot commented Apr 28, 2026

Uh oh!

cead22 commented Apr 28, 2026

Uh oh!

cead22 commented Apr 30, 2026

Uh oh!

jayeshmangwani commented May 1, 2026

Uh oh!

jayeshmangwani commented May 1, 2026

Uh oh!

MelvinBot commented May 1, 2026

Uh oh!

jayeshmangwani commented May 1, 2026

Uh oh!

shawnborton commented May 1, 2026

Uh oh!

jayeshmangwani commented May 1, 2026

Uh oh!

jayeshmangwani commented May 1, 2026

Uh oh!

MelvinBot commented May 1, 2026

Uh oh!

jayeshmangwani commented May 1, 2026

Uh oh!

cead22 commented May 2, 2026

Uh oh!

Uh oh!

github-actions Bot commented May 2, 2026

Uh oh!

github-actions Bot commented May 2, 2026

MelvinBot commented Apr 27, 2026 •

edited

Loading

jayeshmangwani commented Apr 28, 2026 •

edited

Loading