Follow up fixes for compact menu rows: fix bank account rows, Copilot rows, and QAB row#89156
Follow up fixes for compact menu rows: fix bank account rows, Copilot rows, and QAB row#89156
Conversation
…mpact menu styling Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…ompact mode Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
@cristipaval Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Nice! |
|
🚧 @arosiclair has triggered a test Expensify/App build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
|
Testing well for me. I'll ask QA to verify again once it hits staging. |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Follow up fixes for compact menu rows: fix bank account rows, Copilot rows, and QAB row (cherry picked from commit 7a8586c) (cherry-picked to staging by arosiclair)
|
🚧 @Julesssss has triggered a test Expensify/App build. You can view the workflow run here. |
|
🚀 Cherry-picked to staging by https://github.com/arosiclair in version: 9.3.64-18 🚀
Bundle Size Analysis (Sentry): |
|
This PR makes purely visual/styling adjustments — fixing row heights, padding, and compact menu styling for bank account rows, copilot switcher rows, and the quick action button row. No help site documentation changes are required. The help docs describe user workflows and navigation steps (e.g., "click Pay", "select a bank account"), not pixel-level styling details like row heights or padding. Since no functionality, feature names, navigation paths, or UI labels changed in this PR, the existing docs remain accurate. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
Verified fixed |
Explanation of Change
This fixes a couple of follow ups from the compact menu style changes:
cc @Expensify/design 4viz
Fixed Issues
$ #89129
PROPOSAL: N/A
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
N/A
Android: mWeb Chrome
N/A
iOS: Native
N/A
iOS: mWeb Safari
CleanShot.2026-04-29.at.10.04.59.mp4
MacOS: Chrome / Safari
CleanShot.2026-04-29.at.10.03.57.mp4