refactor: PureReportActionItem, push down 5 wrapper subscriptions into action leaves by LukasMod · Pull Request #89160 · Expensify/App

LukasMod · 2026-04-29T09:33:33Z

Explanation of Change

Removes 5 wrapper-level Onyx subscriptions from PureReportActionItem and inlines each into the leaf that consumes it. Non-matching rows (the dominant ADD_COMMENT case) stop paying for these subs.
REPORT_METADATA_<reportID> → ApprovalFlowContent (only SUBMITTED / APPROVED / FORWARDED rows)
PERSONAL_POLICY_ID → MentionWhisperContent (only mention-whisper rows)
REPORT_<parentReportID> → ReimbursementQueuedContent + ReportActionItemContentCreated
REPORT_<childReportID> → ApprovalFlowContent, ModifiedExpenseContent, MovedTransactionAction, UnreportedTransactionAction
POLICY_<policyID> → 6 leaves self-subscribe directly: ApprovalFlowContent, PaymentContent, PolicyChangeLogContent, JoinRequestContent, MentionWhisperContent, IssueCardMessage

Fixed Issues

$ #89196
PROPOSAL:

Tests

Verify that no errors appear in the JS console

Smoke tests

Test 1: Submitted / Approved / Forwarded action rendering

Log into an account that has at least one expense report which has been submitted, approved, and forwarded.
Open that expense report.
Verify the chat shows the system messages "submitted", "approved"

Test 2: Modified expense and moved/unreported transaction rendering

Open any expense and edit one of its fields (description, category, amount).
Go back to the chat and verify the "changed [field] to ..." message renders with the new value, links to the expense thread, and shows the expense thread's reply count if any.
Move an expense to another report (via expense detail page, "Move expense").
Open the destination report, then open the moved expense's thread. Verify the thread shows a "moved this expense from {source report}" message with a clickable link back to the source report

Test 3: Mention whisper handling

In a workspace chat, @mention a user who is NOT a member of that workspace.
Verify the whisper "Do you want to invite ... to this workspace?" appears and is only visible to you.
Click "Invite". The user is invited and the whisper disappears.

Test 4: Reimbursement queued

As account A, pay an expense submitted by account B via a payment method that requires B to set up something on their side (e.g. pay via VBBA when B has no personal bank account).
Switch to account B and open the IOU/expense chat.
Verify the chat shows a REIMBURSEMENT_QUEUED message → "{A} started payment, but is waiting for {B} to add a bank account." with an Add bank account button.

Test 5: Created thread rendering

From any chat, open a thread on a report action (click the reply count or "view thread").
Verify the thread header and the "created" system message at the top render correctly with the parent report's name and link back to the parent.

Test 6: Workspace settings

As a workspace admin, change one workspace setting (default category, description, currency).
Verify the workspace #admins room or the settings change log shows the appropriate "updated [setting] to ..." message rendered correctly.

Test 7: Issue card message rendering

Prerequisites:

Add bank account
Create workspace, control plan and expensify cards
Invite another member to workspace

Steps:

In an Expensify Card-enabled workspace, issue a new card to a member.
Look for a chat named like "{B's display name}'s expenses" or "{B's name} (Workspace)". Visible to admins of that workspace. User B has to create expense so chat can shows up.
Verify the "[Admin] issued [member] an Expensify Card" message renders correctly for user A (admin) and user B (non-admin)

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Verify that no errors appear in the JS console

Same as tests

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Test 1

test1.mov

Test 2

test2.mov

Test 3

test3.mov

Test 4

test4.mov

Test 5

test5.mov

Test 6

test6.mov

Test 7

test7.mov

codecov · 2026-04-29T09:47:24Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
...c/components/ReportActionItem/IssueCardMessage.tsx	`91.30% <100.00%> (+0.82%)`	⬆️
...onents/ReportActionItem/MovedTransactionAction.tsx	`100.00% <100.00%> (ø)`
...s/ReportActionItem/UnreportedTransactionAction.tsx	`100.00% <100.00%> (ø)`
src/pages/inbox/report/PureReportActionItem.tsx	`79.53% <100.00%> (-0.26%)`	⬇️
src/pages/inbox/report/ReportActionItem.tsx	`100.00% <ø> (ø)`
...es/inbox/report/ReportActionItemContentCreated.tsx	`39.34% <100.00%> (+1.01%)`	⬆️
...nbox/report/actionContents/ApprovalFlowContent.tsx	`97.56% <100.00%> (+0.19%)`	⬆️
...inbox/report/actionContents/JoinRequestContent.tsx	`83.33% <100.00%> (+1.51%)`	⬆️
...ox/report/actionContents/MentionWhisperContent.tsx	`71.87% <100.00%> (+1.87%)`	⬆️
...x/report/actionContents/ModifiedExpenseContent.tsx	`100.00% <100.00%> (ø)`
... and 3 more
... and 7 files with indirect coverage changes

LukasMod · 2026-04-30T07:13:12Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1e098ec9fc

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

… to ReimbursementQueuedContent

…emContentCreated

LukasMod · 2026-04-30T10:32:54Z

@codex review

chatgpt-codex-connector · 2026-04-30T10:42:26Z

Codex Review: Didn't find any major issues. Keep it up!

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

melvin-bot · 2026-04-30T10:57:51Z

@Pujan92 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

trjExpensify · 2026-04-30T22:22:50Z

PR doesn’t need product input as a refactor PR. Unassigning and unsubscribing myself.

Pujan92 · 2026-05-02T12:41:52Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

MacOS: Chrome / Safari

Test 1

Test 2

Screen.Recording.2026-05-02.at.18.57.24.mov

Test 3

Screen.Recording.2026-05-02.at.18.58.46.mov

Test 4

Test 5

Screen.Recording.2026-05-02.at.19.00.04.mov

Test 6

Screen.Recording.2026-05-02.at.19.01.06.mov

Test 7

Pujan92

LGTM!

melvin-bot · 2026-05-04T08:10:11Z

@cristipaval looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

github-actions · 2026-05-04T08:10:43Z

🚧 @cristipaval has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-05-04T08:14:56Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #89160.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-0e6c06c-34a8d39-542fc1eaec6496aba20f8c36fa6d87872738087b/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-0e6c06c-34a8d39-ed261a1f48bd2e4ba6467e46b1d3de5f22f14b98/index.html

Web 🕸️
https://89160.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

Two test sites in PureReportActionItemTest were missed during the prop cleanup in Expensify#89160. Co-authored-by: Cursor <cursoragent@cursor.com>

OSBotify · 2026-05-04T13:28:23Z

🚀 Deployed to staging by https://github.com/cristipaval in version: 9.3.66-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	cancelled 🔪
🍎 iOS 🍎	cancelled 🔪

MelvinBot · 2026-05-04T13:29:39Z

No help site changes are required for this PR.

This is a purely internal refactoring that pushes down 5 wrapper-level Onyx subscriptions from PureReportActionItem into the leaf components that consume them. It changes how React components subscribe to data for performance, but introduces no changes to user-facing behavior, UI text, features, or workflows.

melvin-bot Bot assigned LukasMod Apr 29, 2026

LukasMod force-pushed the perf-pushdown-per-action-subs branch 2 times, most recently from c595b14 to 0427001 Compare April 29, 2026 10:34

LukasMod mentioned this pull request Apr 29, 2026

Push remaining PureReportActionItem subscriptions into leaf components #89164

Open

cristipaval mentioned this pull request Apr 29, 2026

Push 5 wrapper subscriptions into action leaves #89196

Open

chatgpt-codex-connector Bot reviewed Apr 30, 2026

View reviewed changes

Comment thread src/pages/inbox/report/ReportActionItemMessage.tsx Outdated

LukasMod added 7 commits April 30, 2026 12:28

refactor: move bankAccountList and missingPaymentMethod subscriptions…

04770de

… to ReimbursementQueuedContent

refactor: move ReimbursementQueuedContent to actionContents

9a4cf69

refactor: reportMetadata to ApprovalFlowContent

83a6101

refactor: personalPolicyID to MentionWhisperContent

b9e713e

refactor: parentReport to ReimbursementQueuedContent + ReportActionIt…

c2089b3

…emContentCreated

refactor: push down childReport subscription

5757690

refactor: push down policy subscription into action leaves

312a781

LukasMod force-pushed the perf-pushdown-per-action-subs branch from 1e098ec to 312a781 Compare April 30, 2026 10:32

LukasMod changed the title ~~refactor: PureReportActionItem, push down 5 wrapper subscriptions into action leaves [HOLD]~~ refactor: PureReportActionItem, push down 5 wrapper subscriptions into action leaves Apr 30, 2026

LukasMod marked this pull request as ready for review April 30, 2026 10:57

LukasMod requested review from a team as code owners April 30, 2026 10:57

melvin-bot Bot requested review from Pujan92 and trjExpensify and removed request for a team April 30, 2026 10:57

melvin-bot Bot removed the request for review from a team April 30, 2026 10:57

trjExpensify removed their request for review April 30, 2026 22:22

Pujan92 approved these changes May 2, 2026

View reviewed changes

melvin-bot Bot requested a review from cristipaval May 2, 2026 13:36

cristipaval approved these changes May 4, 2026

View reviewed changes

cristipaval merged commit 0e6c06c into Expensify:main May 4, 2026
46 checks passed

melvin-bot Bot added the Emergency label May 4, 2026

github-actions Bot mentioned this pull request May 4, 2026

Investigate workflow job failing on main: typecheck / typecheck #89471

Closed

cristipaval mentioned this pull request May 4, 2026

[No QA] Fix typecheck in main: remove leftover personalPolicyID prop from tests #89474

Merged

53 tasks

OSBotify mentioned this pull request May 4, 2026

Deploy Checklist: New Expensify 2026-05-04 #89508

Open

75 tasks

lanitochka17 mentioned this pull request May 4, 2026

Thread - Inconsistent system message and thread header after inviting member to workspace. #89546

Open

7 tasks

Conversation

LukasMod commented Apr 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Test 1: Submitted / Approved / Forwarded action rendering

Test 2: Modified expense and moved/unreported transaction rendering

Test 3: Mention whisper handling

Test 4: Reimbursement queued

Test 5: Created thread rendering

Test 6: Workspace settings

Test 7: Issue card message rendering

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov Bot commented Apr 29, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

LukasMod commented Apr 30, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

LukasMod commented Apr 30, 2026

Uh oh!

chatgpt-codex-connector Bot commented Apr 30, 2026

Uh oh!

melvin-bot Bot commented Apr 30, 2026

Uh oh!

trjExpensify commented Apr 30, 2026

Uh oh!

Pujan92 commented May 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

Pujan92 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

melvin-bot Bot commented May 4, 2026

Uh oh!

github-actions Bot commented May 4, 2026

Uh oh!

github-actions Bot commented May 4, 2026

Uh oh!

OSBotify commented May 4, 2026

Uh oh!

MelvinBot commented May 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

LukasMod commented Apr 29, 2026 •

edited

Loading

codecov Bot commented Apr 29, 2026 •

edited by github-actions Bot

Loading

Pujan92 commented May 2, 2026 •

edited

Loading