Skip to content

[No QA] [NO QA] Docs updates for E/A#87395 Add mobile Concierge icon help access#89325

Merged
VictoriaExpensify merged 3 commits into
mainfrom
claude-docsUpdateConciergeMobileHelp
May 7, 2026
Merged

[No QA] [NO QA] Docs updates for E/A#87395 Add mobile Concierge icon help access#89325
VictoriaExpensify merged 3 commits into
mainfrom
claude-docsUpdateConciergeMobileHelp

Conversation

@MelvinBot
Copy link
Copy Markdown
Contributor

Summary

  • Updates Concierge-Basics.md and Support-Agent.md to document the new Concierge icon button on native mobile
  • PR feat: Add Concierge help button on mobile native app #87395 adds a Concierge help button to the native mobile header bar, giving mobile users the same quick-access icon that web users already have
  • The existing Account > Help > Concierge path is preserved as an alternative

Test plan

Update Concierge-Basics.md and Support-Agent.md to document the new
Concierge icon button available on native mobile, matching the web
experience.

Co-authored-by: Ryan Teguh <ryntgh@users.noreply.github.com>
@stephanieelliott stephanieelliott added the HelpDot Apply this label if the issue relates to ExpensifyHelp label May 6, 2026
@stephanieelliott stephanieelliott self-assigned this May 6, 2026
@stephanieelliott stephanieelliott marked this pull request as ready for review May 6, 2026 23:19
@stephanieelliott stephanieelliott self-requested a review as a code owner May 6, 2026 23:19
@stephanieelliott stephanieelliott requested a review from a team May 6, 2026 23:21
@melvin-bot
Copy link
Copy Markdown

melvin-bot Bot commented May 6, 2026

Concierge reviewer checklist:

  • I have verified the accuracy of the article
    • The article is within a hub that makes sense, and the navigation is correct
    • All processes, screenshots, and examples align with current product behavior.
    • All links within the doc have been verified for correct destination and functionality.
  • I have verified the readability of the article
    • The article's language is clear, concise, and free of jargon.
    • The grammar, spelling, and punctuation are correct.
    • The article contains at least one image, or that an image is not necessary
  • I have verified the formatting of the article
    • The article has consistent formatting (headings, bullet points, etc.) with other HelpDot articles and that aligns with the HelpDot formatting standards.
    • The article has proper text spacing and breaks for readability.
  • I have verified the article has the appropriate tone and style
    • The article's tone is professional, friendly, and suitable for the target audience.
    • The article's tone, terminology, and voice are consistent throughout.
  • I have verified the overall quality of the article
    • The article is not missing any information, nor does it contain redundant information.
    • The article fully addresses user needs.
  • I have verified that all requested improvements have been addressed

For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member?

cc @VictoriaExpensify

@melvin-bot melvin-bot Bot requested review from VictoriaExpensify and removed request for a team May 6, 2026 23:21
@melvin-bot
Copy link
Copy Markdown

melvin-bot Bot commented May 6, 2026

@VictoriaExpensify Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

- **Web:** Click the chat icon in the top-right corner
- **Mobile:** Tap the hamburger menu in the top-left corner, then tap **Concierge**
- **Web:** Click the **Concierge** icon in the top-right corner.
- **Mobile:** Tap the **Concierge** icon at the top right corner of the screen, or go to **Account** > **Help** and select **Concierge**.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style inconsistency: Line 20 uses "top-right" (hyphenated) but this line uses "top right" (unhyphenated). Per the Deterministic Writing Rule in HELPSITE_NAMING_CONVENTIONS.md, be consistent — use the same form in both lines.

Suggested fix: Change "at the top right corner of the screen" to "in the top-right corner" to match the Web instruction above and keep phrasing consistent.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 6, 2026

HelpDot Documentation Review

Overall Assessment

This PR updates the "Where to find Concierge Support Agent" section to reflect a new mobile Concierge icon, consolidating the former "Account" bullet into the "Mobile" bullet and updating the "Web" bullet to reference the Concierge icon instead of a generic "chat icon." The changes are small, targeted, and improve specificity. A few minor style issues should be addressed.

Scores Summary

  • Readability: 8/10 - The consolidated instructions are clear and scannable. The Mobile bullet is slightly long due to combining two access paths with "or," but remains understandable.
  • AI Readiness: 7/10 - The changes use the full feature name ("Concierge") which aids retrieval. However, the article's YAML frontmatter is still missing the required internalScope field per HELP_AUTHORING_GUIDELINES.md Section 3. (This pre-dates this PR but is worth noting.)
  • Style Compliance: 7/10 - Two issues in the changed lines warrant attention (see Key Findings below).

Key Findings

  • Positive: Improved specificity. Changing "chat icon" to "Concierge icon" on the Web bullet aligns with the naming conventions rule to reference exact UI labels rather than generic descriptions. This is a clear improvement.
  • Positive: Logical consolidation. Merging the standalone "Account" bullet into the "Mobile" bullet makes sense since that navigation path is mobile-specific.
  • Issue: Inconsistent hyphenation. The Web bullet uses "top-right corner" (hyphenated) while the Mobile bullet uses "top right corner" (unhyphenated). These should match -- "top-right" (hyphenated) is the standard compound modifier form.
  • Issue: Missing hamburger menu phrasing. The Mobile bullet includes "go to Account > Help and select Concierge" as an alternative path, but per HELPSITE_NAMING_CONVENTIONS.md, mobile navigation through menus should follow the prescribed pattern: "On mobile, tap the hamburger menu in the top-left corner, then select [Tab name]." If reaching Account > Help requires the hamburger menu, the governance-mandated phrasing should be used. If it does not (e.g., the Account tab is directly accessible), the current phrasing is acceptable but should be verified against the actual UI flow.

Recommendations

  1. Fix hyphenation: Change "top right corner" to "top-right corner" in the Mobile bullet for consistency with the Web bullet.
  2. Verify Account > Help navigation: Confirm whether reaching Account > Help on mobile requires the hamburger menu. If so, update to use the required hamburger menu phrasing from the naming conventions.
  3. Add internalScope metadata (optional, not introduced by this PR): The YAML frontmatter is missing the internalScope field required by HELP_AUTHORING_GUIDELINES.md. Consider adding it in a follow-up.

Files Reviewed

  • docs/articles/new-expensify/concierge-ai/Support-Agent.md -- 2 additions, 3 deletions. Updates Web and Mobile access instructions to reflect new Concierge icon. Minor style fixes recommended.

@github-actions github-actions Bot changed the title [NO QA] Docs updates for E/A#87395 Add mobile Concierge icon help access [No QA] [NO QA] Docs updates for E/A#87395 Add mobile Concierge icon help access May 6, 2026
@OSBotify
Copy link
Copy Markdown
Contributor

OSBotify commented May 6, 2026

A preview of your ExpensifyHelp changes have been deployed to https://48782bc0.helpdot.pages.dev ⚡️

Updated articles:

@VictoriaExpensify
Copy link
Copy Markdown
Contributor

VictoriaExpensify commented May 7, 2026

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Android: mWeb Chrome
iOS: HybridApp
iOS: mWeb Safari
MacOS: Chrome / Safari

Copy link
Copy Markdown
Contributor

@VictoriaExpensify VictoriaExpensify left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated line 21 from "at the top right corner" to "in the top-right corner" to align with line 20

- **Web:** Click the chat icon in the top-right corner
- **Mobile:** Tap the hamburger menu in the top-left corner, then tap **Concierge**
- **Web:** Click the **Concierge** icon in the top-right corner.
- **Mobile:** Tap the **Concierge** icon in the top-right corner of the screen, or go to **Account** > **Help** and select **Concierge**.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Naming convention / Navigation violation: If accessing Account on mobile requires the hamburger menu, the governance (HELPSITE_NAMING_CONVENTIONS.md, "Hamburger Menu Rule") requires the exact phrasing:

On mobile, tap the hamburger menu in the top-left corner, then select [Tab name].

Consider rewriting the second path to match this pattern, e.g.:

- **Mobile:** Tap the **Concierge** icon in the top-right corner of the screen, or tap the hamburger menu in the top-left corner, then go to **Account** > **Help** and select **Concierge**.

Additionally, this bullet combines two distinct navigation flows into one line. Per the governance rule "Do not merge these into one sentence" — consider splitting these into separate bullets or sub-bullets for clarity.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 7, 2026

HelpDot Documentation Review

Overall Assessment

This is a small, focused update to the "Where to find Concierge Support Agent" section of Support-Agent.md. The change consolidates three bullet points into two by removing the separate Account path, updating the Web bullet to reference the Concierge icon explicitly, and updating the Mobile bullet to document the new Concierge icon in the top-right corner while preserving the alternative Account > Help > Concierge path. The changes are clear and well-scoped.

Scores Summary

  • Readability: 9/10 - The revised bullets are concise, scannable, and action-oriented. The mobile bullet is slightly long due to combining two access methods, but it remains clear and avoids ambiguity.
  • AI Readiness: 8/10 - No metadata or heading changes were part of this diff. The existing headings and YAML frontmatter (which include title, description, and keywords) are unaffected. One note: the file still lacks the internalScope field in its YAML frontmatter, which is required per HELP_AUTHORING_GUIDELINES.md Section 3. While this is pre-existing and not introduced by this PR, it is worth flagging.
  • Style Compliance: 8/10 - The diff correctly bolds Concierge as a UI element and uses exact UI terminology. However, the Mobile bullet uses "go to Account > Help and select Concierge" which deviates from the Hamburger Menu Rule. Per HELPSITE_NAMING_CONVENTIONS.md, if the Account settings are reached via the hamburger menu on mobile, the instruction should follow the prescribed pattern: "tap the hamburger menu in the top-left corner, then select [Tab name]." Additionally, the term "Concierge icon" should be verified against the actual UI label -- if the icon does not have a visible text label of "Concierge," the instruction should describe it more precisely (e.g., the Concierge chat icon or a description of the icon's appearance).

Key Findings

  • Positive: The consolidation from three bullets to two reduces redundancy and better reflects the current UI state where web and mobile both have the Concierge icon in the top-right corner. Keeping the alternative mobile path (Account > Help > Concierge) is a good choice for completeness.
  • Minor inconsistency: Some bullets in the unchanged list end with trailing spaces but no period (e.g., "Workspace chat," "Report or expense threads"), while the two new bullets correctly end with periods. This is pre-existing and not introduced by this PR.
  • Governance gap (pre-existing): The YAML frontmatter is missing the internalScope field, which is required per authoring guidelines. This is not part of the current diff but is worth addressing in a follow-up.

Recommendations

  1. Verify that the mobile alternative path ("go to Account > Help and select Concierge") does not require hamburger menu navigation. If it does, the instruction should include the hamburger menu phrasing per the naming conventions.
  2. Confirm that "Concierge icon" matches what users see in the UI. If the icon lacks a visible "Concierge" label, consider a brief descriptor to help users identify it.
  3. Consider a follow-up PR to add the missing internalScope metadata field and normalize punctuation across all bullets in the list.

Files Reviewed

  • docs/articles/new-expensify/concierge-ai/Support-Agent.md - Two lines added, three removed. Updates Web and Mobile access instructions to reflect the new Concierge icon button on mobile. Changes are clear and well-aligned with the feature update.

- **Web:** Click the chat icon in the top-right corner
- **Mobile:** Tap the hamburger menu in the top-left corner, then tap **Concierge**
- **Web:** Click the **Concierge** icon in the top-right corner.
- **Mobile:** Tap the **Concierge** icon in the top-right corner of the screen, or go to **Account** > **Help** and select **Concierge**.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Readability / scannability: This bullet combines two distinct navigation paths into a single line, which reduces scannability and makes it harder for users to quickly find the method they need. Per the authoring guidelines, step instructions should be clear and action-oriented. Consider splitting into two separate bullets — one for the Concierge icon and one for the Account > Help path:

Suggested change
- **Mobile:** Tap the **Concierge** icon in the top-right corner of the screen, or go to **Account** > **Help** and select **Concierge**.
- **Mobile:** Tap the **Concierge** icon in the top-right corner of the screen.
- **Mobile (alternate):** Go to **Account** > **Help** and select **Concierge**.

Alternatively, if the Account > Help path is secondary, a sub-bullet could work to keep it grouped while still improving readability.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 7, 2026

HelpDot Documentation Review

Overall Assessment

This PR updates the "Where to find Concierge Support Agent" section to reflect a new Concierge icon in the top-right corner on both web and mobile, replacing the previous hamburger menu path on mobile and the generic "chat icon" reference on web. The old standalone "Account" bullet has been folded into the mobile instruction as an alternative path. The changes are small, targeted, and generally well-aligned with governance rules.

Scores Summary

  • Readability: 9/10 - The updated bullets are clear, concise, and scannable. The mobile instruction uses "or" to present two paths in one bullet, which remains easy to follow.
  • AI Readiness: 8/10 - The metadata (title, description, keywords, order) is present but missing the required internalScope field per HELP_AUTHORING_GUIDELINES.md Section 3. However, since the metadata was not changed in this PR, this is a pre-existing gap and not a fault of the current diff.
  • Style Compliance: 9/10 - UI element references are bolded correctly (Concierge, Account, Help). Web and mobile instructions are properly separated into distinct bullets per HELPSITE_NAMING_CONVENTIONS.md. The phrasing "Click the Concierge icon" and "Tap the Concierge icon" is specific and avoids vague navigation language.

Key Findings

  • The removal of the hamburger menu reference is appropriate if the UI now provides a dedicated Concierge icon in the top-right corner on mobile. The old hamburger menu pattern is no longer applicable if the entry point has moved.
  • Consolidating the "Account" path into the mobile bullet as an alternative ("or go to Account > Help and select Concierge") is a practical choice that avoids a redundant standalone bullet.
  • The term "Concierge icon" should be verified against the actual UI to ensure it matches the exact icon label or tooltip, per the core UI referencing rule: "Use the exact text shown in the product UI."
  • Positive: Consistent use of bold formatting for UI elements, and proper platform separation (Web vs. Mobile).

Recommendations

  1. Verify UI accuracy: Confirm that the icon in the top-right corner is identified as the "Concierge" icon in the product UI (e.g., via tooltip or accessibility label). If the icon has no text label, consider describing it as "the Concierge icon (speech bubble)" or similar, to help users identify it precisely.
  2. Trailing punctuation consistency: The two changed lines end with periods, while some unchanged bullets in the same list do not. This is a pre-existing inconsistency, not introduced by this PR, but could be addressed as a follow-up.

Files Reviewed

  • docs/articles/new-expensify/concierge-ai/Support-Agent.md -- 2 additions, 3 deletions. Updates Concierge access instructions for web and mobile to reflect new icon-based entry point. Changes are clean and governance-compliant.

@VictoriaExpensify VictoriaExpensify merged commit 72af49f into main May 7, 2026
22 checks passed
@VictoriaExpensify VictoriaExpensify deleted the claude-docsUpdateConciergeMobileHelp branch May 7, 2026 06:04
@OSBotify
Copy link
Copy Markdown
Contributor

OSBotify commented May 8, 2026

🚀 Deployed to staging by https://github.com/VictoriaExpensify in version: 9.3.69-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@OSBotify
Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/Beamanator in version: 9.3.69-18 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants