[No QA] Allow __esModule in naming-convention rule, drop ~120 suppressions by roryabraham · Pull Request #89412 · Expensify/App

roryabraham · 2026-05-01T21:53:35Z

Explanation of Change

__esModule is a well-known bundler/Jest interop property (injected by Babel/Webpack and expected by Jest's ES-module mock contract). Its double-underscore prefix has always been a false positive for @typescript-eslint/naming-convention, requiring a suppression comment on every jest.mock() factory that returns {__esModule: true, ...}.

This PR adds an explicit allow-list entry to the rule:

{
    selector: ['variable', 'property'],
    format: null,
    filter: { regex: '^__esModule$', match: true },
},

With the rule fixed, all ~120 // eslint-disable-next-line @typescript-eslint/naming-convention (and block-level /* eslint-disable */) comments that were papering over this are removed via npm run lint -- --fix.

Fixed Issues

$
PROPOSAL:

Tests

This is a lint-config-only change — no runtime behaviour is affected.

Run npm run lint and verify it exits cleanly (the only remaining error is a pre-existing absoluteFillObject deprecation unrelated to this PR).

Offline tests

N/A — no runtime changes.

QA Steps [No QA]

N/A — lint/tooling change only, no product behaviour changed.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Made with Cursor

__esModule is a well-known bundler/Jest interop property. Add an explicit allow-list entry in the @typescript-eslint/naming-convention config so the double-underscore prefix no longer triggers the rule, then remove the 120+ eslint-disable-next-line comments that were papering over this. Co-authored-by: Cursor <cursoragent@cursor.com>

…onvention-exception

Co-authored-by: Cursor <cursoragent@cursor.com>

codecov · 2026-05-01T22:49:37Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
...s/hooks/useChartFontManager/useChartFontManager.ts	`0.00% <ø> (ø)`
...omponents/ReimbursementAccountLoadingIndicator.tsx	`0.00% <0.00%> (ø)`
... and 9 files with indirect coverage changes

melvin-bot · 2026-05-01T22:56:35Z

@mjasikowski Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

mjasikowski · 2026-05-04T06:33:07Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2026-05-04T06:33:28Z

@mjasikowski looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

github-actions · 2026-05-04T06:33:58Z

🚧 @mjasikowski has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-05-04T06:38:17Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #89412.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-07baea8-34a8d39-542fc1eaec6496aba20f8c36fa6d87872738087b/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-07baea8-34a8d39-ed261a1f48bd2e4ba6467e46b1d3de5f22f14b98/index.html

Web 🕸️
https://89412.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-05-04T06:42:21Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-05-04T13:29:23Z

🚀 Deployed to staging by https://github.com/mjasikowski in version: 9.3.66-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	cancelled 🔪
🍎 iOS 🍎	cancelled 🔪

MelvinBot · 2026-05-04T13:30:35Z

No help site changes are required for this PR.

This is a lint-config-only change (adding an ESLint naming-convention exception for __esModule and removing ~120 suppression comments). There are no runtime, UI, or product behavior changes that would need to be reflected in the help site documentation under docs/articles.

melvin-bot Bot assigned roryabraham May 1, 2026

roryabraham changed the title ~~Allow __esModule in naming-convention rule, drop ~120 suppressions~~ [No QA] Allow __esModule in naming-convention rule, drop ~120 suppressions May 1, 2026

roryabraham and others added 2 commits May 1, 2026 15:09

Merge remote-tracking branch 'origin/main' into fix/esmodule-naming-c…

2a35155

…onvention-exception

Fix lint errors from origin/main merge

1a97b70

Co-authored-by: Cursor <cursoragent@cursor.com>

roryabraham marked this pull request as ready for review May 1, 2026 22:56

roryabraham requested review from a team as code owners May 1, 2026 22:56

melvin-bot Bot requested review from joekaufmanexpensify and removed request for a team May 1, 2026 22:56

roryabraham removed the request for review from joekaufmanexpensify May 1, 2026 22:56

melvin-bot Bot requested review from mjasikowski and removed request for a team May 1, 2026 22:56

mjasikowski approved these changes May 4, 2026

View reviewed changes

mjasikowski merged commit 07baea8 into main May 4, 2026
40 checks passed

mjasikowski deleted the fix/esmodule-naming-convention-exception branch May 4, 2026 06:33

melvin-bot Bot added the Emergency label May 4, 2026

OSBotify mentioned this pull request May 4, 2026

Deploy Checklist: New Expensify 2026-05-04 #89508

Open

72 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[No QA] Allow __esModule in naming-convention rule, drop ~120 suppressions#89412

[No QA] Allow __esModule in naming-convention rule, drop ~120 suppressions#89412
mjasikowski merged 3 commits intomainfrom
fix/esmodule-naming-convention-exception

roryabraham commented May 1, 2026 •

edited

Loading

Uh oh!

codecov Bot commented May 1, 2026 •

edited by github-actions Bot

Loading

Uh oh!

melvin-bot Bot commented May 1, 2026

Uh oh!

mjasikowski commented May 4, 2026

Uh oh!

Uh oh!

melvin-bot Bot commented May 4, 2026

Uh oh!

github-actions Bot commented May 4, 2026

Uh oh!

github-actions Bot commented May 4, 2026

Uh oh!

OSBotify commented May 4, 2026

Uh oh!

OSBotify commented May 4, 2026

Uh oh!

MelvinBot commented May 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

roryabraham commented May 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps [No QA]

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov Bot commented May 1, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot Bot commented May 1, 2026

Uh oh!

mjasikowski commented May 4, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

Uh oh!

melvin-bot Bot commented May 4, 2026

Uh oh!

github-actions Bot commented May 4, 2026

Uh oh!

github-actions Bot commented May 4, 2026

Uh oh!

OSBotify commented May 4, 2026

Uh oh!

OSBotify commented May 4, 2026

Uh oh!

MelvinBot commented May 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

roryabraham commented May 1, 2026 •

edited

Loading

codecov Bot commented May 1, 2026 •

edited by github-actions Bot

Loading