[No QA] Allow __esModule in naming-convention rule, drop ~120 suppressions

config/eslint/eslint.config.mjs

@@ -269,6 +269,16 @@ const config = defineConfig([
             '@typescript-eslint/max-params': ['error', {max: 10}],
             '@typescript-eslint/naming-convention': [
                 'error',
+                {
+                    selector: ['variable', 'property'],
+                    format: null,
+                    // Allow __esModule because it is a well-known interop property injected by bundlers
+                    // (e.g. Babel/Webpack) and sometimes required by library internals (e.g. react-native-skia).
+                    filter: {
+                        regex: '^__esModule$',
+                        match: true,
+                    },
+                },
                 {
                     selector: ['variable', 'property'],
                     format: ['camelCase', 'UPPER_CASE', 'PascalCase'],

jest/setup.ts

@@ -76,7 +76,6 @@ jest.mock('expo-location', () => ({
 
 // Needed for: https://stackoverflow.com/questions/76903168/mocking-libraries-in-jest
 jest.mock('react-native/Libraries/LogBox/LogBox', () => ({
-    // eslint-disable-next-line @typescript-eslint/naming-convention
     __esModule: true,
     default: {
         ignoreLogs: jest.fn(),
@@ -149,7 +148,6 @@ jest.mock('@libs/scheduleOnLiveMarkdownRuntime', () => {
 });
 
 jest.mock('@src/setup/telemetry', () => ({
-    // eslint-disable-next-line @typescript-eslint/naming-convention
     __esModule: true,
     default: jest.fn(),
     navigationIntegration: {
@@ -280,7 +278,6 @@ jest.mock(
 );
 
 jest.mock('@libs/prepareRequestPayload/index.native.ts', () => ({
-    // eslint-disable-next-line @typescript-eslint/naming-convention
     __esModule: true,
     default: jest.fn((command: string, data: Record<string, unknown>) => {
         const formData = new FormData();
@@ -303,7 +300,6 @@ jest.mock('@libs/prepareRequestPayload/index.native.ts', () => ({
 jest.mock('@components/ConfirmedRoute.tsx');
 
 jest.mock('@src/hooks/useWorkletStateMachine/runOnUISync', () => ({
-    // eslint-disable-next-line @typescript-eslint/naming-convention
     __esModule: true,
     default: jest.fn(() => jest.fn()), // Return a function that returns a function
 }));
@@ -367,17 +363,14 @@ jest.mock('@src/components/KeyboardDismissibleFlatList/KeyboardDismissibleFlatLi
 // in triggerUnreadUpdate (also timer-based), this creates excessive timer churn that causes
 // heavy integration tests like SessionTest to exceed their timeout.
 jest.mock('@src/hooks/useDocumentTitle', () => ({
-    // eslint-disable-next-line @typescript-eslint/naming-convention
     __esModule: true,
     default: jest.fn(),
 }));
 jest.mock('@src/hooks/useWorkspaceDocumentTitle', () => ({
-    // eslint-disable-next-line @typescript-eslint/naming-convention
     __esModule: true,
     default: jest.fn(),
 }));
 jest.mock('@src/hooks/useDomainDocumentTitle', () => ({
-    // eslint-disable-next-line @typescript-eslint/naming-convention
     __esModule: true,
     default: jest.fn(),
 }));

src/components/Charts/hooks/useChartFontManager/useChartFontManager.ts

@@ -6,7 +6,6 @@ function webFont(url: string): DataModule {
     // a DataModule (i.e. the result of a dynamic `require()` call), which always has the shape
     // `{ __esModule: true, default: <url> }`. The `__esModule` property uses a double-underscore prefix
     // that violates the naming-convention rule, but it is mandated by the library's internal contract.
-    // eslint-disable-next-line @typescript-eslint/naming-convention
     return {__esModule: true, default: url} as unknown as DataModule;
 }
 

src/components/ReimbursementAccountLoadingIndicator.tsx

@@ -21,7 +21,7 @@ function ReimbursementAccountLoadingIndicator({onBackButtonPress}: Reimbursement
     return (
         <ScreenWrapper
             shouldShowOfflineIndicator={false}
-            style={[StyleSheet.absoluteFillObject, styles.reimbursementAccountFullScreenLoading]}
+            style={[StyleSheet.absoluteFill, styles.reimbursementAccountFullScreenLoading]}
             testID="ReimbursementAccountLoadingIndicator"
         >
             <HeaderWithBackButton

tests/actions/IOUTest.ts

@@ -6764,7 +6764,6 @@ describe('actions/IOU', () => {
     describe('setMoneyRequestOdometerImage and removeMoneyRequestOdometerImage', () => {
         beforeEach(() => {
             jest.mock('@libs/OdometerImageUtils', () => ({
-                // eslint-disable-next-line @typescript-eslint/naming-convention
                 __esModule: true,
                 default: jest.fn(),
             }));

tests/navigation/LinkedActionNotFoundGuardTest.tsx

@@ -1,4 +1,4 @@
-/* eslint-disable @typescript-eslint/naming-convention, @typescript-eslint/no-unsafe-return, @typescript-eslint/no-unsafe-assignment */
+/* eslint-disable @typescript-eslint/no-unsafe-return, @typescript-eslint/no-unsafe-assignment */
 import {act, render} from '@testing-library/react-native';
 import React from 'react';
 import {View} from 'react-native';

tests/navigation/cleanStaleReportActionBackToParamTest.ts

@@ -1,4 +1,4 @@
-/* eslint-disable @typescript-eslint/naming-convention, @typescript-eslint/no-unsafe-return */
+/* eslint-disable @typescript-eslint/no-unsafe-return */
 import type {NavigationState} from '@react-navigation/native';
 import cleanStaleReportActionBackToParam from '@src/pages/inbox/cleanStaleReportActionBackToParam';
 

tests/navigation/isActiveRouteTests.tsx

@@ -12,7 +12,6 @@ jest.mock('@libs/Navigation/navigationRef', () => {
     };
 
     return {
-        // eslint-disable-next-line @typescript-eslint/naming-convention
         __esModule: true,
         default: navigationRefMock,
     };

tests/perf-test/SearchRouter.perf-test.tsx

@@ -46,13 +46,11 @@ jest.mock('@src/libs/Navigation/Navigation', () => ({
 }));
 
 jest.mock('@src/hooks/useRootNavigationState', () => ({
-    // eslint-disable-next-line @typescript-eslint/naming-convention
     __esModule: true,
     default: () => ({contextualReportID: undefined, isSearchRouterScreen: false}),
 }));
 
 jest.mock('@hooks/useExportedToFilterOptions', () => ({
-    // eslint-disable-next-line @typescript-eslint/naming-convention
     __esModule: true,
     default: () => ({
         exportedToFilterOptions: [],

tests/perf-test/SelectionList.perf-test.tsx

@@ -68,7 +68,6 @@ jest.mock('@react-navigation/native', () => ({
 }));
 
 jest.mock('../../src/hooks/useKeyboardState', () => ({
-    // eslint-disable-next-line @typescript-eslint/naming-convention
     __esModule: true,
     default: jest.fn(() => ({
         isKeyboardShown: false,
@@ -77,7 +76,6 @@ jest.mock('../../src/hooks/useKeyboardState', () => ({
 }));
 
 jest.mock('../../src/hooks/useScreenWrapperTransitionStatus', () => ({
-    // eslint-disable-next-line @typescript-eslint/naming-convention
     __esModule: true,
     default: jest.fn(() => ({
         didScreenTransitionEnd: true,

tests/perf-test/useAdvancedSearchFilters.perf-test.tsx

@@ -34,7 +34,6 @@ jest.mock('@src/libs/Navigation/Navigation', () => ({
 }));
 
 jest.mock('@hooks/useExportedToFilterOptions', () => ({
-    // eslint-disable-next-line @typescript-eslint/naming-convention
     __esModule: true,
     default: () => ({
         exportedToFilterOptions: [],

tests/ui/AuthScreensInitHandlerTest.tsx

@@ -24,23 +24,20 @@ import wrapOnyxWithWaitForBatchedUpdates from '../utils/wrapOnyxWithWaitForBatch
 const TEST_ACCOUNT_ID = 1;
 
 jest.mock('@libs/Pusher', () => ({
-    // eslint-disable-next-line @typescript-eslint/naming-convention
     __esModule: true,
     default: {
         init: jest.fn(() => Promise.resolve()),
     },
 }));
 
 jest.mock('@libs/PusherConnectionManager', () => ({
-    // eslint-disable-next-line @typescript-eslint/naming-convention
     __esModule: true,
     default: {
         init: jest.fn(),
     },
 }));
 
 jest.mock('@libs/Navigation/Navigation', () => ({
-    // eslint-disable-next-line @typescript-eslint/naming-convention
     __esModule: true,
     default: {
         isActiveRoute: jest.fn(() => false),
@@ -51,7 +48,6 @@ jest.mock('@libs/Navigation/Navigation', () => ({
 }));
 
 jest.mock('@libs/Navigation/currentUrl', () => ({
-    // eslint-disable-next-line @typescript-eslint/naming-convention
     __esModule: true,
     default: jest.fn(() => ''),
 }));

tests/ui/AvatarSelector.test.tsx

@@ -11,7 +11,6 @@ import ONYXKEYS from '@src/ONYXKEYS';
 import waitForBatchedUpdates from '../utils/waitForBatchedUpdates';
 
 jest.mock('@hooks/useLetterAvatars', () => ({
-    // eslint-disable-next-line @typescript-eslint/naming-convention
     __esModule: true,
     default: (name?: string) => {
         if (!name) {

tests/ui/ChronosTimerHeaderButton.test.tsx

@@ -1,4 +1,3 @@
-/* eslint-disable @typescript-eslint/naming-convention -- Mock module paths use non-standard naming conventions required by jest.mock */
 import {PortalProvider} from '@gorhom/portal';
 import {fireEvent, render, screen, waitFor} from '@testing-library/react-native';
 import React from 'react';

tests/ui/FlightTripDetailsTest.tsx

@@ -4,7 +4,6 @@ import CONST from '@src/CONST';
 import type {Reservation} from '@src/types/onyx/Transaction';
 
 jest.mock('@hooks/useScreenWrapperTransitionStatus', () => ({
-    // eslint-disable-next-line @typescript-eslint/naming-convention
     __esModule: true,
     default: () => ({
         didScreenTransitionEnd: true,

tests/ui/GroupChatNameTests.tsx

@@ -26,7 +26,6 @@ jest.mock('../../src/components/ConfirmedRoute.tsx');
 
 // Needed for: https://stackoverflow.com/questions/76903168/mocking-libraries-in-jest
 jest.mock('react-native/Libraries/LogBox/LogBox', () => ({
-    /* eslint-disable-next-line @typescript-eslint/naming-convention */
     __esModule: true,
     default: {
         ignoreLogs: jest.fn(),

tests/ui/IOURequestStepDistanceTest.tsx

@@ -140,7 +140,6 @@ jest.mock('@components/DistanceRequest/DistanceRequestFooter', () => {
 });
 
 jest.mock('@hooks/useScreenWrapperTransitionStatus', () => ({
-    // eslint-disable-next-line @typescript-eslint/naming-convention
     __esModule: true,
     default: () => ({didScreenTransitionEnd: true}),
 }));

tests/ui/MoneyRequestReportPreview.test.tsx

@@ -59,7 +59,6 @@ jest.mock('@rnmapbox/maps', () => {
 const mockUseReportWithTransactionsAndViolations = jest.fn(() => defaultReportWithTransactionsAndViolations);
 
 jest.mock('@src/hooks/useReportWithTransactionsAndViolations', () => ({
-    // eslint-disable-next-line @typescript-eslint/naming-convention -- __esModule is required by Jest to properly mock ES modules with default exports
     __esModule: true,
     default: (...args: Parameters<typeof mockUseReportWithTransactionsAndViolations>) => mockUseReportWithTransactionsAndViolations(...args),
 }));

tests/ui/MultifactorAuthenticationRevokePageTest.tsx

@@ -18,7 +18,6 @@ let mockBiometricStatus = {
 };
 
 jest.mock('@hooks/useBiometricRegistrationStatus', () => ({
-    // eslint-disable-next-line @typescript-eslint/naming-convention
     __esModule: true,
     default: () => mockBiometricStatus,
 }));
@@ -37,15 +36,13 @@ jest.mock('@libs/Navigation/Navigation', () => ({
 }));
 
 jest.mock('@hooks/useLocalize', () => ({
-    // eslint-disable-next-line @typescript-eslint/naming-convention
     __esModule: true,
     default: () => ({
         translate: (key: string) => key,
     }),
 }));
 
 jest.mock('@hooks/useThemeStyles', () => ({
-    // eslint-disable-next-line @typescript-eslint/naming-convention
     __esModule: true,
     default: () =>
         new Proxy(

tests/ui/NewChatPageTest.tsx

@@ -20,7 +20,6 @@ import waitForBatchedUpdatesWithAct from '../utils/waitForBatchedUpdatesWithAct'
 jest.mock('@react-navigation/native');
 jest.mock('@src/libs/Navigation/navigationRef');
 jest.mock('react-native-permissions', () => ({
-    // eslint-disable-next-line @typescript-eslint/naming-convention
     __esModule: true,
     RESULTS: {
         UNAVAILABLE: 'unavailable',

tests/ui/ParentNavigationSubtitleTest.tsx

@@ -16,7 +16,6 @@ jest.mock('@libs/ReportActionsUtils', () => ({
 
 const mockUseRootNavigationState = jest.fn();
 jest.mock('@hooks/useRootNavigationState', () => ({
-    // eslint-disable-next-line @typescript-eslint/naming-convention
     __esModule: true,
     default: (selector?: (state: unknown) => unknown) => mockUseRootNavigationState(selector) as unknown,
 }));

tests/ui/ReservationAddressTest.tsx

@@ -6,7 +6,6 @@ import HotelTripDetails from '@pages/Travel/HotelTripDetails';
 import CONST from '@src/CONST';
 
 jest.mock('@hooks/useScreenWrapperTransitionStatus', () => ({
-    // eslint-disable-next-line @typescript-eslint/naming-convention
     __esModule: true,
     default: () => ({
         didScreenTransitionEnd: true, // or false, depending on your desired behavior

tests/ui/TestToolMenuBiometricsTest.tsx

@@ -17,21 +17,18 @@ let mockBiometricStatus = {
 jest.mock('@hooks/useBiometricRegistrationStatus', () => {
     const actual = require('@libs/MultifactorAuthentication/shared/VALUES') as {default: {REGISTRATION_STATUS: Record<string, string>}};
     return {
-        // eslint-disable-next-line @typescript-eslint/naming-convention
         __esModule: true,
         default: () => mockBiometricStatus,
         REGISTRATION_STATUS: actual.default.REGISTRATION_STATUS,
     };
 });
 
 jest.mock('@hooks/useIsAuthenticated', () => ({
-    // eslint-disable-next-line @typescript-eslint/naming-convention
     __esModule: true,
     default: () => true,
 }));
 
 jest.mock('@hooks/useLocalize', () => ({
-    // eslint-disable-next-line @typescript-eslint/naming-convention
     __esModule: true,
     default: () => ({
         translate: (key: string, params?: Record<string, string | number>) => {
@@ -47,7 +44,6 @@ jest.mock('@hooks/useLocalize', () => ({
 }));
 
 jest.mock('@hooks/useOnyx', () => ({
-    // eslint-disable-next-line @typescript-eslint/naming-convention
     __esModule: true,
     default: () => [undefined],
 }));
@@ -57,13 +53,11 @@ jest.mock('@hooks/useSidebarOrderedReports', () => ({
 }));
 
 jest.mock('@hooks/useSingleExecution', () => ({
-    // eslint-disable-next-line @typescript-eslint/naming-convention
     __esModule: true,
     default: () => ({singleExecution: (fn: () => void) => fn}),
 }));
 
 jest.mock('@hooks/useThemeStyles', () => ({
-    // eslint-disable-next-line @typescript-eslint/naming-convention
     __esModule: true,
     default: () =>
         new Proxy(
@@ -75,7 +69,6 @@ jest.mock('@hooks/useThemeStyles', () => ({
 }));
 
 jest.mock('@hooks/useWaitForNavigation', () => ({
-    // eslint-disable-next-line @typescript-eslint/naming-convention
     __esModule: true,
     default: () => (fn: () => void) => fn,
 }));

tests/ui/WorkspaceMoreFeaturesPageTest.tsx

@@ -53,7 +53,6 @@ jest.mock('@components/Modal/ReanimatedModal', () => {
     };
 });
 
-// eslint-disable-next-line @typescript-eslint/naming-convention
 jest.mock('@hooks/useIsPolicyConnectedToUberReceiptPartner', () => ({__esModule: true, default: jest.fn(() => false)}));
 
 jest.mock('@libs/CardUtils', () => {

tests/ui/components/DisplayNames.test.tsx

@@ -4,15 +4,13 @@ import DisplayNames from '@components/DisplayNames';
 import Parser from '@libs/Parser';
 
 jest.mock('@libs/Parser', () => ({
-    // eslint-disable-next-line @typescript-eslint/naming-convention
     __esModule: true,
     default: {
         htmlToText: jest.fn((html: string) => html.replaceAll(/<[^>]*>/g, '')),
     },
 }));
 
 jest.mock('@hooks/useLocalize', () => ({
-    // eslint-disable-next-line @typescript-eslint/naming-convention
     __esModule: true,
     default: jest.fn(() => ({
         translate: jest.fn((key: string) => key),

tests/ui/components/IOURequestStepDistanceTest.tsx

@@ -100,7 +100,6 @@ jest.mock('@react-navigation/native', () => {
 });
 
 jest.mock('@hooks/useScreenWrapperTransitionStatus', () => ({
-    // eslint-disable-next-line @typescript-eslint/naming-convention
     __esModule: true,
     default: () => ({
         didScreenTransitionEnd: true,

tests/ui/components/LHNOptionsListTest.tsx

@@ -25,7 +25,6 @@ jest.mock('@src/languages/IntlStore', () => {
     const cache = new Map<string, Record<string, unknown>>([['en', flattenObject(en)]]);
 
     return {
-        // eslint-disable-next-line @typescript-eslint/naming-convention
         __esModule: true,
         default: {
             getCurrentLocale: () => 'en',

tests/ui/components/PopoverMenu.tsx

@@ -140,7 +140,6 @@ describe('PopoverMenu utils', () => {
 
 jest.mock('@components/PopoverWithMeasuredContent', () => {
     return {
-        // eslint-disable-next-line @typescript-eslint/naming-convention
         __esModule: true,
         default: (props: PropsWithChildren<Record<string, unknown>>) => props.children,
     };
@@ -151,7 +150,6 @@ jest.mock('@components/FocusableMenuItem', () => {
     const {Pressable, Text} = require('react-native');
 
     return {
-        // eslint-disable-next-line @typescript-eslint/naming-convention
         __esModule: true,
         default: (props: {title: string; pressableTestID?: string; onPress?: (event: GestureResponderEvent) => void}) => (
             <Pressable

tests/ui/components/ProductTrainingContextProvider.tsx

@@ -14,7 +14,6 @@ import waitForBatchedUpdatesWithAct from '../../utils/waitForBatchedUpdatesWithA
 import wrapOnyxWithWaitForBatchedUpdates from '../../utils/wrapOnyxWithWaitForBatchedUpdates';
 
 jest.mock('@hooks/useResponsiveLayout', () => ({
-    // eslint-disable-next-line @typescript-eslint/naming-convention
     __esModule: true,
     default: jest.fn(),
 }));