Reports - Expense created while on "Reports", gets highlighted again when opened. by borys3kk · Pull Request #89525 · Expensify/App

borys3kk · 2026-05-04T16:03:40Z

Explanation of Change

In useSearchHighlightAndScroll — replaced the timer-based reset of transactionIDsToHighlight (which lost a race with the newSearchResultKeys reset and never fired) with a synchronous Onyx merge inside the detect effect. Stops every prior expense from re-animating on each new add.
In Search/index.tsx — useFocusEffect now skips the skeleton-during-transition defer when the highlight hook already queued rows. Otherwise FlashList stays empty for ~1s while the RHP dismiss transition runs, the new row never mounts inside the 300ms highlight window, and the animation never fires for expenses created outside Search.

Fixed Issues

$ #81474
PROPOSAL:

Tests

Sign in with an account that has at least one workspace and existing expenses.
Navigate to the Spend tab (Search) so the Expenses list is visible.
Click the global Create button (FAB) → Create expense → Submit a manual expense and return to Spend.
Verify that the newly created expense row briefly flashes with the yellow highlight animation (exactly once).
Without leaving the Spend tab, click the FAB again → Create expense → Submit a second manual expense.
Verify that only the second expense flashes with the highlight animation. The first expense must not re-animate.
Repeat the FAB → Create expense → Submit flow a third time.
Verify that only the third expense flashes; neither the first nor the second re-animate.

While on the Spend tab with Expense selected, submit a new expense via the FAB and let the highlight finish animating.
Switch the Search type to Reports (or any other Search sub-tab), then back to Expenses.
Verify that no rows flash on return — the highlight state was cleaned up when the Search type changed.

Verify that no errors appear in the JS console

Offline tests

Go offline (DevTools → Network → Offline, or disable Wi-Fi).
On the Spend tab, click the FAB → Create expense → Submit.
Verify that the expense appears optimistically in the list and the highlight animation plays for the new row.
Submit a second expense while still offline.
Verify that only the second expense's row flashes.
Go back online and verify the optimistic rows are reconciled with the server response and that no rows flash again on reconciliation.

QA Steps

Same as tests.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2026-05-05.at.12.23.20.mov

Android: mWeb Chrome

Screen.Recording.2026-05-05.at.12.26.25.mov

iOS: Native

Screen.Recording.2026-05-05.at.12.11.42.mov

iOS: mWeb Safari

Screen.Recording.2026-05-05.at.12.13.17.mov

MacOS: Chrome / Safari

Screen.Recording.2026-05-04.at.12.39.12.mov

codecov · 2026-05-05T09:20:40Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/hooks/useSearchHighlightAndScroll.ts	`82.44% <100.00%> (-0.65%)`	⬇️
src/components/Search/index.tsx	`0.85% <0.00%> (-0.01%)`	⬇️
... and 10 files with indirect coverage changes

mhawryluk · 2026-05-05T11:43:12Z

+            // Clear consumed manual highlight flags synchronously so subsequent detect runs
+            // don't re-highlight the same IDs. A previous timer-based reset effect lost a race
+            // with the reset of `newSearchResultKeys` (its cleanup kept canceling the timer
+            // before it could fire), leaving flags stuck at `true` and causing every later add
+            // to re-animate every prior expense.


imo this comment is a little too verbose and I don't love documenting a previous approach that isn't here now. same in tests/unit/useSearchHighlightAndScrollTest.ts -> the new comment is unnecessary

melvin-bot · 2026-05-05T12:57:49Z

@truph01 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

borys3kk · 2026-05-07T08:06:29Z

hello @truph01, how's the review coming along?

mountiny · 2026-05-08T16:07:39Z

@truph01 can you prioritize this pr please?

truph01 · 2026-05-09T03:29:24Z

@mountiny @borys3kk I need to prioritize other tasks this week.

I can review it today.

mountiny · 2026-05-10T13:45:49Z

@truph01 sorry it is not clear to me if you are available to review this 😂

truph01 · 2026-05-11T02:32:13Z

@truph01 sorry it is not clear to me if you are available to review this 😂

@mountiny I've started reviewing it since yesterday. I'm currently testing a few edge cases to help catch any regressions.

mountiny · 2026-05-11T07:31:07Z

Thank you

truph01 · 2026-05-11T16:40:36Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained ""why"" the code was doing something instead of only explaining ""what"" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named ""index.js"". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2026-05-12.at.10.25.16.mov

Android: mWeb Chrome

output.mp4

iOS: HybridApp

output.mp4

iOS: mWeb Safari

Screen.Recording.2026-05-12.at.10.15.12.mov

MacOS: Chrome / Safari

output.mp4

truph01 · 2026-05-12T06:27:38Z

+    // Used to skip the deferral that would otherwise hide the freshly-added row from
+    // FlashList during the RHP dismiss transition, which would prevent the highlight
+    // animation from ever firing on it.
+    const newSearchResultKeysRef = useRef(newSearchResultKeys);


We can consider returning a hasQueuedHighlights flag directly from the useSearchHighlightAndScroll hook instead of making the consumer mirror state into its own ref:

// In useSearchHighlightAndScroll return { newSearchResultKeys, handleSelectionListScroll, newTransactions, hasQueuedHighlights: newSearchResultKeys !== null && newSearchResultKeys.size > 0 };

Then use a ref for that boolean in Search/index.tsx — it would be cleaner and keep the highlight logic encapsulated.

yeah, seems valid, implemented

truph01 · 2026-05-12T10:57:34Z

@borys3kk PR looks good, I just have one minor comment.

borys3kk · 2026-05-12T11:28:13Z

@borys3kk PR looks good, I just have one minor comment.

looking into it now

…y-first-expense-is-highlighted

borys3kk · 2026-05-12T13:39:02Z

@truph01 this pr should be good to go assuming that merging main fixed the performance tests

Copilot

Pull request overview

Fixes the “new expense row highlights again after being opened” behavior on the Reports/Spend (Search) experience by ensuring highlight state is consumed deterministically and by avoiding a focus-time deferral that can prevent the highlighted row from mounting in time.

Changes:

useSearchHighlightAndScroll: clears consumed manual highlight flags synchronously during the “detect new items” effect (removing the prior timer-based reset that could lose races).
Search/index.tsx: adds hasQueuedHighlights from the hook and uses a ref to let the post-create useFocusEffect skip the skeleton/deferral when a highlight is queued.
Unit test: removes the timer wait now that the highlight-flag reset is no longer timer-based.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File	Description
tests/unit/useSearchHighlightAndScrollTest.ts	Updates the manual-highlight test to no longer wait for a timer-based reset.
src/hooks/useSearchHighlightAndScroll.ts	Consumes/clears manual highlight flags inline when detected; exposes `hasQueuedHighlights`.
src/components/Search/index.tsx	Skips focus-time skeleton deferral when highlights are queued to ensure the row mounts in time.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

github-actions · 2026-05-13T10:42:20Z

🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here.

OSBotify · 2026-05-13T10:52:58Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-05-13T10:53:08Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #89525.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-1465400-4be7f16-69b627a5d0a6e09d9d800645d7b3e5f365c64f2e/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-1465400-4be7f16-3ceb7daf916eb2c75d79c330a376e1faa996b8ec/index.html

Web 🕸️
https://89525.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-05-13T21:29:47Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.3.74-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

MelvinBot · 2026-05-13T21:31:56Z

No help site changes are required for this PR.

This is an internal bug fix for the expense highlight animation on the Search/Spend tab — it corrects a race condition so only the newly created expense row flashes instead of re-animating all previous rows. The changes are limited to hook logic (useSearchHighlightAndScroll.ts), a component guard (Search/index.tsx), and a test update. There are no new features, renamed settings, changed labels, or user-facing workflow changes that would require documentation updates.

OSBotify · 2026-05-15T18:08:46Z

🚀 Deployed to production by https://github.com/Beamanator in version: 9.3.74-7 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

borys3kk added 2 commits May 4, 2026 12:36

fix only first expense being highlighted

436561b

fix expense not highlighted when added outside of search

41767d2

melvin-bot Bot assigned borys3kk May 4, 2026

borys3kk changed the title ~~fix only first expense being highlighted~~ Reports - Expense created while on "Reports", gets highlighted again when opened. May 4, 2026

fix tests

430ac9f

mhawryluk reviewed May 5, 2026

View reviewed changes

mhawryluk approved these changes May 5, 2026

View reviewed changes

update comments

4edb1ae

borys3kk marked this pull request as ready for review May 5, 2026 12:57

borys3kk requested review from a team as code owners May 5, 2026 12:57

melvin-bot Bot requested review from heyjennahay and truph01 and removed request for a team May 5, 2026 12:57

truph01 reviewed May 12, 2026

View reviewed changes

borys3kk added 2 commits May 12, 2026 15:05

move whole logic to hook

88e9426

Merge branch 'main' of github.com:Expensify/App into borys3kk-fix-onl…

df8cc2c

…y-first-expense-is-highlighted

truph01 approved these changes May 12, 2026

View reviewed changes

melvin-bot Bot requested a review from mountiny May 12, 2026 18:03

mountiny requested a review from Copilot May 13, 2026 09:57

Copilot started reviewing on behalf of mountiny May 13, 2026 09:58 View session

Copilot AI reviewed May 13, 2026

View reviewed changes

mountiny approved these changes May 13, 2026

View reviewed changes

mountiny merged commit 1465400 into Expensify:main May 13, 2026
43 checks passed

OSBotify mentioned this pull request May 13, 2026

Deploy Checklist: New Expensify 2026-05-13 #90562

Closed

64 tasks

ahmedGaber93 mentioned this pull request May 14, 2026

feat: Add inline editing for tables on desktop (V2) #89166

Merged

52 tasks

melvin-bot Bot mentioned this pull request May 15, 2026

[Due for payment 2026-05-22] [Due for payment 2026-02-27] [$250] Reports - Expense created while on "Reports", gets highlighted again when opened. #81474

Open

7 tasks

Conversation

borys3kk commented May 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov Bot commented May 5, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

mhawryluk May 5, 2026

Choose a reason for hiding this comment

Uh oh!

melvin-bot Bot commented May 5, 2026

Uh oh!

borys3kk commented May 7, 2026

Uh oh!

mountiny commented May 8, 2026

Uh oh!

truph01 commented May 9, 2026

Uh oh!

mountiny commented May 10, 2026

Uh oh!

truph01 commented May 11, 2026

Uh oh!

mountiny commented May 11, 2026

Uh oh!

truph01 commented May 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

truph01 May 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

borys3kk May 12, 2026

Choose a reason for hiding this comment

Uh oh!

truph01 commented May 12, 2026

Uh oh!

borys3kk commented May 12, 2026

Uh oh!

borys3kk commented May 12, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

github-actions Bot commented May 13, 2026

Uh oh!

OSBotify commented May 13, 2026

Uh oh!

github-actions Bot commented May 13, 2026

Uh oh!

OSBotify commented May 13, 2026

Uh oh!

MelvinBot commented May 13, 2026

Uh oh!

OSBotify commented May 15, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

borys3kk commented May 4, 2026 •

edited

Loading

codecov Bot commented May 5, 2026 •

edited by github-actions Bot

Loading

truph01 commented May 11, 2026 •

edited

Loading

truph01 May 12, 2026 •

edited

Loading