Skip to content

[No QA] Update _routes.yml#89730

Merged
blimpich merged 4 commits into
mainfrom
bfitzexpensify-patch-13
May 20, 2026
Merged

[No QA] Update _routes.yml#89730
blimpich merged 4 commits into
mainfrom
bfitzexpensify-patch-13

Conversation

@bfitzexpensify
Copy link
Copy Markdown
Contributor

Explanation of Change

Adding a new hub for Travel Invoicing

Fixed Issues

$
PROPOSAL:

Tests

  • Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

@bfitzexpensify bfitzexpensify self-assigned this May 6, 2026
@bfitzexpensify bfitzexpensify requested a review from a team as a code owner May 6, 2026 09:17
@melvin-bot melvin-bot Bot requested review from cristipaval and removed request for a team May 6, 2026 09:17
@melvin-bot
Copy link
Copy Markdown

melvin-bot Bot commented May 6, 2026

@cristipaval Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

cristipaval
cristipaval previously approved these changes May 6, 2026
@stephanieelliott
Copy link
Copy Markdown
Contributor

Approved but I will leave this for you to merge when you're ready @bfitzexpensify!

@stephanieelliott stephanieelliott added the HelpDot Apply this label if the issue relates to ExpensifyHelp label May 11, 2026
@stephanieelliott stephanieelliott self-requested a review May 12, 2026 02:51
@stephanieelliott
Copy link
Copy Markdown
Contributor

Oops wait - actually there is a build error here Number of hubs in _routes.yml does not match number of hubs in docs/travel/articles. Please update _routes.yml with hub info..

Suggested a fix in this comment: #89604 (comment)

@bfitzexpensify
Copy link
Copy Markdown
Contributor Author

Nice, all checks passing now - want to approve @stephanieelliott?

@github-actions github-actions Bot changed the title Update _routes.yml [No QA] Update _routes.yml May 12, 2026
@OSBotify

This comment has been minimized.

Comment thread docs/_data/_routes.yml
@blimpich
Copy link
Copy Markdown
Contributor

@stephanieelliott ready for you review 👍

@blimpich
Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Android: mWeb Chrome
iOS: HybridApp
iOS: mWeb Safari
MacOS: Chrome / Safari

blimpich
blimpich previously approved these changes May 19, 2026
@stephanieelliott
Copy link
Copy Markdown
Contributor

@MelvinBot a file complete-a-hotel-stay-using-travel-invoicing.md was added under docs/articles/travel/travel-invoicing. However, when I navigate to that path in the dev preview link https://19a0aea0.helpdot.pages.dev/, the article does not appear. Can you fix it?

@MelvinBot
Copy link
Copy Markdown
Contributor

The article file is missing the opening --- frontmatter delimiter. Jekyll requires YAML frontmatter to be enclosed between two --- lines, but complete-a-hotel-stay-using-travel-invoicing.md starts directly with title: instead of ---.

Fix: Add --- as the very first line of the file so the frontmatter looks like:

---
title: Complete a hotel stay using Travel Invoicing
description: Learn what happens after you book a hotel with Travel Invoicing and how to handle payment verification at check-in.
keywords: [expensify hotel booking payment, travel invoicing hotel check in, expensify travel hotel authorization, hotel cvv expensify]
internalScope: Audience is Workspace Members. Covers hotel booking verification and check-in flow when using Travel Invoicing. Does not cover booking travel or admin setup.
---

Without the opening ---, Jekyll doesn't parse the file as a page, so it never renders on the site.

@blimpich
Copy link
Copy Markdown
Contributor

@MelvinBot please fix the frontmatter issue

@MelvinBot
Copy link
Copy Markdown
Contributor

The fix is straightforward — add --- as the very first line of docs/articles/travel/travel-invoicing/complete-a-hotel-stay-using-travel-invoicing.md (the opening frontmatter delimiter is missing).

However, I'm unable to push this change for two reasons:

  1. I'm not the author or an assignee on this PR
  2. blimpich is not the PR author, assignee, or co-author

To have me make the fix directly, the PR author or assignee (bfitzexpensify) should add me as a PR assignee and then reply with @MelvinBot please fix the frontmatter issue.

@stephanieelliott
Copy link
Copy Markdown
Contributor

stephanieelliott commented May 19, 2026

@blimpich I already committed the change manually! Let's just wait for the build to complete to double check it, and then I will approve so we can merge!

@OSBotify
Copy link
Copy Markdown
Contributor

A preview of your ExpensifyHelp changes have been deployed to https://fa069053.helpdot.pages.dev ⚡️

Updated articles:

@stephanieelliott
Copy link
Copy Markdown
Contributor

🙌 article is populating now. - approved!


## How to complete your hotel check-in using Travel Invoicing

### If your hotel accepts Travel Invoicing
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Structure violation: ### headings are not permitted. Per HELP_AUTHORING_GUIDELINES.md Section 9: "Only ## used for all content sections (no ### or deeper)."

Consider restructuring so that ### If your hotel accepts Travel Invoicing and ### If your hotel does not accept Travel Invoicing (line 53) become ##-level headings. For example:

  • ## How to check in when your hotel accepts Travel Invoicing
  • ## How to check in when your hotel does not accept Travel Invoicing

This also makes them task-based and independently searchable.


---

### If your hotel does not accept Travel Invoicing
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Structure violation: ### headings are not allowed per HELP_AUTHORING_GUIDELINES.md Section 9. Promote this to ## and make it task-based, e.g.:

## How to check in when your hotel does not accept Travel Invoicing


---

## What happens after your hotel stay
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heading violation: This heading is not task-based and omits the feature name. Per HELP_AUTHORING_GUIDELINES.md Section 2, all ## headings must start with an action verb or question word (How, What, Where, Who, Why, When) and include the feature name.

Suggested fix:
## What happens after your hotel stay when using Travel Invoicing

@github-actions
Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment

This PR introduces a new Travel Invoicing hub and its first article covering the hotel stay completion workflow. The article is well-structured, focused on a single workflow, and includes solid YAML metadata. There are a few governance compliance issues that should be addressed before merging.

Scores Summary

  • Readability: 8/10 - Clear, scannable content with logical flow. Steps are concise and action-oriented. The bullet-list format under "What happens after your hotel stay" works well for quick reference.
  • AI Readiness: 7/10 - Good YAML metadata with internalScope, keywords, and a task-based title. However, there is a heading hierarchy violation (### used in the article) and one heading lacks a task-based verb/question word.
  • Style Compliance: 8/10 - Terminology is consistent and the FAQ section follows the correct structure. No prohibited language detected. Minor issues with heading depth and one heading that could be more action-oriented.

Key Findings

Issues to address:

  1. Heading hierarchy violation (### used): The article uses ### If your hotel accepts Travel Invoicing and ### If your hotel does not accept Travel Invoicing. Per HELP_AUTHORING_GUIDELINES.md Section 4 and the validation checklist, only # and ## headings are permitted -- never ### or deeper. These should be restructured. One option: fold these conditional scenarios into the parent ## How to complete your hotel check-in using Travel Invoicing section using bold text or separate ## headings like ## How to check in when Travel Invoicing is accepted and ## How to check in when Travel Invoicing is not accepted.

  2. Non-task-based heading: ## What to expect after you book a hotel with Travel Invoicing -- while close, the heading "What to expect" is borderline. It does start with a question word ("What"), so it technically passes, but ## What happens after you book a hotel with Travel Invoicing would align more closely with the template pattern ## What happens after you [complete primary task].

  3. Heading without verb/question word: ## What happens after your hotel stay is acceptable (starts with "What"), but could be more specific: ## What happens after your hotel stay with Travel Invoicing to include the feature name per AI retrieval optimization rules (Section 6: include full feature name in headings).

Positive aspects:

  • YAML frontmatter is complete and well-crafted, including internalScope with clear audience and exclusion boundaries.
  • Keywords are realistic search phrases that match user intent.
  • The article solves one primary workflow (hotel stay completion) without scope creep.
  • FAQ questions are clear, direct, and relevant.
  • The article title matches the # heading exactly, as required.
  • Content is concise and benefit-focused.

Recommendations

  1. [Must fix] Replace all ### headings with ## headings or restructure the conditional content under the existing ## heading. This is a strict governance rule.
  2. [Should fix] Add the feature name "Travel Invoicing" to the heading ## What happens after your hotel stay for better AI retrieval precision.
  3. [Nice to have] Consider renaming ## What to expect after you book a hotel with Travel Invoicing to ## What happens after you book a hotel with Travel Invoicing for consistency with template patterns.

Files Reviewed

  • docs/_data/_routes.yml - New Travel Invoicing hub entry added. Description is clear and informative. No issues.
  • docs/articles/travel/travel-invoicing/complete-a-hotel-stay-using-travel-invoicing.md - New article. Well-written with good metadata. Has heading hierarchy violation (### usage) that must be corrected.
  • docs/travel/hubs/travel-invoicing/index.html - Standard hub index page. No issues.

Review based on governance files: HELPSITE_NAMING_CONVENTIONS.md, HELP_AUTHORING_GUIDELINES.md, and TEMPLATE.md.

@bfitzexpensify
Copy link
Copy Markdown
Contributor Author

@blimpich want to review the latest commit? I can't as the OG PR author

@blimpich blimpich merged commit 885fa75 into main May 20, 2026
24 checks passed
@blimpich blimpich deleted the bfitzexpensify-patch-13 branch May 20, 2026 16:03
@OSBotify
Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/blimpich in version: 9.3.79-1 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@OSBotify
Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/roryabraham in version: 9.3.79-4 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants