[No QA] Update _routes.yml#89730
Conversation
|
@cristipaval Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
Approved but I will leave this for you to merge when you're ready @bfitzexpensify! |
|
Oops wait - actually there is a build error here Suggested a fix in this comment: #89604 (comment) |
5035642
|
Nice, all checks passing now - want to approve @stephanieelliott? |
This comment has been minimized.
This comment has been minimized.
|
@stephanieelliott ready for you review 👍 |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
|
@MelvinBot a file |
|
The article file is missing the opening Fix: Add ---
title: Complete a hotel stay using Travel Invoicing
description: Learn what happens after you book a hotel with Travel Invoicing and how to handle payment verification at check-in.
keywords: [expensify hotel booking payment, travel invoicing hotel check in, expensify travel hotel authorization, hotel cvv expensify]
internalScope: Audience is Workspace Members. Covers hotel booking verification and check-in flow when using Travel Invoicing. Does not cover booking travel or admin setup.
---Without the opening |
|
@MelvinBot please fix the frontmatter issue |
|
The fix is straightforward — add However, I'm unable to push this change for two reasons:
To have me make the fix directly, the PR author or assignee ( |
|
@blimpich I already committed the change manually! Let's just wait for the build to complete to double check it, and then I will approve so we can merge! |
|
A preview of your ExpensifyHelp changes have been deployed to https://fa069053.helpdot.pages.dev ⚡️ Updated articles: |
|
🙌 article is populating now. - approved! |
|
|
||
| ## How to complete your hotel check-in using Travel Invoicing | ||
|
|
||
| ### If your hotel accepts Travel Invoicing |
There was a problem hiding this comment.
Structure violation: ### headings are not permitted. Per HELP_AUTHORING_GUIDELINES.md Section 9: "Only ## used for all content sections (no ### or deeper)."
Consider restructuring so that ### If your hotel accepts Travel Invoicing and ### If your hotel does not accept Travel Invoicing (line 53) become ##-level headings. For example:
## How to check in when your hotel accepts Travel Invoicing## How to check in when your hotel does not accept Travel Invoicing
This also makes them task-based and independently searchable.
|
|
||
| --- | ||
|
|
||
| ### If your hotel does not accept Travel Invoicing |
There was a problem hiding this comment.
Structure violation: ### headings are not allowed per HELP_AUTHORING_GUIDELINES.md Section 9. Promote this to ## and make it task-based, e.g.:
## How to check in when your hotel does not accept Travel Invoicing
|
|
||
| --- | ||
|
|
||
| ## What happens after your hotel stay |
There was a problem hiding this comment.
Heading violation: This heading is not task-based and omits the feature name. Per HELP_AUTHORING_GUIDELINES.md Section 2, all ## headings must start with an action verb or question word (How, What, Where, Who, Why, When) and include the feature name.
Suggested fix:
## What happens after your hotel stay when using Travel Invoicing
HelpDot Documentation ReviewOverall AssessmentThis PR introduces a new Travel Invoicing hub and its first article covering the hotel stay completion workflow. The article is well-structured, focused on a single workflow, and includes solid YAML metadata. There are a few governance compliance issues that should be addressed before merging. Scores Summary
Key FindingsIssues to address:
Positive aspects:
Recommendations
Files Reviewed
Review based on governance files: HELPSITE_NAMING_CONVENTIONS.md, HELP_AUTHORING_GUIDELINES.md, and TEMPLATE.md. |
|
@blimpich want to review the latest commit? I can't as the OG PR author |
|
🚀 Deployed to staging by https://github.com/blimpich in version: 9.3.79-1 🚀
Bundle Size Analysis (Sentry): |
|
🚀 Deployed to production by https://github.com/roryabraham in version: 9.3.79-4 🚀
|
Explanation of Change
Adding a new hub for Travel Invoicing
Fixed Issues
$
PROPOSAL:
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari