[CP Staging] Revert "feat: 79048 restore reverted usd flow" by lakchote · Pull Request #90199 · Expensify/App

lakchote · 2026-05-11T13:27:07Z

melvin-bot · 2026-05-11T13:27:46Z

@aldo-expensify Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

arosiclair

I don't think we need to revert yet

codecov · 2026-05-11T13:38:04Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/CONST/index.ts	`92.30% <ø> (ø)`
src/SCREENS.ts	`100.00% <ø> (ø)`
...gation/AppNavigator/ModalStackNavigators/index.tsx	`6.81% <ø> (-0.34%)`	⬇️
src/libs/Navigation/linkingConfig/config.ts	`76.92% <ø> (ø)`
...mbursementAccount/ConnectedVerifiedBankAccount.tsx	`0.00% <ø> (ø)`
...tAccount/ReimbursementAccountVerifyAccountPage.tsx	`0.00% <ø> (ø)`
.../BeneficialOwnerDetailsFormSubSteps/AddressUBO.tsx	`0.00% <ø> (ø)`
...eficialOwnerDetailsFormSubSteps/DateOfBirthUBO.tsx	`0.00% <ø> (ø)`
...eneficialOwnerDetailsFormSubSteps/LegalNameUBO.tsx	`0.00% <ø> (ø)`
...nerDetailsFormSubSteps/SocialSecurityNumberUBO.tsx	`0.00% <ø> (ø)`
... and 41 more
... and 13 files with indirect coverage changes

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2a6276e997

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-05-11T13:39:03Z

+            prevScreen();
        } else {
-            Navigation.goBack();
+            setCurrentUBOSubStep((currentSubstep) => currentSubstep - 1);


Route UBO form back action to the correct prior prompt

When a user is adding another beneficial owner (i.e., they entered the details form from ARE_THERE_MORE_UBOS) and taps back on the first details substep, this fallback always decrements to IS_ANYONE_ELSE_UBO. The previous behavior routed that case back to ARE_THERE_MORE_UBOS, so this regression now sends users to an earlier branch question and can unintentionally reset the UBO decision flow before they return to the owners list.

Useful? React with 👍 / 👎.

melvin-bot · 2026-05-11T15:40:57Z

@arosiclair looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

arosiclair · 2026-05-11T15:41:48Z

straight revert

…restore-reverted-usd-flow [CP Staging] Revert "feat: 79048 restore reverted usd flow" (cherry picked from commit d3113fc) (cherry-picked to staging by jasperhuangg)

OSBotify · 2026-05-11T16:24:02Z

🚀 Cherry-picked to staging by https://github.com/jasperhuangg in version: 9.3.69-13 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

MelvinBot · 2026-05-11T16:25:29Z

No help site changes are required for this PR.

This is a revert of #88193, which was an internal code refactor of the USD reimbursement bank account flow (navigation, routing, and page component structure). The original PR did not include any documentation changes, and the revert does not alter any user-facing features, labels, or workflows documented in the help site articles under App/docs/articles.

github-actions · 2026-05-11T16:51:55Z

🚧 @arosiclair has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-05-11T16:58:08Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #90199.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-d3113fc-db4298e-7835af2e977132d2dc37a013ace3846393af598c/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-d3113fc-db4298e-aa75ea8d70f7747cd6569631b18d3801c588cf76/index.html

Web 🕸️
https://90199.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-05-11T23:45:39Z

🚀 Deployed to production by https://github.com/Beamanator in version: 9.3.69-18 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-05-12T00:07:06Z

🚀 Cherry-picked to staging by https://github.com/jasperhuangg in version: 9.3.70-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

iOS

MelvinBot · 2026-05-12T00:08:30Z

No help site changes are required for this PR.

This PR reverts #88193, which was an internal refactor of the USD reimbursement account flow's navigation architecture (removing page-level route constants, reverting step navigation patterns). The revert restores the previous internal code structure without changing any user-facing behavior, feature names, UI labels, or workflows.

The existing help site article Connect a US Business Bank Account describes the user-facing steps, which remain unchanged by this revert.

OSBotify · 2026-05-13T01:21:27Z

🚀 Cherry-picked to staging by https://github.com/jasperhuangg in version: 9.3.72-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

MelvinBot · 2026-05-13T01:22:52Z

No help site changes required.

This PR reverts #88193, which was an internal refactoring of the USD reimbursement account flow (navigation structure, component organization, and animation fixes for mWeb Android). The revert does not change any user-facing behavior, UI labels, feature names, or workflows — the bank account setup experience remains identical from the end user's perspective.

Since there are no changes to user-facing functionality, no updates to App/docs/articles are needed.

OSBotify · 2026-05-13T07:02:47Z

🚀 Deployed to production by https://github.com/lakchote in version: 9.3.72-1 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Revert "feat: 79048 restore reverted usd flow"

2a6276e

lakchote self-assigned this May 11, 2026

lakchote requested review from a team as code owners May 11, 2026 13:27

melvin-bot Bot requested review from JmillsExpensify and aldo-expensify and removed request for a team May 11, 2026 13:27

melvin-bot Bot removed the request for review from a team May 11, 2026 13:27

arosiclair requested changes May 11, 2026

View reviewed changes

chatgpt-codex-connector Bot reviewed May 11, 2026

View reviewed changes

KJ21-ENG mentioned this pull request May 11, 2026

[$250] Android mWeb - Animations are disabled in the enable payments (BBA) flow #89915

Open

7 tasks

arosiclair approved these changes May 11, 2026

View reviewed changes

arosiclair merged commit d3113fc into main May 11, 2026
48 of 55 checks passed

arosiclair deleted the revert-88193-refactor/79048-restore-reverted-usd-flow branch May 11, 2026 15:40

melvin-bot Bot added the Emergency label May 11, 2026

arosiclair removed the Emergency label May 11, 2026

OSBotify added the CP Staging marks PRs that have been CP'd to staging label May 11, 2026

OSBotify mentioned this pull request May 11, 2026

Deploy Checklist: New Expensify 2026-05-08 #90006

Closed

github-actions Bot mentioned this pull request May 11, 2026

Investigate workflow job failing on main: lint / ESLint check #90213

Closed

Conversation

lakchote commented May 11, 2026 • edited by arosiclair Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

melvin-bot Bot commented May 11, 2026

Uh oh!

arosiclair left a comment

Choose a reason for hiding this comment

Uh oh!

codecov Bot commented May 11, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot May 11, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

melvin-bot Bot commented May 11, 2026

Uh oh!

arosiclair commented May 11, 2026

Uh oh!

OSBotify commented May 11, 2026

Uh oh!

MelvinBot commented May 11, 2026

Uh oh!

github-actions Bot commented May 11, 2026

Uh oh!

github-actions Bot commented May 11, 2026

Uh oh!

OSBotify commented May 11, 2026

Uh oh!

OSBotify commented May 12, 2026

Uh oh!

MelvinBot commented May 12, 2026

Uh oh!

OSBotify commented May 13, 2026

Uh oh!

MelvinBot commented May 13, 2026

Uh oh!

OSBotify commented May 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

lakchote commented May 11, 2026 •

edited by arosiclair

Loading

codecov Bot commented May 11, 2026 •

edited by github-actions Bot

Loading