[No QA] Tune web modal, dropdown and RHP animations#90212
Conversation
|
🚧 @dannymcclain has triggered a test Expensify/App build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
|
🚧 @mjasikowski has triggered a test Expensify/App build. You can view the workflow run here. |
|
🚧 @mjasikowski has triggered a test Expensify/App build. You can view the workflow run here. |
|
@parasharrajat Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0a3c573f42
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
🚧 @dannymcclain has triggered a test Expensify/App build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
|
Feeling good to me! Will let @Expensify/design get a last look too |
|
Everything feels good to me... except the centered alert modals. I wonder if we should have them do a very slight fade in? Otherwise it feels slightly too abrupt. I do NOT feel strongly about this though. CleanShot.2026-05-21.at.16.02.52.mp4 |
|
Oh yeah I agree with that - I missed those when I was cruising through. Those do feel pretty abrupt. But it's not a total deal breaker to me. |
|
I think it's totally ok to do a little followup on this given this PR is pretty advanced in, we can work on a small fade there. |
|
Totally, that works for me 👍 |
|
🚧 @Julesssss has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/Julesssss in version: 9.3.79-1 🚀
Bundle Size Analysis (Sentry): |
|
I reviewed all changes in this PR. This is a web-only animation performance pass that adjusts internal timing constants and refactors the modal card style interpolator. No user-facing features, settings, workflows, or terminology were changed. No help site updates are required. |
|
Not sure if it's due to this PR, but the regular nav stack animation on Workspaces is weird as the whole thing navigates over to the left. Instead I expect it to work like the second interaction where it moves over the content like a sheet. CleanShot.2026-05-22.at.09.42.14.mp4If we do this RHP animation on mobile it also means we have an inconsistency of animation cause you have a full move from right to left on a regular navigation change, then for the RHP it kinda fades. It looks a bit weird in practise: CleanShot.2026-05-22.at.09.43.18.mp4I'd expect this to be desktop only as we didn't have any problems with this on mobile. |
|
Deploy Blocker #91382 was identified to be related to this PR. |
|
🚀 Deployed to production by https://github.com/roryabraham in version: 9.3.79-4 🚀
|
|
@dubielzyk-expensify I will look into this on tomorrow! Wrapping up #90212 (comment) now. |
@shawnborton I just opened a followup here #91702 |
|
Thanks, see you over there! |
Explanation of Change
Web-only performance and feel pass on three surfaces:
Modalcomponent) — open/close timings reduced to 1ms via Platform-keyed defaults.Popover/PopoverMenu) —ANIMATED_TRANSITIONreduced to 1ms on web.To deliver the RHP animation without bolting an RHP-specific flag onto the existing modal helper,
useModalCardStyleInterpolator.tswas refactored: the 7 boolean props collapsed into a singleenter: EnterAnimationdiscriminated union (slide-and-fade,slide-from-width,fade,none) plusapplySidePanelOffset. All 8 call sites were updated; layout-context decisions (shouldUseNarrowLayout,animationEnabled) now live at the call site where they belong.Native (iOS/Android) timings and animations are unchanged — every modification is gated by
Platform.OS === 'web'or lives inside aweb:block / web-only entry point.Fixed Issues
$ #90146
PROPOSAL:
Tests
Offline tests
N/A
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari