Skip to content

[No QA] Tune web modal, dropdown and RHP animations#90212

Merged
Julesssss merged 23 commits into
Expensify:mainfrom
callstack-internal:perf/instant-web-modal-animations
May 21, 2026
Merged

[No QA] Tune web modal, dropdown and RHP animations#90212
Julesssss merged 23 commits into
Expensify:mainfrom
callstack-internal:perf/instant-web-modal-animations

Conversation

@adhorodyski
Copy link
Copy Markdown
Contributor

@adhorodyski adhorodyski commented May 11, 2026

Explanation of Change

Web-only performance and feel pass on three surfaces:

  • Modals (Modal component) — open/close timings reduced to 1ms via Platform-keyed defaults.
  • Dropdowns (Popover / PopoverMenu)ANIMATED_TRANSITION reduced to 1ms on web.
  • RHP transitions (outer open + nested screen pushes) — replaced the full-screen-width slide with a short hint: 60px translateX + opacity 0→1 over 150ms on open and 100ms on close.

To deliver the RHP animation without bolting an RHP-specific flag onto the existing modal helper, useModalCardStyleInterpolator.ts was refactored: the 7 boolean props collapsed into a single enter: EnterAnimation discriminated union (slide-and-fade, slide-from-width, fade, none) plus applySidePanelOffset. All 8 call sites were updated; layout-context decisions (shouldUseNarrowLayout, animationEnabled) now live at the call site where they belong.

Native (iOS/Android) timings and animations are unchanged — every modification is gated by Platform.OS === 'web' or lives inside a web: block / web-only entry point.

Fixed Issues

$ #90146
PROPOSAL:

Tests

  • Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Same as tests

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

@adhorodyski adhorodyski changed the title Make web modals and RHP transitions instant with softened scrim fade [No QA] Limit web modals, dropdowns and RHP transitions May 11, 2026
@github-actions
Copy link
Copy Markdown
Contributor

🚧 @dannymcclain has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

This comment has been minimized.

@Julesssss Julesssss self-requested a review May 11, 2026 17:26
@adhorodyski adhorodyski changed the title [No QA] Limit web modals, dropdowns and RHP transitions [No QA] Make web modal and dropdown animations instant May 12, 2026
@github-actions
Copy link
Copy Markdown
Contributor

🚧 @mjasikowski has triggered a test Expensify/App build. You can view the workflow run here.

@adhorodyski adhorodyski changed the title [No QA] Make web modal and dropdown animations instant [No QA] Tune web modal, dropdown and RHP animations May 12, 2026
@github-actions
Copy link
Copy Markdown
Contributor

🚧 @mjasikowski has triggered a test Expensify/App build. You can view the workflow run here.

@adhorodyski adhorodyski marked this pull request as ready for review May 12, 2026 13:37
@adhorodyski adhorodyski requested review from a team as code owners May 12, 2026 13:37
@melvin-bot melvin-bot Bot requested review from joekaufmanexpensify and parasharrajat and removed request for a team May 12, 2026 13:37
@melvin-bot
Copy link
Copy Markdown

melvin-bot Bot commented May 12, 2026

@parasharrajat Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Comment thread src/CONST/index.ts Outdated
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0a3c573f42

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread src/libs/Navigation/AppNavigator/useModalCardStyleInterpolator.ts
@github-actions
Copy link
Copy Markdown
Contributor

🚧 @dannymcclain has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

This comment has been minimized.

@dannymcclain
Copy link
Copy Markdown
Contributor

Feeling good to me! Will let @Expensify/design get a last look too

@shawnborton
Copy link
Copy Markdown
Contributor

Everything feels good to me... except the centered alert modals. I wonder if we should have them do a very slight fade in? Otherwise it feels slightly too abrupt. I do NOT feel strongly about this though.

CleanShot.2026-05-21.at.16.02.52.mp4

@dannymcclain
Copy link
Copy Markdown
Contributor

Oh yeah I agree with that - I missed those when I was cruising through. Those do feel pretty abrupt. But it's not a total deal breaker to me.

@adhorodyski
Copy link
Copy Markdown
Contributor Author

I think it's totally ok to do a little followup on this given this PR is pretty advanced in, we can work on a small fade there.

@shawnborton
Copy link
Copy Markdown
Contributor

Totally, that works for me 👍

@Julesssss Julesssss merged commit 18011e0 into Expensify:main May 21, 2026
34 checks passed
@github-actions
Copy link
Copy Markdown
Contributor

🚧 @Julesssss has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify
Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/Julesssss in version: 9.3.79-1 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@MelvinBot
Copy link
Copy Markdown
Contributor

I reviewed all changes in this PR. This is a web-only animation performance pass that adjusts internal timing constants and refactors the modal card style interpolator. No user-facing features, settings, workflows, or terminology were changed.

No help site updates are required.

@dubielzyk-expensify
Copy link
Copy Markdown
Contributor

Not sure if it's due to this PR, but the regular nav stack animation on Workspaces is weird as the whole thing navigates over to the left. Instead I expect it to work like the second interaction where it moves over the content like a sheet.

CleanShot.2026-05-22.at.09.42.14.mp4

If we do this RHP animation on mobile it also means we have an inconsistency of animation cause you have a full move from right to left on a regular navigation change, then for the RHP it kinda fades. It looks a bit weird in practise:

CleanShot.2026-05-22.at.09.43.18.mp4

I'd expect this to be desktop only as we didn't have any problems with this on mobile.

@mitarachim
Copy link
Copy Markdown

Deploy Blocker #91382 was identified to be related to this PR.

@OSBotify
Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/roryabraham in version: 9.3.79-4 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@adhorodyski
Copy link
Copy Markdown
Contributor Author

@dubielzyk-expensify I will look into this on tomorrow! Wrapping up #90212 (comment) now.

@adhorodyski
Copy link
Copy Markdown
Contributor Author

Everything feels good to me... except the centered alert modals. I wonder if we should have them do a very slight fade in? Otherwise it feels slightly too abrupt. I do NOT feel strongly about this though.

CleanShot.2026-05-21.at.16.02.52.mp4

@shawnborton I just opened a followup here #91702

@shawnborton
Copy link
Copy Markdown
Contributor

Thanks, see you over there!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.