Part 4: Remove Onyx.connect() for ONYXKEYS.COLLECTION.REPORT_ACTIONS in shareTrackedExpense path#90317
Conversation
|
@parasharrajat Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
melvin-bot
Bot
requested review from
flaviadefaria
and removed request for
a team
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ab02cad531
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
DylanDylann
force-pushed
the
refactor-66578-shareTrackedExpense
branch
from
ab02cad to
88ccf0f
Compare
| makeMeAdmin?: boolean; | ||
| policyID?: string; | ||
| currency?: string; | ||
| currency: string; |
There was a problem hiding this comment.
This is a safe change. I forgot to update it in the previous PR
|
@codex review |
|
Codex Review: Didn't find any major issues. Keep them coming! ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
|
No new product considerations - removing my assignment and unsubscribing. |
parasharrajat
left a comment
parasharrajat
left a comment
There was a problem hiding this comment.
Reviewer Checklist
- I have verified the author checklist is complete (all boxes are checked off).
- I verified the correct issue is linked in the
### Fixed Issuessection above - I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the
Testssection - I verified the steps for Staging and/or Production testing are in the
QA stepssection - I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I verified the steps for local testing are in the
- I checked that screenshots or videos are included for tests on all platforms
- I included screenshots or videos for tests on all platforms
- I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
- I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
- I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e.
toggleReportand notonIconClick). - I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to
src/languages/*files and using the translation method - I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in
STYLE.md) were followed
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e.
- If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
- I verified that this PR follows the guidelines as stated in the Review Guidelines
- I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like
Avatar, I verified the components usingAvatarhave been tested & I retested again) - I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
- I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
- If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a
/** comment above it */ - The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to
thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor) - Any internal methods bound to
thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick) - All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
- If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
- If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e.
StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
- If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
- If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like
Avataris modified, I verified thatAvataris working as expected in all cases) - If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
- If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
- If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added
Designlabel and/or tagged@Expensify/designso the design team can review the changes.
- If a new page is added, I verified it's using the
ScrollViewcomponent to make it scrollable when more elements are added to the page. - For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
- If the
mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps. - I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.
16.05.2026_15.26.05_REC.mp4
🎀 👀 🎀 C+ reviewed
|
|
DylanDylann
force-pushed
the
refactor-66578-shareTrackedExpense
branch
from
e1c7b8d to
88ccf0f
Compare
…TrackedExpense path Threads reportActionsList through trackExpense -> shareTrackedExpense -> buildAddMembersToWorkspaceOnyxData so the share-with-accountant flow uses the explicit hook value from useAllPolicyExpenseChatReportActions() instead of the module-scoped deprecatedAllReportActions cache. - Added reportActionsList? to TrackedExpenseParams and CreateTrackExpenseParams - shareTrackedExpense forwards it to buildAddMembersToWorkspaceOnyxData - trackExpense forwards it to the SHARE-branch TrackedExpenseParams - useExpenseSubmission supplies it from useAllPolicyExpenseChatReportActions() - DotIndicatorMessage threads it through ReceiptUploadRetryHandler so the TRACK_EXPENSE retry path injects a fresh value (the deserialized retry params would otherwise carry a stale list) - Added a unit test asserting the explicit param wins over the Onyx fallback - Documented the dead-code undefined arg at the buildPolicyData -> createPolicyExpenseChats call site Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
DylanDylann
force-pushed
the
refactor-66578-shareTrackedExpense
branch
from
88ccf0f to
9029a4c
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9029a4cd58
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| isSelfTourViewed, | ||
| defaultWorkspaceName: generateDefaultWorkspaceName(email, lastWorkspaceNumber, translate), | ||
| previousOdometerDraft: odometerDraft, | ||
| reportActionsList: policyExpenseChatReportActions, |
There was a problem hiding this comment.
When this confirmation screen mounts before useAllPolicyExpenseChatReportActions() has received the report-actions collection, the hook returns {} rather than undefined; passing that empty object here makes createPolicyExpenseChats() choose the explicit empty map over its reportActionsList ?? deprecatedAllReportActions fallback. In the share-with-accountant path where the accountant is newly added but already has an archived policy expense chat, that skips the REPORT_PREVIEW actions and leaves the nested expense reports archived. Please pass undefined until the collection is actually loaded, or otherwise let the callee fall back.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
This comment is about the function being triggered before the data is loaded. If that's a problem, using onyx.connect as before would also cause the same issue. However, I don't think we need to worry about this because the function needs to be triggered by user actions. Therefore, it shouldn't be executed during the initial phase when the data hasn't been loaded yet
|
🚧 @Gonals has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/Gonals in version: 9.3.79-1 🚀
Bundle Size Analysis (Sentry): |
|
No help site changes are required for this PR. This is a purely internal code refactoring that threads a |
|
🚀 Deployed to production by https://github.com/roryabraham in version: 9.3.79-4 🚀
|
6 participants
Explanation of Change
This PR is part of deprecating the module-scoped
Onyx.connect()cachedeprecatedAllReportActionsinsrc/libs/actions/Policy/Policy.ts.deprecatedAllReportActionsis read insidecreatePolicyExpenseChats(Policy.ts:1612) when theif (oldChat)branch is entered. Callers should supply an explicitreportActionsList(from theuseAllPolicyExpenseChatReportActions()hook) instead of relying on the module-scoped fallback.After PR #88312 the last remaining live caller path that still relied on the Onyx fallback was
shareTrackedExpense(deferred at the time to keep that PR small). This PR threadsreportActionsListthrough that path.Threading
Chain: UI/hook →
trackExpense→ SHARE branch →shareTrackedExpense→buildAddMembersToWorkspaceOnyxData→createPolicyExpenseChats.Changes:
reportActionsList?: OnyxCollection<OnyxTypes.ReportActions>to bothTrackedExpenseParamsandCreateTrackExpenseParams(each with a// TODO: Remove optional (?)comment pointing at [Due for payment 2026-05-29] RemoveOnyx.connect()for the key:ONYXKEYS.COLLECTION.REPORT_ACTIONSinsrc/libs/actions/Policy/Policy.ts#66578).shareTrackedExpense(TrackExpense.ts) now destructuresreportActionsListfromtrackedExpenseParamsand forwards it tobuildAddMembersToWorkspaceOnyxData.trackExpense(TrackExpense.ts) now forwardsreportActionsListto the SHARE-branchTrackedExpenseParamsit constructs (the CATEGORIZE branch does not callcreatePolicyExpenseChats, so it does not need it).useExpenseSubmission.ts— now callsuseAllPolicyExpenseChatReportActions()and passes the result through totrackExpense. OthertrackExpensecallers do not passaction: SHAREand never reachshareTrackedExpense, so they were not touched.retryParamsfrom a stored JSON string, so anyreportActionsListbaked into the original call would be stale at retry time.DotIndicatorMessagenow callsuseAllPolicyExpenseChatReportActions()and passes it down throughhandleRetryPress(both.tsand.android.ts) intohandleFileRetry, which overwritestrackExpenseParams.reportActionsListwith the fresh value before invokingTrackExpense.trackExpense(...).buildPolicyData→createPolicyExpenseChatscall (Policy.ts:3019) explaining that theundefinedreportActionsListargument is intentional dead code:buildPolicyDataalways uses a freshpolicyID(generatePolicyID()), so theif (oldChat)branch — the sole reader ofreportActionsList— is never entered. The only caller that passesadminParticipant(IOURequestStepUpgrade.tsx) also passespolicyID: undefined, confirming the path is dead.TrackExpenseTest.ts) that:REPORT_PREVIEWaction outside Onyx and supplies it via the explicitreportActionsList.trackExpensewithaction: SHAREand asserts both NVPs end upprivate_isArchivedfalsy — proving the explicit param wins over the deprecatedOnyx.connect()fallback (which would not contain the preview action).Deferred to the follow-up PR of #66578:
createPolicyExpenseChats/buildAddMembersToWorkspaceOnyxDatasuppliesreportActionsList. The final cleanup PR will make the parameter required, delete the?? deprecatedAllReportActionsfallback insidecreatePolicyExpenseChats, remove theOnyx.connect()block +deprecatedAllReportActionsvariable inPolicy.ts, drop the// TODO: Remove optional (?)markers, and decrement the allowableOnyx.connectESLint warning count inpackage.json.Fixed Issues
$ #66578
PROPOSAL:
Tests
Offline tests
N/A - This is a refactoring change that does not affect offline behavior.
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Screen.Recording.2026-05-12.at.17.28.36.mov