Stop using deprecated commands for accounting integrations Travel Invoicing by blimpich · Pull Request #90400 · Expensify/App

blimpich · 2026-05-13T01:55:05Z

Explanation of Change

Cleanup. The Travel Invoicing setters on NetSuite, QuickBooks Online, Xero, and Sage Intacct were saving changes through a generic catch-all endpoint that we've been moving away from. Every other setting on these integrations already uses a dedicated endpoint per setting, so this PR brings Travel Invoicing in line.

There is no user-visible change — saving a setting works exactly as before.

Held by: Expensify/Web-Expensify#52816. Cannot be merged until that PR is merged and deployed (otherwise the App will call API commands the backend doesn't recognize yet).

Fixed Issues

$ #88349
PROPOSAL: N/A

Tests

Open a workspace connected to NetSuite. Go to Workspace → Accounting → NetSuite → Export → Travel Invoicing and change the Travel payable account. The selection saves and is still there after a reload.
Same workspace: change the Travel journal posting preference. Saves and persists.
Open a workspace connected to QuickBooks Online. Go to Workspace → Accounting → QuickBooks Online → Export → Travel Invoicing and change the Travel payable account. Saves and persists.
Open a workspace connected to Sage Intacct. Change the Travel payable account on the Travel Invoicing page. Saves and persists.

Verify that no errors appear in the JS console

Offline tests

Turn off your network connection.
Change a Travel Invoicing setting. The new value shows immediately with a pending indicator.
Turn the network back on. The pending indicator clears and the value persists after reload.

QA Steps

Same as Tests above, against staging. Try it on NetSuite, QuickBooks Online, and Sage Intacct workspaces.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

codecov · 2026-05-13T17:10:13Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/libs/API/types.ts	`100.00% <ø> (ø)`
src/libs/actions/connections/NetSuiteCommands.ts	`13.50% <100.00%> (+1.68%)`	⬆️
src/libs/actions/connections/QuickbooksOnline.ts	`29.62% <100.00%> (+11.30%)`	⬆️
src/libs/actions/connections/SageIntacct.ts	`6.21% <100.00%> (ø)`
...QuickbooksExportTravelPayableAccountSelectPage.tsx	`0.00% <ø> (ø)`
... and 190 files with indirect coverage changes

… preference page

The travel vendor concept doesn't apply — in Vendor Bill exports the vendor is always the submitter's employee email, so a separate "travel vendor" setting is meaningless. The feature is being removed in a follow-up, so leave the page on the deprecated command rather than migrating it.

…PreferenceSelectPage

…Preference

blimpich · 2026-05-15T01:23:40Z

Waiting on web PR to get deployed

melvin-bot · 2026-05-18T16:46:20Z

@ShridharGoel Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

blimpich · 2026-05-18T16:47:10Z

@ShridharGoel ignore the ping 👍

rlinoz · 2026-05-18T18:02:12Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

github-actions · 2026-05-18T18:04:13Z

🚧 @rlinoz has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-05-18T18:08:39Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #90400.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-3c303b5-a7adfc8-b01bdd1eafdf37594f35814428e2ca2693137451/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-3c303b5-a7adfc8-5473f7ca5a7347e2f24cce82523a6359745904d9/index.html

Web 🕸️
https://90400.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-05-18T18:14:53Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-05-19T08:08:23Z

🚀 Deployed to staging by https://github.com/rlinoz in version: 9.3.76-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	cancelled 🔪
🍎 iOS 🍎	cancelled 🔪

MelvinBot · 2026-05-19T08:10:40Z

No help site changes are required for this PR.

This is an internal refactoring that migrates Travel Invoicing API calls from a generic catch-all endpoint to dedicated per-setting endpoints. There are no user-visible changes, no new features, and no UI modifications. The existing help site articles under App/docs/articles do not reference Travel Invoicing settings.

OSBotify · 2026-05-19T22:00:57Z

🚀 Deployed to production by https://github.com/roryabraham in version: 9.3.77-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

blimpich added 3 commits May 12, 2026 18:52

Register dedicated Travel Invoicing API commands

08bd5f2

Use dedicated commands for NetSuite Travel Invoicing setters

808f629

Use dedicated commands for QBO Travel Invoicing setters

5e9c0eb

melvin-bot Bot assigned blimpich May 13, 2026

Update NetSuite Travel Invoicing test to assert dedicated command

df8cc4c

blimpich added 3 commits May 13, 2026 11:38

Fix missing React import in NetSuite Travel Invoicing journal posting…

4df3ff1

… preference page

Add tests for Travel Invoicing setters

9d9be90

blimpich changed the title ~~Stop using deprecated commands for accounting integrations Travel Invoicing~~ [HOLD] Stop using deprecated commands for accounting integrations Travel Invoicing May 13, 2026

Use dedicated command for Sage Intacct Travel Invoicing setter

54d13f2

blimpich mentioned this pull request May 13, 2026

[WIP] - Add QBD Travel Invoicing ventopr and payable account selector #88606

Open

52 tasks

blimpich added 2 commits May 13, 2026 17:05

Remove unused React import from NetSuiteTravelInvoicingJournalPosting…

0b13a79

…PreferenceSelectPage

Add failure-path test for updateNetSuiteTravelInvoicingJournalPosting…

7d20cdc

…Preference

blimpich marked this pull request as ready for review May 18, 2026 16:46

blimpich requested review from a team as code owners May 18, 2026 16:46

melvin-bot Bot requested review from ShridharGoel and joekaufmanexpensify and removed request for a team and joekaufmanexpensify May 18, 2026 16:46

melvin-bot Bot removed the request for review from a team May 18, 2026 16:46

blimpich changed the title ~~[HOLD] Stop using deprecated commands for accounting integrations Travel Invoicing~~ Stop using deprecated commands for accounting integrations Travel Invoicing May 18, 2026

blimpich requested review from rlinoz and removed request for ShridharGoel May 18, 2026 16:46

rlinoz approved these changes May 18, 2026

View reviewed changes

rlinoz merged commit 3c303b5 into main May 18, 2026
49 checks passed

rlinoz deleted the blimpich-stopDeprecatedAccountingCommands branch May 18, 2026 18:03

OSBotify mentioned this pull request May 19, 2026

Deploy Checklist: New Expensify 2026-05-19 #91039

Closed

75 tasks

melvin-bot Bot mentioned this pull request May 19, 2026

[Due for payment 2026-05-26] stop using deprecated commands for accounting integration #88349

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Stop using deprecated commands for accounting integrations Travel Invoicing#90400

Stop using deprecated commands for accounting integrations Travel Invoicing#90400
rlinoz merged 10 commits into
mainfrom
blimpich-stopDeprecatedAccountingCommands

blimpich commented May 13, 2026 •

edited

Loading

Uh oh!

codecov Bot commented May 13, 2026 •

edited by github-actions Bot

Loading

Uh oh!

blimpich commented May 15, 2026

Uh oh!

melvin-bot Bot commented May 18, 2026

Uh oh!

blimpich commented May 18, 2026

Uh oh!

rlinoz commented May 18, 2026

Uh oh!

Uh oh!

github-actions Bot commented May 18, 2026

Uh oh!

github-actions Bot commented May 18, 2026

Uh oh!

OSBotify commented May 18, 2026

Uh oh!

OSBotify commented May 19, 2026

Uh oh!

MelvinBot commented May 19, 2026

Uh oh!

OSBotify commented May 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

blimpich commented May 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov Bot commented May 13, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

blimpich commented May 15, 2026

Uh oh!

melvin-bot Bot commented May 18, 2026

Uh oh!

blimpich commented May 18, 2026

Uh oh!

rlinoz commented May 18, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

Uh oh!

github-actions Bot commented May 18, 2026

Uh oh!

github-actions Bot commented May 18, 2026

Uh oh!

OSBotify commented May 18, 2026

Uh oh!

OSBotify commented May 19, 2026

Uh oh!

MelvinBot commented May 19, 2026

Uh oh!

OSBotify commented May 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

blimpich commented May 13, 2026 •

edited

Loading

codecov Bot commented May 13, 2026 •

edited by github-actions Bot

Loading