Dismiss keyboard before navigating to workspace invite message screen by MelvinBot · Pull Request #90625 · Expensify/App

MelvinBot · 2026-05-14T08:10:41Z

Explanation of Change

Adds Keyboard.dismiss() at the beginning of the inviteUser function in DynamicWorkspaceInvitePage to ensure the keyboard is fully dismissed before navigating to the invite message screen.

This prevents an Android InsetsController crash (IllegalStateException: Can't change insets on an animation that is cancelled) caused by a race condition: when the user later taps "Invite" on the message screen, sendInvitation calls Keyboard.dismiss() + Navigation.dismissModal() in quick succession. If a previous keyboard animation from the invite selector screen was still in-flight or left the InsetsController in a cancelled state, the subsequent keyboard animation crashes. By dismissing the keyboard before the navigation transition, the race is avoided.

Fixed Issues

$ #88754
PROPOSAL: #88754 (comment)

Tests

Precondition: have workspace

Tap on the workspace > Overview page
Tap the Invite button
Enter and select an email address
Tap Next > Tap Invite
Tap the Invite member button
Add an email address > Tap Next
Make sure user is landed on the Invite message screen without any crash

Verify that no errors appear in the JS console

Offline tests

Same as tests

QA Steps

Same as tests

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Prevents Android InsetsController crash by ensuring the keyboard is dismissed before navigation, avoiding a race condition between the keyboard close animation and view hierarchy changes. Co-authored-by: Eskalifer1 <Eskalifer1@users.noreply.github.com>

Eskalifer1 · 2026-05-14T08:44:23Z

@MelvinBot Add tests absed on steps from issue

Co-authored-by: Eskalifer1 <Eskalifer1@users.noreply.github.com>

MelvinBot · 2026-05-14T08:51:43Z

Added tests in tests/ui/DynamicWorkspaceInvitePageTest.tsx based on the issue steps:

Keyboard dismiss before navigation — verifies Keyboard.dismiss() is called before Navigation.navigate() when pressing "Next" after selecting an invitee (core fix validation)
Next button disabled with no selection — verifies the "Next" button is disabled when no users are selected
Draft saved on invite — verifies the invited email-to-accountID mapping is saved to the Onyx draft when pressing "Next"

All 3 tests pass.

Eskalifer1 · 2026-05-14T08:54:36Z

@MelvinBot Remove tests that you just added.

I was referring to the Tests, Offline Tests, and QA sections—specifically, to take the same steps that were in the issue and use them here.

Co-authored-by: Eskalifer1 <Eskalifer1@users.noreply.github.com>

MelvinBot · 2026-05-14T08:57:08Z

Done! I've:

Removed the unit test file (tests/ui/DynamicWorkspaceInvitePageTest.tsx)
Updated the PR body with the Tests, Offline tests, and QA Steps sections using the reproduction steps from the linked issue

MelvinBot · 2026-05-14T08:58:52Z

The typecheck failure was caused by TypeScript errors in tests/ui/DynamicWorkspaceInvitePageTest.tsx (missing keyForList property, component type mismatch, and OnyxKey type issue). This was already addressed by commit 6c2ea6d which removed the test file. The typecheck is currently re-running and should pass now.

The only other failing check is PR Author Checklist, which requires manual completion.

Eskalifer1 · 2026-05-14T09:59:07Z

@MelvinBot let's update Test section like this:

Precondition: have workspace

Tap on the workspace > Overview page
Tap the Invite button
Enter and select an email address
Tap Next > Tap Invite
Tap the Invite member button
Add an email address > Tap Next
Make sure user is landed on the Invite message screen without any crash

Update offline section as: Same as tests

Update QA section as: Same as tests

MelvinBot · 2026-05-14T10:01:00Z

Updated the PR body:

Tests section updated with the steps from the issue
Offline tests section updated to "Same as tests"
QA Steps section updated to "Same as tests"

Eskalifer1 · 2026-05-14T17:48:20Z

@codex review

chatgpt-codex-connector · 2026-05-14T17:50:18Z

Codex Review: Didn't find any major issues. Chef's kiss.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Eskalifer1 · 2026-05-14T17:52:25Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

88754-android-native.mov

Android: mWeb Chrome

88754-android-web.mov

iOS: HybridApp

88754-ios-native.mov

iOS: mWeb Safari

88754-ios-web.mov

MacOS: Chrome / Safari

88754-web.mov

Eskalifer1 · 2026-05-14T17:57:48Z

@MelvinBot Check all the boxes (even the ones you couldn't verify—I've made sure everything is correct)

MelvinBot · 2026-05-14T17:59:58Z

Done — all boxes in the PR Author Checklist are now checked.

Eskalifer1 · 2026-05-14T18:04:02Z

@MelvinBot Mark this PR as Ready for review

MelvinBot · 2026-05-14T18:05:51Z

I'm unable to mark this PR as ready for review due to permission restrictions in my current environment. You can do it yourself by clicking Ready for review at the bottom of the PR, or running: gh pr ready 90625 --repo Expensify/App

melvin-bot · 2026-05-14T18:08:36Z

@Eskalifer1 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot · 2026-05-14T18:09:16Z

@AndrewGable Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Eskalifer1

LGTM!

OSBotify · 2026-05-14T19:56:15Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-05-14T20:02:05Z

🚧 @AndrewGable has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-05-14T20:07:20Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #90625.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-9c30c6b-e0d82ac-c6f1b00a50c5ce671bea459aee1dee1ff0f02fe9/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-9c30c6b-e0d82ac-edfb5206b3a1edf1c39fcd8ca8bd87ef8c31a0c5/index.html

Web 🕸️
https://90625.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-05-15T17:26:12Z

🚀 Deployed to staging by https://github.com/AndrewGable in version: 9.3.74-7 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

MelvinBot · 2026-05-15T17:27:14Z

No help site changes are needed for this PR. The change is a purely technical bug fix (adding Keyboard.dismiss() to prevent an Android crash) with no impact on user-facing behavior, UI labels, or workflows documented on the help site.

OSBotify · 2026-05-15T18:12:37Z

🚀 Deployed to production by https://github.com/Beamanator in version: 9.3.74-7 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

MelvinBot assigned Eskalifer1 May 14, 2026

MelvinBot requested a review from a team May 14, 2026 08:10

MelvinBot mentioned this pull request May 14, 2026

[Due for payment 2026-05-22] [$250] Workspace- App crashes when invting user through invite button in Overview #88754

Closed

7 tasks

Add tests for DynamicWorkspaceInvitePage keyboard dismiss behavior

32fe175

Co-authored-by: Eskalifer1 <Eskalifer1@users.noreply.github.com>

Remove DynamicWorkspaceInvitePage unit test file

6c2ea6d

Co-authored-by: Eskalifer1 <Eskalifer1@users.noreply.github.com>

MelvinBot marked this pull request as ready for review May 14, 2026 18:08

MelvinBot requested a review from a team as a code owner May 14, 2026 18:08

melvin-bot Bot requested review from a team, Eskalifer1 and trjExpensify and removed request for a team May 14, 2026 18:08

melvin-bot Bot requested review from AndrewGable and removed request for a team May 14, 2026 18:09

Eskalifer1 approved these changes May 14, 2026

View reviewed changes

AndrewGable approved these changes May 14, 2026

View reviewed changes

AndrewGable merged commit 9c30c6b into main May 14, 2026
45 of 47 checks passed

AndrewGable deleted the claude-fixWorkspaceInviteCrashOnAndroid branch May 14, 2026 19:44

OSBotify mentioned this pull request May 15, 2026

Deploy Checklist: New Expensify 2026-05-15 #90795

Closed

MobileMage mentioned this pull request Jun 1, 2026

[$250] Android - Crash - App crashes when user tries to add member to workspace #92280

Closed

7 tasks

Uh oh!

Conversation

MelvinBot commented May 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

Eskalifer1 commented May 14, 2026

Uh oh!

MelvinBot commented May 14, 2026

Uh oh!

Eskalifer1 commented May 14, 2026

Uh oh!

MelvinBot commented May 14, 2026

Uh oh!

MelvinBot commented May 14, 2026

Uh oh!

Eskalifer1 commented May 14, 2026

Uh oh!

MelvinBot commented May 14, 2026

Uh oh!

Eskalifer1 commented May 14, 2026

Uh oh!

chatgpt-codex-connector Bot commented May 14, 2026

Uh oh!

Eskalifer1 commented May 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

Eskalifer1 commented May 14, 2026

Uh oh!

MelvinBot commented May 14, 2026

Uh oh!

Eskalifer1 commented May 14, 2026

Uh oh!

MelvinBot commented May 14, 2026

Uh oh!

melvin-bot Bot commented May 14, 2026

Uh oh!

melvin-bot Bot commented May 14, 2026

Uh oh!

Eskalifer1 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented May 14, 2026

Uh oh!

github-actions Bot commented May 14, 2026

Uh oh!

github-actions Bot commented May 14, 2026

Uh oh!

OSBotify commented May 15, 2026

Uh oh!

MelvinBot commented May 15, 2026

Uh oh!

OSBotify commented May 15, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

MelvinBot commented May 14, 2026 •

edited

Loading

Eskalifer1 commented May 14, 2026 •

edited

Loading