[CP Staging] Fix table deploy blockers#90676
Conversation
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
Checklist will be done in 5-10m, recording platform videos. |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppandroid_1.mp4android_2.mp4Android: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safariweb_chrome.mp4 |
|
thank you all! |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
[CP Staging] Fix table deploy blockers (cherry picked from commit 299ee1b) (cherry-picked to staging by luacmartins)
|
🚧 @JS00001 has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Cherry-picked to staging by https://github.com/luacmartins in version: 9.3.74-2 🚀
Bundle Size Analysis (Sentry): |
|
No help site changes are required for this PR. The changes are purely internal UI/styling bug fixes (removing an |
|
🚀 Cherry-picked to staging by https://github.com/luacmartins in version: 9.3.74-7 🚀
Bundle Size Analysis (Sentry): |
|
I reviewed the changes in this PR. The diff contains two small UI bug fixes:
These are purely internal rendering/layout fixes. No user-facing features, workflows, settings, or terminology were added or changed. No help site documentation updates are required. |
|
🚀 Deployed to production by https://github.com/Beamanator in version: 9.3.74-7 🚀
|
Explanation of Change
Fixes deploy blockers for the company cards table
Fixed Issues
$ #90610
$ #90589
Tests
Test 1
**Test 2 **
Offline tests
N/A
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videosundefined