Docs updates for E/A#90516 Update edit message docs for composer on narrow screens#90808
Docs updates for E/A#90516 Update edit message docs for composer on narrow screens#90808MelvinBot wants to merge 1 commit into
Conversation
Reflect the new editing UX where mobile/narrow screens use the bottom composer instead of inline editing when editing a message. Co-authored-by: Christoph Pader <chrispader@users.noreply.github.com>
MelvinBot
added
the
HelpDot
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
|
||
| **To edit or delete a message:** | ||
|
|
||
| **On Desktop:** |
There was a problem hiding this comment.
Naming convention mismatch: The navigation instruction standards in HELPSITE_NAMING_CONVENTIONS.md use "Web:" and "Mobile:" as the canonical platform labels (see "If Web and Mobile Navigation Differ" section). This should read **Web:** instead of **On Desktop:** to stay consistent with the governance standard.
| 3. Select **Edit comment** or **Delete comment**. | ||
| 4. If editing, modify the message inline and click **Save**. | ||
|
|
||
| **On Mobile:** |
There was a problem hiding this comment.
Naming convention mismatch: Same as above -- the governance standard in HELPSITE_NAMING_CONVENTIONS.md uses the label format Mobile: (not On Mobile:). Consider changing to **Mobile:** for consistency with the established pattern.
HelpDot Documentation ReviewOverall AssessmentThis PR updates the "Edit or Delete Messages" section to document platform-specific editing behavior following the composer change on narrow/mobile screens (E/A#90516). The change is small, well-scoped, and correctly separates Desktop and Mobile instructions per governance conventions. Scores Summary
Key Findings
Recommendations
Files Reviewed
Review based on docs/HELPSITE_NAMING_CONVENTIONS.md, docs/HELP_AUTHORING_GUIDELINES.md, and docs/TEMPLATE.md. |
| 1. Open a chat. | ||
| 2. Long-press a message. | ||
| 3. Select **Edit comment** or **Delete comment**. | ||
| 4. If editing, the message text appears in the composer at the bottom of the screen. Edit it there, then tap the **Send** icon to save your changes. |
There was a problem hiding this comment.
Readability / step formatting: This step is doing a lot of work -- it describes where the text appears, instructs the user to edit, and then instructs them to tap Send. Per the step formatting standard (HELP_AUTHORING_GUIDELINES.md Section 5), steps should be clear and action-oriented. Consider splitting into two steps for clarity:
4. Edit the message in the composer at the bottom of the screen.
5. Tap the **Send** icon to save your changes.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2271c62e9c
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| 1. Open a chat. | ||
| 2. Long-press a message. | ||
| 3. Select **Edit comment** or **Delete comment**. | ||
| 4. If editing, the message text appears in the composer at the bottom of the screen. Edit it there, then tap the **Send** icon to save your changes. |
There was a problem hiding this comment.
On narrow/mobile layouts, editing a message changes the composer button from Send to Save changes with a checkmark icon (src/pages/inbox/report/ReportActionCompose/ComposerSendButton.tsx sets icon = icons.Checkmark and label = common.saveChanges when editing). This step currently tells users to tap the Send icon, which can misdirect them during the exact flow this update is documenting.
Useful? React with 👍 / 👎.
|
I don't think this is needed, feature is pretty intuitive |
2 participants
Summary
Chat-Features-and-Moderation-Tools.mdto reflect the new editing behavior introduced in Allow editing messages in Composer on narrow screens V2 #90516Related PR
#90516