-
Notifications
You must be signed in to change notification settings - Fork 3.8k
Docs updates for E/A#90516 Update edit message docs for composer on narrow screens #90808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -46,11 +46,17 @@ You can send messages, attach files, and add emojis from the message bar at the | |
|
|
||
| # Edit or Delete Messages | ||
|
|
||
| **To edit or delete a message:** | ||
|
|
||
| **On Desktop:** | ||
| 1. Open a chat. | ||
| 2. Right-click a message. | ||
| 3. Select **Edit comment** or **Delete comment**. | ||
| 4. If editing, modify the message inline and click **Save**. | ||
|
|
||
| **On Mobile:** | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Naming convention mismatch: Same as above -- the governance standard in |
||
| 1. Open a chat. | ||
| 2. Long-press a message. | ||
| 3. Select **Edit comment** or **Delete comment**. | ||
| 4. If editing, the message text appears in the composer at the bottom of the screen. Edit it there, then tap the **Send** icon to save your changes. | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Readability / step formatting: This step is doing a lot of work -- it describes where the text appears, instructs the user to edit, and then instructs them to tap Send. Per the step formatting standard (HELP_AUTHORING_GUIDELINES.md Section 5), steps should be clear and action-oriented. Consider splitting into two steps for clarity: There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
On narrow/mobile layouts, editing a message changes the composer button from Send to Save changes with a checkmark icon ( Useful? React with 👍 / 👎. |
||
|
|
||
| ✏️ **Note:** You can only edit or delete your own messages. Deleted messages are permanently removed. | ||
|
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Naming convention mismatch: The navigation instruction standards in
HELPSITE_NAMING_CONVENTIONS.mduse "Web:" and "Mobile:" as the canonical platform labels (see "If Web and Mobile Navigation Differ" section). This should read**Web:**instead of**On Desktop:**to stay consistent with the governance standard.