[NO QA] Add Travel CR to all integrations#91027
Conversation
This reverts commit 2d0d79b.
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
allgandalf
left a comment
There was a problem hiding this comment.
LGTM! Thanks!!
I just wonder if we should hold on merging the FE PR till BE changes are done for each integration, for now it's safe because of getIsTravelInvoicingEnabled since no customer has it, but we need to make sure that we complete the backend of these toggles before we onboarding new customers with these integrations
Fair point! @rlinoz what do you think of this? |
Netsuite builds the screen in a different way, so I didn't bother refactoring, at least in this PR.
I prefer this to prevet the branch from getting stale, good idea. |
|
Removed all usages |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
|
🚧 @blimpich has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/blimpich in version: 9.3.79-1 🚀
Bundle Size Analysis (Sentry): |
|
No help site changes required for this PR. This PR creates the shared Help site docs should be updated when the follow-up PRs wire this component into the actual pages:
At that point, the Advanced settings sections in these docs will need a new bullet for the toggle:
|
|
🚀 Deployed to production by https://github.com/roryabraham in version: 9.3.79-4 🚀
|
Explanation of Change
When checking all the ECard CR integrations they all use the same fields, so instead of creating 4 different PRs this PR creates a TravelInvoicingContinuousReconciliationSection component and uses that in all advanced integrations settings
Fixed Issues
$ #90990
$ #90989
$ #90988
$ #90987
PROPOSAL:
Tests
Offline tests
QA Steps
Will be fully tested with the IS changes
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps./** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)Screenshots/Videos
Screen.Recording.2026-05-18.at.20.41.40.mov
Screen.Recording.2026-05-18.at.20.44.40.mov
Screen.Recording.2026-05-18.at.20.46.06.mov