[HOLD IS 8988] Add Travel Invoicing CR to Xero advanced page#91506
Open
allgandalf wants to merge 3 commits into
Open
[HOLD IS 8988] Add Travel Invoicing CR to Xero advanced page#91506allgandalf wants to merge 3 commits into
allgandalf wants to merge 3 commits into
Conversation
|
@ikevin127 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Contributor
Author
|
Please ignore the bump @ikevin127 @JmillsExpensify |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Imports the shared
TravelInvoicingContinuousReconciliationSectioncomponent (from #91027) into the Xero advanced accounting page so admins can toggle Travel Invoicing continuous reconciliation and pick the reconciliation bank account on Xero workspaces. The component handles the toggle, navigation to the bank account picker, and offline pending action display, withconnectionName={CONST.POLICY.CONNECTIONS.NAME.XERO}passed through. Backend in https://github.com/Expensify/Integration-Server/pull/8988.Fixed Issues
$ #90993
PROPOSAL:
Tests
./script/clitools.sh expensifytravel:setupInvoicing --enable) and provision Expensify Cards (./script/clitools.sh expensifycard:policy)Offline tests
Turn off network, toggle the TI CR row. Verify the change displays with pending action styling, then settles once the network is back. Same for selecting a reconciliation bank account.
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
Same as Tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari