Use run-claude-action composite in claude-review.yml#91618
Closed
kacper-mikolajczak wants to merge 2 commits into
Closed
Use run-claude-action composite in claude-review.yml#91618kacper-mikolajczak wants to merge 2 commits into
kacper-mikolajczak wants to merge 2 commits into
Conversation
Replaces the two direct anthropics/claude-code-action invocations (code review and docs review) with the shared composite at Expensify/GitHub-Actions/.github/actions/run-claude-action. The composite pins the upstream SHA once and applies the common defaults (model, display_report, allowed_non_write_users); caller-specific claude_args (allowedTools, json-schema) stay in this workflow. Net behaviour is unchanged: same upstream SHA, same model, same defaults.
The composite no longer injects --model. App opts into Opus by passing --model claude-opus-4-6 in claude_args for both the code-review and docs-review invocations - matching the model App used before this PR.
51 tasks
Contributor
Author
|
Superseded by #91689 (consolidated slice 2 work into one PR per repo). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Rewires both
claude-code-actioninvocations in.github/workflows/claude-review.yml(code review and docs review) to use the new shared composite atExpensify/GitHub-Actions/.github/actions/run-claude-action.The composite pins the
anthropics/claude-code-actionSHA in a single place so future bumps require touching only that composite instead of three client workflows. Caller-specificclaude_args(--allowedTools,--json-schema) stay in this workflow because they vary per invocation - App's code review uses different tools than App's docs review.Net behaviour is unchanged: same upstream SHA (
ba026a3e56b9f646ae3b1be02dd9c0812aa2f8ae/v1.0.86), same model (claude-opus-4-6), samedisplay_report/allowed_non_write_usersdefaults.The composite reference uses a placeholder SHA on the branch tip of the GitHub-Actions PR; it will be re-stamped to the merged-main SHA once that PR lands.
Related Issues
https://github.com/Expensify/Expensify/issues/635397
Depends on Expensify/GitHub-Actions#67 (composite action source).
Manual Tests
Diff is a pure mechanical swap (one
uses:line + drop of inputs now defaulted by the composite). Runtime parity verified by inspection - same SHA pin, same defaults, sameclaude_argscontent modulo the now-defaulted--modelline.Linked PRs